diff mbox series

[v2,2/2] package/python-bitstring: add missing runtime dependency

Message ID 20240207084503.11109-2-romain.naour@smile.fr
State Accepted
Headers show
Series [v2,1/2] package/python-bitarray: new package | expand

Commit Message

Romain Naour Feb. 7, 2024, 8:45 a.m. UTC
python-bitstring require python-bitarray and python-zlib at runtime
since 4.1.0 release [1][2].

python-zlib is now needed for the "Experimental support for two 8-bit
float types" [2].

Fixes:
https://gitlab.com/kubu93/buildroot/-/jobs/6114047821

[1] https://github.com/scott-griffiths/bitstring/releases/tag/bitstring-4.1.0
[2] https://github.com/scott-griffiths/bitstring/commit/70c8af4d8bef557bc7d96f809d37e2c241587dd0

Signed-off-by: Romain Naour <romain.naour@smile.fr>
Cc: James Hilliard <james.hilliard1@gmail.com>
---
v2: fix commit log about python-bitstring release (Marcus Hoffmann)
    reproduce the issue on gitlab-ci and update the Fixes tag url.
---
 package/python-bitstring/Config.in | 2 ++
 1 file changed, 2 insertions(+)

Comments

Marcus Hoffmann Feb. 7, 2024, 10:01 a.m. UTC | #1
On 07.02.24 09:45, Romain Naour wrote:
> python-bitstring require python-bitarray and python-zlib at runtime
> since 4.1.0 release [1][2].
> 
> python-zlib is now needed for the "Experimental support for two 8-bit
> float types" [2].
> 
> Fixes:
> https://gitlab.com/kubu93/buildroot/-/jobs/6114047821
> 
> [1] https://github.com/scott-griffiths/bitstring/releases/tag/bitstring-4.1.0
> [2] https://github.com/scott-griffiths/bitstring/commit/70c8af4d8bef557bc7d96f809d37e2c241587dd0
> 
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
> Cc: James Hilliard <james.hilliard1@gmail.com>

Reviewed-by: Marcus Hoffmann <buildroot@bubu1.eu>

> ---
> v2: fix commit log about python-bitstring release (Marcus Hoffmann)
>      reproduce the issue on gitlab-ci and update the Fixes tag url.
> ---
>   package/python-bitstring/Config.in | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/package/python-bitstring/Config.in b/package/python-bitstring/Config.in
> index 93d7682577..82d0bb29c6 100644
> --- a/package/python-bitstring/Config.in
> +++ b/package/python-bitstring/Config.in
> @@ -1,5 +1,7 @@
>   config BR2_PACKAGE_PYTHON_BITSTRING
>   	bool "python-bitstring"
> +	select BR2_PACKAGE_PYTHON_BITARRAY # runtime
> +	select BR2_PACKAGE_PYTHON3_ZLIB # runtime
>   	help
>   	  Simple construction, analysis and modification of binary data.
>
Peter Korsgaard March 1, 2024, 10:10 a.m. UTC | #2
>>>>> "Romain" == Romain Naour <romain.naour@smile.fr> writes:

 > python-bitstring require python-bitarray and python-zlib at runtime
 > since 4.1.0 release [1][2].

 > python-zlib is now needed for the "Experimental support for two 8-bit
 > float types" [2].

 > Fixes:
 > https://gitlab.com/kubu93/buildroot/-/jobs/6114047821

 > [1] https://github.com/scott-griffiths/bitstring/releases/tag/bitstring-4.1.0
 > [2] https://github.com/scott-griffiths/bitstring/commit/70c8af4d8bef557bc7d96f809d37e2c241587dd0

 > Signed-off-by: Romain Naour <romain.naour@smile.fr>
 > Cc: James Hilliard <james.hilliard1@gmail.com>
 > ---
 > v2: fix commit log about python-bitstring release (Marcus Hoffmann)
 >     reproduce the issue on gitlab-ci and update the Fixes tag url.

Committed to 2023.11.x, thanks.
diff mbox series

Patch

diff --git a/package/python-bitstring/Config.in b/package/python-bitstring/Config.in
index 93d7682577..82d0bb29c6 100644
--- a/package/python-bitstring/Config.in
+++ b/package/python-bitstring/Config.in
@@ -1,5 +1,7 @@ 
 config BR2_PACKAGE_PYTHON_BITSTRING
 	bool "python-bitstring"
+	select BR2_PACKAGE_PYTHON_BITARRAY # runtime
+	select BR2_PACKAGE_PYTHON3_ZLIB # runtime
 	help
 	  Simple construction, analysis and modification of binary data.