mbox series

[v1,0/5] TEE: minor cleanup

Message ID 20240214183444.493629-1-igor.opaniuk@gmail.com
Headers show
Series TEE: minor cleanup | expand

Message

Igor Opaniuk Feb. 14, 2024, 6:34 p.m. UTC 
- Address some spelling errors and typos
- Support CMD_OPTEE_RPMB for SANDBOX configurations and add python tests
- Remove common.h inclusion for drivers/tee

Igor Opaniuk (5):
  tee: optee: fix description in Kconfig
  tee: sandbox: fix spelling errors
  cmd: optee_rpmb: build cmd for sandbox
  test: py: add optee_rpmb tests
  tee: remove common.h inclusion

 cmd/Kconfig                        |  4 +++-
 drivers/tee/broadcom/chimp_optee.c |  2 +-
 drivers/tee/optee/Kconfig          |  2 +-
 drivers/tee/optee/core.c           |  1 -
 drivers/tee/optee/i2c.c            |  1 -
 drivers/tee/optee/rpmb.c           |  1 -
 drivers/tee/optee/supplicant.c     |  2 +-
 drivers/tee/sandbox.c              | 10 +++++-----
 drivers/tee/tee-uclass.c           |  1 -
 test/py/tests/test_optee_rpmb.py   | 20 ++++++++++++++++++++
 10 files changed, 31 insertions(+), 13 deletions(-)
 create mode 100644 test/py/tests/test_optee_rpmb.py

Comments

Igor Opaniuk Feb. 29, 2024, 7:11 p.m. UTC | #1 
Hi Ilias,

On Wed, Feb 14, 2024 at 7:34 PM Igor Opaniuk <igor.opaniuk@foundries.io>
wrote:

> - Address some spelling errors and typos
> - Support CMD_OPTEE_RPMB for SANDBOX configurations and add python tests
> - Remove common.h inclusion for drivers/tee
>
> Igor Opaniuk (5):
>   tee: optee: fix description in Kconfig
>   tee: sandbox: fix spelling errors
>   cmd: optee_rpmb: build cmd for sandbox
>   test: py: add optee_rpmb tests
>   tee: remove common.h inclusion
>
>  cmd/Kconfig                        |  4 +++-
>  drivers/tee/broadcom/chimp_optee.c |  2 +-
>  drivers/tee/optee/Kconfig          |  2 +-
>  drivers/tee/optee/core.c           |  1 -
>  drivers/tee/optee/i2c.c            |  1 -
>  drivers/tee/optee/rpmb.c           |  1 -
>  drivers/tee/optee/supplicant.c     |  2 +-
>  drivers/tee/sandbox.c              | 10 +++++-----
>  drivers/tee/tee-uclass.c           |  1 -
>  test/py/tests/test_optee_rpmb.py   | 20 ++++++++++++++++++++
>  10 files changed, 31 insertions(+), 13 deletions(-)
>  create mode 100644 test/py/tests/test_optee_rpmb.py
>
> --
> 2.34.1
>
>
Are there currently any comments/objections that can prevent these cosmetic
changes from being applied? If there are - just let me know, thanks

Regards,
Igor
Peter Robinson Feb. 29, 2024, 7:25 p.m. UTC | #2 
On Thu, 29 Feb 2024 at 19:11, Igor Opaniuk <igor.opaniuk@gmail.com> wrote:
>
> Hi Ilias,
>
> On Wed, Feb 14, 2024 at 7:34 PM Igor Opaniuk <igor.opaniuk@foundries.io>
> wrote:
>
> > - Address some spelling errors and typos
> > - Support CMD_OPTEE_RPMB for SANDBOX configurations and add python tests
> > - Remove common.h inclusion for drivers/tee
> >
> > Igor Opaniuk (5):
> >   tee: optee: fix description in Kconfig
> >   tee: sandbox: fix spelling errors
> >   cmd: optee_rpmb: build cmd for sandbox
> >   test: py: add optee_rpmb tests
> >   tee: remove common.h inclusion
> >
> >  cmd/Kconfig                        |  4 +++-
> >  drivers/tee/broadcom/chimp_optee.c |  2 +-
> >  drivers/tee/optee/Kconfig          |  2 +-
> >  drivers/tee/optee/core.c           |  1 -
> >  drivers/tee/optee/i2c.c            |  1 -
> >  drivers/tee/optee/rpmb.c           |  1 -
> >  drivers/tee/optee/supplicant.c     |  2 +-
> >  drivers/tee/sandbox.c              | 10 +++++-----
> >  drivers/tee/tee-uclass.c           |  1 -
> >  test/py/tests/test_optee_rpmb.py   | 20 ++++++++++++++++++++
> >  10 files changed, 31 insertions(+), 13 deletions(-)
> >  create mode 100644 test/py/tests/test_optee_rpmb.py
> >
> > --
> > 2.34.1
> >
> >
> Are there currently any comments/objections that can prevent these cosmetic
> changes from being applied? If there are - just let me know, thanks

Probably awaiting the next dev cycle, we're post RC3 now so it's
mostly fixes landing ATM.
Tom Rini Feb. 29, 2024, 7:38 p.m. UTC | #3 
On Thu, Feb 29, 2024 at 07:25:10PM +0000, Peter Robinson wrote:
> On Thu, 29 Feb 2024 at 19:11, Igor Opaniuk <igor.opaniuk@gmail.com> wrote:
> >
> > Hi Ilias,
> >
> > On Wed, Feb 14, 2024 at 7:34 PM Igor Opaniuk <igor.opaniuk@foundries.io>
> > wrote:
> >
> > > - Address some spelling errors and typos
> > > - Support CMD_OPTEE_RPMB for SANDBOX configurations and add python tests
> > > - Remove common.h inclusion for drivers/tee
> > >
> > > Igor Opaniuk (5):
> > >   tee: optee: fix description in Kconfig
> > >   tee: sandbox: fix spelling errors
> > >   cmd: optee_rpmb: build cmd for sandbox
> > >   test: py: add optee_rpmb tests
> > >   tee: remove common.h inclusion
> > >
> > >  cmd/Kconfig                        |  4 +++-
> > >  drivers/tee/broadcom/chimp_optee.c |  2 +-
> > >  drivers/tee/optee/Kconfig          |  2 +-
> > >  drivers/tee/optee/core.c           |  1 -
> > >  drivers/tee/optee/i2c.c            |  1 -
> > >  drivers/tee/optee/rpmb.c           |  1 -
> > >  drivers/tee/optee/supplicant.c     |  2 +-
> > >  drivers/tee/sandbox.c              | 10 +++++-----
> > >  drivers/tee/tee-uclass.c           |  1 -
> > >  test/py/tests/test_optee_rpmb.py   | 20 ++++++++++++++++++++
> > >  10 files changed, 31 insertions(+), 13 deletions(-)
> > >  create mode 100644 test/py/tests/test_optee_rpmb.py
> > >
> > > --
> > > 2.34.1
> > >
> > >
> > Are there currently any comments/objections that can prevent these cosmetic
> > changes from being applied? If there are - just let me know, thanks
> 
> Probably awaiting the next dev cycle, we're post RC3 now so it's
> mostly fixes landing ATM.

The -next branch is open too now tho, and I am picking up things out of
my queue. And other custodians can as well, time permitting :)
Ilias Apalodimas March 1, 2024, 9:40 a.m. UTC | #4 
Hi Igor,

On Thu, 29 Feb 2024 at 21:11, Igor Opaniuk <igor.opaniuk@gmail.com> wrote:
>
> Hi Ilias,
>
> On Wed, Feb 14, 2024 at 7:34 PM Igor Opaniuk <igor.opaniuk@foundries.io> wrote:
>>
>> - Address some spelling errors and typos
>> - Support CMD_OPTEE_RPMB for SANDBOX configurations and add python tests
>> - Remove common.h inclusion for drivers/tee

CI fails on https://source.denx.de/u-boot/custodians/u-boot-tpm/-/pipelines/19780
Can you have a look?

Thanks
/Ilias
>>
>> Igor Opaniuk (5):
>>   tee: optee: fix description in Kconfig
>>   tee: sandbox: fix spelling errors
>>   cmd: optee_rpmb: build cmd for sandbox
>>   test: py: add optee_rpmb tests
>>   tee: remove common.h inclusion
>>
>>  cmd/Kconfig                        |  4 +++-
>>  drivers/tee/broadcom/chimp_optee.c |  2 +-
>>  drivers/tee/optee/Kconfig          |  2 +-
>>  drivers/tee/optee/core.c           |  1 -
>>  drivers/tee/optee/i2c.c            |  1 -
>>  drivers/tee/optee/rpmb.c           |  1 -
>>  drivers/tee/optee/supplicant.c     |  2 +-
>>  drivers/tee/sandbox.c              | 10 +++++-----
>>  drivers/tee/tee-uclass.c           |  1 -
>>  test/py/tests/test_optee_rpmb.py   | 20 ++++++++++++++++++++
>>  10 files changed, 31 insertions(+), 13 deletions(-)
>>  create mode 100644 test/py/tests/test_optee_rpmb.py
>>
>> --
>> 2.34.1
>>
>
> Are there currently any comments/objections that can prevent these cosmetic
> changes from being applied? If there are - just let me know, thanks
>
> Regards,
> Igor
>
> --
> Best regards - Atentamente - Meilleures salutations
>
> Igor Opaniuk
>
> mailto: igor.opaniuk@gmail.com
> skype: igor.opanyuk
> http://ua.linkedin.com/in/iopaniuk
Igor Opaniuk March 2, 2024, 10:02 p.m. UTC | #5 
Hello Ilias,

On Fri, Mar 1, 2024 at 10:41 AM Ilias Apalodimas <
ilias.apalodimas@linaro.org> wrote:

> Hi Igor,
>
> On Thu, 29 Feb 2024 at 21:11, Igor Opaniuk <igor.opaniuk@gmail.com> wrote:
> >
> > Hi Ilias,
> >
> > On Wed, Feb 14, 2024 at 7:34 PM Igor Opaniuk <igor.opaniuk@foundries.io>
> wrote:
> >>
> >> - Address some spelling errors and typos
> >> - Support CMD_OPTEE_RPMB for SANDBOX configurations and add python tests
> >> - Remove common.h inclusion for drivers/tee
>
> CI fails on
> https://source.denx.de/u-boot/custodians/u-boot-tpm/-/pipelines/19780
> Can you have a look?
>
I've fixed and sent v2, thanks!


>
> Thanks
> /Ilias
> >>
> >> Igor Opaniuk (5):
> >>   tee: optee: fix description in Kconfig
> >>   tee: sandbox: fix spelling errors
> >>   cmd: optee_rpmb: build cmd for sandbox
> >>   test: py: add optee_rpmb tests
> >>   tee: remove common.h inclusion
> >>
> >>  cmd/Kconfig                        |  4 +++-
> >>  drivers/tee/broadcom/chimp_optee.c |  2 +-
> >>  drivers/tee/optee/Kconfig          |  2 +-
> >>  drivers/tee/optee/core.c           |  1 -
> >>  drivers/tee/optee/i2c.c            |  1 -
> >>  drivers/tee/optee/rpmb.c           |  1 -
> >>  drivers/tee/optee/supplicant.c     |  2 +-
> >>  drivers/tee/sandbox.c              | 10 +++++-----
> >>  drivers/tee/tee-uclass.c           |  1 -
> >>  test/py/tests/test_optee_rpmb.py   | 20 ++++++++++++++++++++
> >>  10 files changed, 31 insertions(+), 13 deletions(-)
> >>  create mode 100644 test/py/tests/test_optee_rpmb.py
> >>
> >> --
> >> 2.34.1
> >>
> >
> > Are there currently any comments/objections that can prevent these
> cosmetic
> > changes from being applied? If there are - just let me know, thanks
> >
> > Regards,
> > Igor
> >
> > --
> > Best regards - Atentamente - Meilleures salutations
> >
> > Igor Opaniuk
> >
> > mailto: igor.opaniuk@gmail.com
> > skype: igor.opanyuk
> > http://ua.linkedin.com/in/iopaniuk
>