| Message ID | 20240222085914.1218037-1-Kelly_Hung@asus.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] dt-bindings: arm: aspeed: add ASUS X4TF board | expand |
External email : Ensure your email is secure before opening links and attachments. Document the new compatibles used on ASUS X4TF. Signed-off-by: Kelly Hung <Kelly_Hung@asus.com> --- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml index 749ee54a3..80009948e 100644 --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml @@ -74,6 +74,7 @@ properties: - ampere,mtmitchell-bmc - aspeed,ast2600-evb - aspeed,ast2600-evb-a1 + - asus,x4tf-bmc - facebook,bletchley-bmc - facebook,cloudripper-bmc - facebook,elbert-bmc -- 2.25.1 <p></p> -----Original Message----- From: Conor Dooley <conor@kernel.org> Sent: Friday, February 23, 2024 12:02 AM To: Kelly Hung <ppighouse@gmail.com> Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; joel@jms.id.au; andrew@codeconstruct.com.au; devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org; openbmc@lists.ozlabs.org; Kelly Hung(洪嘉莉) <Kelly_Hung@asus.com>; AllenYY Hsu(許幼岳) <AllenYY_Hsu@asus.com> Subject: Re: [PATCH 1/2] dt-bindings: arm: aspeed: add ASUS X4TF board On Thu, Feb 22, 2024 at 04:59:13PM +0800, Kelly Hung wrote: > Document the new compatibles used on ASUS X4TF. It would be good to mention here what the x4tf is - is it a bmc or an sbc etc. Otherwise, Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor. > > Signed-off-by: Kelly Hung <Kelly_Hung@asus.com> > --- > Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > index 749ee54a3..80009948e 100644 > --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml > @@ -74,6 +74,7 @@ properties: > - ampere,mtmitchell-bmc > - aspeed,ast2600-evb > - aspeed,ast2600-evb-a1 > + - asus,x4tf > - facebook,bletchley-bmc > - facebook,cloudripper-bmc > - facebook,elbert-bmc > -- > 2.25.1 > =================================================================================================================================== This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. Please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK. For pricing information, ASUS is only entitled to set a recommendation resale price. All customers are free to set their own price as they wish. ===================================================================================================================================
I have no idea what his email is meant to mean, it just looks like a copy of your original patch. That said, you have a footer about the mail contents of being confidential, so please fix that too. Thanks, Conor.
On Thu, Feb 22, 2024 at 08:02:07AM PST, Conor Dooley wrote: >On Thu, Feb 22, 2024 at 04:59:13PM +0800, Kelly Hung wrote: >> Document the new compatibles used on ASUS X4TF. > >It would be good to mention here what the x4tf is - is it a bmc or >an sbc etc. > ...and if, as a quick web search indicates is likely the case, it's a BMC for a server (or family of servers), following the existing naming convention with something more like "asus,x4tf-bmc" might be nice. Also, Kelly -- when sending revised versions of patches please use the '-v' flag to git format-patch to include a version number in the subject line so it's clearer what's going on. (So when posting the next version incorporating the feedback on this one use '-v3', since this appears to be a v2.) Zev
diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml index 749ee54a3..80009948e 100644 --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml @@ -74,6 +74,7 @@ properties: - ampere,mtmitchell-bmc - aspeed,ast2600-evb - aspeed,ast2600-evb-a1 + - asus,x4tf - facebook,bletchley-bmc - facebook,cloudripper-bmc - facebook,elbert-bmc
Document the new compatibles used on ASUS X4TF. Signed-off-by: Kelly Hung <Kelly_Hung@asus.com> --- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + 1 file changed, 1 insertion(+)