Message ID | cover.1705140898.git.lukas@wunner.de |
---|---|
Headers | show |
Series | Add missing TPM compatible strings | expand |
On Sat Jan 13, 2024 at 7:10 PM EET, Lukas Wunner wrote: > Commit 420d439849ca ("tpm_tis: Allow tpm_tis to be bound using DT") > added the fallback compatible "tcg,tpm-tis-mmio" to the TPM TIS driver, > but not the chip-specific "atmel,at97sc3204". However it did document > it as a valid compatible string. > > Add it to tis_of_platform_match[] for consistency. > > Signed-off-by: Lukas Wunner <lukas@wunner.de> > Cc: Jason Gunthorpe <jgg@ziepe.ca> > --- > drivers/char/tpm/tpm_tis.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c > index 2c52b79..14652aa 100644 > --- a/drivers/char/tpm/tpm_tis.c > +++ b/drivers/char/tpm/tpm_tis.c > @@ -347,6 +347,7 @@ static void tpm_tis_plat_remove(struct platform_device *pdev) > > #ifdef CONFIG_OF > static const struct of_device_id tis_of_platform_match[] = { > + {.compatible = "atmel,at97sc3204"}, > {.compatible = "tcg,tpm-tis-mmio"}, > {}, > }; Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> BR, Jarkko
On Sat Jan 13, 2024 at 7:10 PM EET, Lukas Wunner wrote: > Add "nuvoton,npct75x" as well as the fallback compatible string > "tcg,tpm-tis-i2c" to the TPM TIS I²C driver. They're used by: > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-bonnell.dts > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts > > And by all accounts, NPCT75x is supported by the driver: > > https://lore.kernel.org/all/60e23fd0f0ff4d1f8954034237ae8865@NTILML02.nuvoton.com/ > https://lore.kernel.org/all/20220808220839.1006341-8-peter@pjd.dev/ > > Signed-off-by: Lukas Wunner <lukas@wunner.de> > --- > drivers/char/tpm/tpm_tis_i2c.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2c.c > index a897402..9511c0d 100644 > --- a/drivers/char/tpm/tpm_tis_i2c.c > +++ b/drivers/char/tpm/tpm_tis_i2c.c > @@ -383,6 +383,8 @@ static void tpm_tis_i2c_remove(struct i2c_client *client) > #ifdef CONFIG_OF > static const struct of_device_id of_tis_i2c_match[] = { > { .compatible = "infineon,slb9673", }, > + { .compatible = "nuvoton,npct75x", }, > + { .compatible = "tcg,tpm-tis-i2c", }, > {} > }; > MODULE_DEVICE_TABLE(of, of_tis_i2c_match); Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> BR, Jarkko
Dear Jarkko, since v6.8-rc6 is approaching and the end of this cycle is thus in sight, please do not forget to merge this series: https://lore.kernel.org/all/cover.1705140898.git.lukas@wunner.de/ All 4 patches have a Reviewed-by from you and patch 1 has an Acked-by from Rob. Thanks, Lukas
On Tue Feb 20, 2024 at 10:55 AM UTC, Lukas Wunner wrote: > Dear Jarkko, > > since v6.8-rc6 is approaching and the end of this cycle is thus in sight, > please do not forget to merge this series: > > https://lore.kernel.org/all/cover.1705140898.git.lukas@wunner.de/ > > All 4 patches have a Reviewed-by from you and patch 1 has an Acked-by > from Rob. > > Thanks, > > Lukas Thanks for reminding! Since this patch set only has DT changes and zero actual TPM driver changes, I think it would be better if Rob picked this. Rob, what you think? I'm good either way but need to check. BR, Jarkko
On Tue Feb 20, 2024 at 6:06 PM UTC, Jarkko Sakkinen wrote: > On Tue Feb 20, 2024 at 10:55 AM UTC, Lukas Wunner wrote: > > Dear Jarkko, > > > > since v6.8-rc6 is approaching and the end of this cycle is thus in sight, > > please do not forget to merge this series: > > > > https://lore.kernel.org/all/cover.1705140898.git.lukas@wunner.de/ > > > > All 4 patches have a Reviewed-by from you and patch 1 has an Acked-by > > from Rob. > > > > Thanks, > > > > Lukas > > Thanks for reminding! > > Since this patch set only has DT changes and zero actual TPM driver > changes, I think it would be better if Rob picked this. > > Rob, what you think? > > I'm good either way but need to check. Ah, sorry I was looking at wrong lore link (had multiple tabs open). I will definitely pick this despite one DT patch. Rob, please ignore. Sorry for causing confusion. BR, Jarkko
On Tue Feb 20, 2024 at 6:09 PM UTC, Jarkko Sakkinen wrote: > On Tue Feb 20, 2024 at 6:06 PM UTC, Jarkko Sakkinen wrote: > > On Tue Feb 20, 2024 at 10:55 AM UTC, Lukas Wunner wrote: > > > Dear Jarkko, > > > > > > since v6.8-rc6 is approaching and the end of this cycle is thus in sight, > > > please do not forget to merge this series: > > > > > > https://lore.kernel.org/all/cover.1705140898.git.lukas@wunner.de/ > > > > > > All 4 patches have a Reviewed-by from you and patch 1 has an Acked-by > > > from Rob. > > > > > > Thanks, > > > > > > Lukas > > > > Thanks for reminding! > > > > Since this patch set only has DT changes and zero actual TPM driver > > changes, I think it would be better if Rob picked this. > > > > Rob, what you think? > > > > I'm good either way but need to check. > > Ah, sorry I was looking at wrong lore link (had multiple tabs open). > > I will definitely pick this despite one DT patch. Rob, please ignore. > > Sorry for causing confusion. OK, should be good now: https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/log/?h=next BR, Jarkko