| Message ID | 20240215134856.1313239-6-quic_mdalam@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add QPIC SPI NAND driver | expand |
On Thu, 15 Feb 2024 at 15:49, Md Sadre Alam <quic_mdalam@quicinc.com> wrote: > > Disable eMMC node for rdp433, since rdp433 default boot mode > is norplusnand. Are they exclusive? > > Co-developed-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> > Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> > Co-developed-by: Varadarajan Narayanan <quic_varada@quicinc.com> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com> > --- > arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > index 1bb8d96c9a82..e33e7fafd695 100644 > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > @@ -24,7 +24,7 @@ &sdhc_1 { > mmc-hs400-enhanced-strobe; > max-frequency = <384000000>; > bus-width = <8>; > - status = "okay"; > + status = "disabled"; > }; > > &tlmm { > -- > 2.34.1 > >
On 15.02.2024 16:00, Dmitry Baryshkov wrote: > On Thu, 15 Feb 2024 at 15:49, Md Sadre Alam <quic_mdalam@quicinc.com> wrote: >> >> Disable eMMC node for rdp433, since rdp433 default boot mode >> is norplusnand. > > Are they exclusive? Even if they're not, having access to the eMMC/sdcard would still be nice.. Konrad
On 2/15/2024 7:18 PM, Md Sadre Alam wrote: > Disable eMMC node for rdp433, since rdp433 default boot mode > is norplusnand. > > Co-developed-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> > Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> > Co-developed-by: Varadarajan Narayanan <quic_varada@quicinc.com> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com> Single line of change is developed by 3 authors? > --- > arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > index 1bb8d96c9a82..e33e7fafd695 100644 > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > @@ -24,7 +24,7 @@ &sdhc_1 { > mmc-hs400-enhanced-strobe; > max-frequency = <384000000>; > bus-width = <8>; > - status = "okay"; > + status = "disabled"; > }; > > &tlmm {
On 2/15/2024 8:30 PM, Dmitry Baryshkov wrote: > On Thu, 15 Feb 2024 at 15:49, Md Sadre Alam <quic_mdalam@quicinc.com> wrote: >> >> Disable eMMC node for rdp433, since rdp433 default boot mode >> is norplusnand. > > Are they exclusive? Yes its exclusive, gpios are shared b/w NAND and eMMC so that only one could get enable. > >> >> Co-developed-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> >> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> >> Co-developed-by: Varadarajan Narayanan <quic_varada@quicinc.com> >> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> >> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts >> index 1bb8d96c9a82..e33e7fafd695 100644 >> --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts >> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts >> @@ -24,7 +24,7 @@ &sdhc_1 { >> mmc-hs400-enhanced-strobe; >> max-frequency = <384000000>; >> bus-width = <8>; >> - status = "okay"; >> + status = "disabled"; >> }; >> >> &tlmm { >> -- >> 2.34.1 >> >> > >
On 2/15/2024 11:28 PM, Konrad Dybcio wrote: > On 15.02.2024 16:00, Dmitry Baryshkov wrote: >> On Thu, 15 Feb 2024 at 15:49, Md Sadre Alam <quic_mdalam@quicinc.com> wrote: >>> >>> Disable eMMC node for rdp433, since rdp433 default boot mode >>> is norplusnand. >> >> Are they exclusive? > > Even if they're not, having access to the eMMC/sdcard would still > be nice.. GPIO are shared b/w eMMC and NAND so we can't keep both. > > Konrad
On 2/16/2024 9:13 PM, Kathiravan Thirumoorthy wrote: > > > On 2/15/2024 7:18 PM, Md Sadre Alam wrote: >> Disable eMMC node for rdp433, since rdp433 default boot mode >> is norplusnand. >> >> Co-developed-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> >> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> >> Co-developed-by: Varadarajan Narayanan <quic_varada@quicinc.com> >> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> >> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com> > > > Single line of change is developed by 3 authors? Will fix in next patch. > > >> --- >> arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts >> index 1bb8d96c9a82..e33e7fafd695 100644 >> --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts >> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts >> @@ -24,7 +24,7 @@ &sdhc_1 { >> mmc-hs400-enhanced-strobe; >> max-frequency = <384000000>; >> bus-width = <8>; >> - status = "okay"; >> + status = "disabled"; >> }; >> &tlmm {
diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts index 1bb8d96c9a82..e33e7fafd695 100644 --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts @@ -24,7 +24,7 @@ &sdhc_1 { mmc-hs400-enhanced-strobe; max-frequency = <384000000>; bus-width = <8>; - status = "okay"; + status = "disabled"; }; &tlmm {