mbox series

[SRU,j/linux-raspi,v2,0/2] Make snapcraft.yaml work

Message ID 20240219083705.2291380-1-masahiro.yamada@canonical.com
Headers show
Series Make snapcraft.yaml work | expand

Message

Masahiro Yamada Feb. 19, 2024, 8:37 a.m. UTC
linux-raspi added snapcraft.yaml more than a decade ago,
which is not functional at all.

Remove the old one, and re-implement working snapcraft.yaml.

BugLink: https://bugs.launchpad.net/bugs/2051468

SRU Justification:

Impact:

  The in-tree snapcraft.yaml is stale. It does not produce any functional kernel
  snap for jammy:linux-raspi.

Fix:
  Replace the stale snapcraft.yaml with a newly implemented one.

Testcase:

   Build a pi-kernel with the following command:

   [for arm64]

    $ snapcraft --use-lxd --build-for=arm64

   [for armhf]

    $ snapcraft --use-lxd --build-for=armhf

   Then, install it to Ubuntu Core 22 running on a raspi board.

    $ snap install --dangerous <kernel-snap>

   Please note you need "grade: dangerous" for replacing
   the kernel using the local snap.



Masahiro Yamada (2):
  UBUNTU: [Packaging] Remove old snapcraft.yaml
  UBUNTU: [Packaging] Add snapcraft.yaml for building uc22 pi-kernel
    snap

 snapcraft.yaml | 175 ++++++++++++++++++++++++++++++++++++++++---------
 1 file changed, 145 insertions(+), 30 deletions(-)

Comments

Juerg Haefliger Feb. 19, 2024, 10:06 a.m. UTC | #1
On Mon, 19 Feb 2024 17:37:03 +0900
Masahiro Yamada <masahiro.yamada@canonical.com> wrote:

> linux-raspi added snapcraft.yaml more than a decade ago,
> which is not functional at all.
> 
> Remove the old one, and re-implement working snapcraft.yaml.
> 
> BugLink: https://bugs.launchpad.net/bugs/2051468
> 
> SRU Justification:
> 
> Impact:
> 
>   The in-tree snapcraft.yaml is stale. It does not produce any functional kernel
>   snap for jammy:linux-raspi.
> 
> Fix:
>   Replace the stale snapcraft.yaml with a newly implemented one.
> 
> Testcase:
> 
>    Build a pi-kernel with the following command:
> 
>    [for arm64]
> 
>     $ snapcraft --use-lxd --build-for=arm64
> 
>    [for armhf]
> 
>     $ snapcraft --use-lxd --build-for=armhf
> 
>    Then, install it to Ubuntu Core 22 running on a raspi board.
> 
>     $ snap install --dangerous <kernel-snap>
> 
>    Please note you need "grade: dangerous" for replacing
>    the kernel using the local snap.


Acked-by: Juerg Haefliger <juerg.haefliger@canonical.com>


> 
> 
> 
> Masahiro Yamada (2):
>   UBUNTU: [Packaging] Remove old snapcraft.yaml
>   UBUNTU: [Packaging] Add snapcraft.yaml for building uc22 pi-kernel
>     snap
> 
>  snapcraft.yaml | 175 ++++++++++++++++++++++++++++++++++++++++---------
>  1 file changed, 145 insertions(+), 30 deletions(-)
>
Manuel Diewald Feb. 19, 2024, 10:16 a.m. UTC | #2
On Mon, Feb 19, 2024 at 05:37:03PM +0900, Masahiro Yamada wrote:
> linux-raspi added snapcraft.yaml more than a decade ago,
> which is not functional at all.
> 
> Remove the old one, and re-implement working snapcraft.yaml.
> 
> BugLink: https://bugs.launchpad.net/bugs/2051468
> 
> SRU Justification:
> 
> Impact:
> 
>   The in-tree snapcraft.yaml is stale. It does not produce any functional kernel
>   snap for jammy:linux-raspi.
> 
> Fix:
>   Replace the stale snapcraft.yaml with a newly implemented one.
> 
> Testcase:
> 
>    Build a pi-kernel with the following command:
> 
>    [for arm64]
> 
>     $ snapcraft --use-lxd --build-for=arm64
> 
>    [for armhf]
> 
>     $ snapcraft --use-lxd --build-for=armhf
> 
>    Then, install it to Ubuntu Core 22 running on a raspi board.
> 
>     $ snap install --dangerous <kernel-snap>
> 
>    Please note you need "grade: dangerous" for replacing
>    the kernel using the local snap.
> 
> 
> 
> Masahiro Yamada (2):
>   UBUNTU: [Packaging] Remove old snapcraft.yaml
>   UBUNTU: [Packaging] Add snapcraft.yaml for building uc22 pi-kernel
>     snap
> 
>  snapcraft.yaml | 175 ++++++++++++++++++++++++++++++++++++++++---------
>  1 file changed, 145 insertions(+), 30 deletions(-)
> 
> -- 
> 2.40.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Please add 'Jammy' as the target series in the LP bug by using the
'Target to series' button.

Acked-by: Manuel Diewald <manuel.diewald@canonical.com>
Juerg Haefliger Feb. 19, 2024, 3:57 p.m. UTC | #3
Applied to jammy/linux-raspi master-next branch.

...Juerg


On Mon, 19 Feb 2024 17:37:03 +0900
Masahiro Yamada <masahiro.yamada@canonical.com> wrote:

> linux-raspi added snapcraft.yaml more than a decade ago,
> which is not functional at all.
> 
> Remove the old one, and re-implement working snapcraft.yaml.
> 
> BugLink: https://bugs.launchpad.net/bugs/2051468
> 
> SRU Justification:
> 
> Impact:
> 
>   The in-tree snapcraft.yaml is stale. It does not produce any functional kernel
>   snap for jammy:linux-raspi.
> 
> Fix:
>   Replace the stale snapcraft.yaml with a newly implemented one.
> 
> Testcase:
> 
>    Build a pi-kernel with the following command:
> 
>    [for arm64]
> 
>     $ snapcraft --use-lxd --build-for=arm64
> 
>    [for armhf]
> 
>     $ snapcraft --use-lxd --build-for=armhf
> 
>    Then, install it to Ubuntu Core 22 running on a raspi board.
> 
>     $ snap install --dangerous <kernel-snap>
> 
>    Please note you need "grade: dangerous" for replacing
>    the kernel using the local snap.
> 
> 
> 
> Masahiro Yamada (2):
>   UBUNTU: [Packaging] Remove old snapcraft.yaml
>   UBUNTU: [Packaging] Add snapcraft.yaml for building uc22 pi-kernel
>     snap
> 
>  snapcraft.yaml | 175 ++++++++++++++++++++++++++++++++++++++++---------
>  1 file changed, 145 insertions(+), 30 deletions(-)
>