diff mbox series

[19/21] configs/ti_am62x_sk_defconfig: update to uboot 2024.01 to use binman tool

Message ID 20240213172817.2872849-20-romain.naour@smile.fr
State Superseded
Headers show
Series Add ti_j721e_sk_defconfig | expand

Commit Message

Romain Naour Feb. 13, 2024, 5:28 p.m. UTC 
Update u-boot for a53 and r5 core to 2024.01 and enable binman support
in order to remove BR2_TARGET_TI_K3_IMAGE_GEN.

Signed-off-by: Romain Naour <romain.naour@smile.fr>
---
 configs/ti_am62x_sk_defconfig | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

Comments

Alexander Sverdlin Feb. 14, 2024, 10:59 a.m. UTC | #1 
Hi Romain,

On Tue, 2024-02-13 at 18:28 +0100, Romain Naour wrote:
> Update u-boot for a53 and r5 core to 2024.01 and enable binman support
> in order to remove BR2_TARGET_TI_K3_IMAGE_GEN.
> 
> Signed-off-by: Romain Naour <romain.naour@smile.fr>

Looks good to me in principle, so
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>

But maybe you could add a word into commit message about updated ATF
if you'll re-spin.

> ---
>  configs/ti_am62x_sk_defconfig | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/configs/ti_am62x_sk_defconfig b/configs/ti_am62x_sk_defconfig
> index c3ad555a81..f725734551 100644
> --- a/configs/ti_am62x_sk_defconfig
> +++ b/configs/ti_am62x_sk_defconfig
> @@ -16,25 +16,29 @@ BR2_TARGET_ROOTFS_EXT2_4=y
>  BR2_TARGET_ROOTFS_EXT2_SIZE="256M"
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION=y
> -BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE="v2.7"
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE="v2.10"
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="k3"
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE_TARGET_BOARD="lite"
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL32_OPTEE=y
>  BR2_TARGET_OPTEE_OS=y
>  BR2_TARGET_OPTEE_OS_PLATFORM="k3-am62x"
> -BR2_TARGET_TI_K3_IMAGE_GEN=y
> -BR2_TARGET_TI_K3_IMAGE_GEN_SOC_AM62X=y
> +BR2_TARGET_TI_K3_BOOT_FIRMWARE=y
> +BR2_TARGET_TI_K3_BOOT_FIRMWARE_SOC_AM62X=y
>  BR2_TARGET_TI_K3_R5_LOADER=y
> +BR2_TARGET_TI_K3_R5_LOADER_CUSTOM_VERSION=y
> +BR2_TARGET_TI_K3_R5_LOADER_CUSTOM_VERSION_VALUE="2024.01"
>  BR2_TARGET_TI_K3_R5_LOADER_BOARD_DEFCONFIG="am62x_evm_r5"
> +BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN=y
>  BR2_TARGET_UBOOT=y
>  BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
>  BR2_TARGET_UBOOT_CUSTOM_VERSION=y
> -BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.10"
> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2024.01"
>  BR2_TARGET_UBOOT_BOARD_DEFCONFIG="am62x_evm_a53"
>  BR2_TARGET_UBOOT_NEEDS_DTC=y
>  BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
>  BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
>  BR2_TARGET_UBOOT_NEEDS_TI_K3_DM=y
> +BR2_TARGET_UBOOT_USE_BINMAN=y
>  # BR2_TARGET_UBOOT_FORMAT_BIN is not set
>  BR2_TARGET_UBOOT_FORMAT_IMG=y
>  BR2_TARGET_UBOOT_SPL=y
Romain Naour Feb. 14, 2024, 3:24 p.m. UTC | #2 
Hi Alexander,

Le 14/02/2024 à 11:59, Alexander Sverdlin a écrit :
> Hi Romain,
> 
> On Tue, 2024-02-13 at 18:28 +0100, Romain Naour wrote:
>> Update u-boot for a53 and r5 core to 2024.01 and enable binman support
>> in order to remove BR2_TARGET_TI_K3_IMAGE_GEN.
>>
>> Signed-off-by: Romain Naour <romain.naour@smile.fr>
> 
> Looks good to me in principle, so
> Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> 
> But maybe you could add a word into commit message about updated ATF
> if you'll re-spin.

Ok.

I'll wait before re-spin if someone can do a runtime test.

Thanks for the review!

Best regards,
Romain


> 
>> ---
>>  configs/ti_am62x_sk_defconfig | 12 ++++++++----
>>  1 file changed, 8 insertions(+), 4 deletions(-)
>>
>> diff --git a/configs/ti_am62x_sk_defconfig b/configs/ti_am62x_sk_defconfig
>> index c3ad555a81..f725734551 100644
>> --- a/configs/ti_am62x_sk_defconfig
>> +++ b/configs/ti_am62x_sk_defconfig
>> @@ -16,25 +16,29 @@ BR2_TARGET_ROOTFS_EXT2_4=y
>>  BR2_TARGET_ROOTFS_EXT2_SIZE="256M"
>>  BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
>>  BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION=y
>> -BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE="v2.7"
>> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE="v2.10"
>>  BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="k3"
>>  BR2_TARGET_ARM_TRUSTED_FIRMWARE_TARGET_BOARD="lite"
>>  BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL32_OPTEE=y
>>  BR2_TARGET_OPTEE_OS=y
>>  BR2_TARGET_OPTEE_OS_PLATFORM="k3-am62x"
>> -BR2_TARGET_TI_K3_IMAGE_GEN=y
>> -BR2_TARGET_TI_K3_IMAGE_GEN_SOC_AM62X=y
>> +BR2_TARGET_TI_K3_BOOT_FIRMWARE=y
>> +BR2_TARGET_TI_K3_BOOT_FIRMWARE_SOC_AM62X=y
>>  BR2_TARGET_TI_K3_R5_LOADER=y
>> +BR2_TARGET_TI_K3_R5_LOADER_CUSTOM_VERSION=y
>> +BR2_TARGET_TI_K3_R5_LOADER_CUSTOM_VERSION_VALUE="2024.01"
>>  BR2_TARGET_TI_K3_R5_LOADER_BOARD_DEFCONFIG="am62x_evm_r5"
>> +BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN=y
>>  BR2_TARGET_UBOOT=y
>>  BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
>>  BR2_TARGET_UBOOT_CUSTOM_VERSION=y
>> -BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.10"
>> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2024.01"
>>  BR2_TARGET_UBOOT_BOARD_DEFCONFIG="am62x_evm_a53"
>>  BR2_TARGET_UBOOT_NEEDS_DTC=y
>>  BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
>>  BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
>>  BR2_TARGET_UBOOT_NEEDS_TI_K3_DM=y
>> +BR2_TARGET_UBOOT_USE_BINMAN=y
>>  # BR2_TARGET_UBOOT_FORMAT_BIN is not set
>>  BR2_TARGET_UBOOT_FORMAT_IMG=y
>>  BR2_TARGET_UBOOT_SPL=y
>
diff mbox series

Patch

diff --git a/configs/ti_am62x_sk_defconfig b/configs/ti_am62x_sk_defconfig
index c3ad555a81..f725734551 100644
--- a/configs/ti_am62x_sk_defconfig
+++ b/configs/ti_am62x_sk_defconfig
@@ -16,25 +16,29 @@  BR2_TARGET_ROOTFS_EXT2_4=y
 BR2_TARGET_ROOTFS_EXT2_SIZE="256M"
 BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
 BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION=y
-BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE="v2.7"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE="v2.10"
 BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="k3"
 BR2_TARGET_ARM_TRUSTED_FIRMWARE_TARGET_BOARD="lite"
 BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL32_OPTEE=y
 BR2_TARGET_OPTEE_OS=y
 BR2_TARGET_OPTEE_OS_PLATFORM="k3-am62x"
-BR2_TARGET_TI_K3_IMAGE_GEN=y
-BR2_TARGET_TI_K3_IMAGE_GEN_SOC_AM62X=y
+BR2_TARGET_TI_K3_BOOT_FIRMWARE=y
+BR2_TARGET_TI_K3_BOOT_FIRMWARE_SOC_AM62X=y
 BR2_TARGET_TI_K3_R5_LOADER=y
+BR2_TARGET_TI_K3_R5_LOADER_CUSTOM_VERSION=y
+BR2_TARGET_TI_K3_R5_LOADER_CUSTOM_VERSION_VALUE="2024.01"
 BR2_TARGET_TI_K3_R5_LOADER_BOARD_DEFCONFIG="am62x_evm_r5"
+BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN=y
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
 BR2_TARGET_UBOOT_CUSTOM_VERSION=y
-BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.10"
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2024.01"
 BR2_TARGET_UBOOT_BOARD_DEFCONFIG="am62x_evm_a53"
 BR2_TARGET_UBOOT_NEEDS_DTC=y
 BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
 BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
 BR2_TARGET_UBOOT_NEEDS_TI_K3_DM=y
+BR2_TARGET_UBOOT_USE_BINMAN=y
 # BR2_TARGET_UBOOT_FORMAT_BIN is not set
 BR2_TARGET_UBOOT_FORMAT_IMG=y
 BR2_TARGET_UBOOT_SPL=y