Message ID | 20240130145959.879882-3-d-gole@ti.com |
---|---|
State | Accepted |
Commit | c59720c5f4c592688d2899b352f446703c968666 |
Delegated to: | Tom Rini |
Headers | show |
Series | firmware: ti_sci: zero the secure_hdr in do_xfer | expand |
On Tue, Jan 30, 2024 at 08:30:00PM +0530, Dhruva Gole wrote: > Add a comment to explain the code under is_secure condition of > ti_sci_do_xfer. This will help avoid confusion amongst people who may in > future touch upon this code. > > Reviewed-by: Nishanth Menon <nm@ti.com> > Signed-off-by: Dhruva Gole <d-gole@ti.com> Applied to u-boot/master, thanks!
diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c index b77ac36af284..ee0921855881 100644 --- a/drivers/firmware/ti_sci.c +++ b/drivers/firmware/ti_sci.c @@ -239,6 +239,12 @@ static int ti_sci_do_xfer(struct ti_sci_info *info, struct ti_sci_secure_msg_hdr *secure_hdr = (struct ti_sci_secure_msg_hdr *)secure_buf; int ret; + /* + * The reason why we need the is_secure code is because of boot R5. + * boot R5 starts off in "secure mode" when it hands off from Boot + * ROM over to the Secondary bootloader. The initial set of calls + * we have to make need to be on a secure pipe. + */ if (info->is_secure) { /* ToDo: get checksum of the entire message */ secure_hdr->checksum = 0;