| Message ID | 20240206143711.2410135-1-msp@baylibre.com |
|---|---|
| Headers | show |
| Series | soc: ti: k3-socinfo: Add support for nvmem cells | expand |
On 2/6/24 8:37 AM, Markus Schneider-Pargmann wrote: > Add efuse nodes describing chip variant and speed grade. > > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com> > --- > arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 36 +++++++++++++++++++++- > 1 file changed, 35 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi > index fef76f52a52e..14419df43624 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi > @@ -14,10 +14,44 @@ wkup_conf: syscon@43000000 { > #size-cells = <1>; > ranges = <0x0 0x00 0x43000000 0x20000>; > > + wkup_efuse: efuse@0 { > + compatible = "socionext,uniphier-efuse"; > + #address-cells = <1>; > + #size-cells = <1>; > + reg = <0x0 0x200>; > + > + nvmem-layout { > + compatible = "fixed-layout"; > + #address-cells = <1>; > + #size-cells = <1>; > + > + chip_manufacturer: jtagidmfg@14 { > + reg = <0x14 0x2>; > + bits = <1 11>; > + }; > + > + chip_partno: jtagidpartno@15 { > + reg = <0x15 0x3>; > + bits = <4 16>; > + }; > + > + chip_variant: jtagidvariant@17 { > + reg = <0x17 0x1>; > + bits = <4 4>; > + }; > + > + chip_speed: jtaguseridspeed@18 { > + reg = <0x18 0x4>; > + bits = <6 5>; > + }; > + }; > + }; > + > chipid: chipid@14 { If you remove the reg property you will want to drop the @14 also or you will get a DT check warning. That needs fixed in the binding example too (and the binding nodename pattern). Andrew > bootph-all; > compatible = "ti,am654-chipid"; > - reg = <0x14 0x4>; > + nvmem-cells = <&chip_variant>, <&chip_partno>, <&chip_manufacturer>; > + nvmem-cell-names = "chipvariant", "chippartno", "chipmanufacturer"; > }; > }; >
On 06/02/2024 14:37, Markus Schneider-Pargmann wrote: > The actual size that nvmem is using internally on a specific platform > with a specific devicetree may not be known in the consumer code. The > maximum size may be available at the same time. > > Allow the use of larger buffers in nvmem_cell_read_common() by setting > buffers that are too large to zero before copying into them. > Can you explain why can we not use nvmem_cell_read() ? there is an other thread to add get_size https://www.spinics.net/lists/kernel/msg5075254.html > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com> > --- > drivers/nvmem/core.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > index 980123fb4dde..6fa061ede605 100644 > --- a/drivers/nvmem/core.c > +++ b/drivers/nvmem/core.c > @@ -1806,12 +1806,14 @@ static int nvmem_cell_read_common(struct device *dev, const char *cell_id, > nvmem_cell_put(cell); > return PTR_ERR(buf); > } > - if (len != count) { > + if (len > count) { > kfree(buf); > nvmem_cell_put(cell); > return -EINVAL; > + } else if (len < count) { > + memset(val + len, 0, count - len); no please.. this really does not belong here. --srini > } > - memcpy(val, buf, count); > + memcpy(val, buf, len); > kfree(buf); > nvmem_cell_put(cell); >