| Message ID | 20240201034027.406374-1-kai.heng.feng@canonical.com |
|---|---|
| Headers | show |
| Series | Fix spurious wakeup caused by Cirque touchpad | expand |
On 24/02/01 11:40AM, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/2051896 > > [Impact] > Spurious wakeup event caused by Cirque touchpad, prevent the system from > sleep properly. > > [Fix] > Skip SET_POWER SLEEP so there won't be any IRQ raised by the touchpad. > > [Test] > Suspend the system 100 times and make sure non of the wakeup event is > caused by the touchpad and its IRQ line. > > [Where problems could occur] > Logically the power consumption can increase slightly, but in reality > there isn't any noticeable change. Since the quirk only applies to one > device, there isn't much regression risk. > > Hans de Goede (2): > HID: i2c-hid: Remove I2C_HID_QUIRK_SET_PWR_WAKEUP_DEV quirk > HID: i2c-hid: Renumber I2C_HID_QUIRK_ defines > > Kai-Heng Feng (1): > HID: i2c-hid: Skip SET_POWER SLEEP for Cirque touchpad on system > suspend > > drivers/hid/hid-ids.h | 3 +++ > drivers/hid/i2c-hid/i2c-hid-core.c | 22 +++++++++++----------- > 2 files changed, 14 insertions(+), 11 deletions(-) Acked-by: Andrei Gherzan <andrei.gherzan@canonical.com>
On 1/31/24 8:40 PM, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/2051896 > > [Impact] > Spurious wakeup event caused by Cirque touchpad, prevent the system from > sleep properly. > > [Fix] > Skip SET_POWER SLEEP so there won't be any IRQ raised by the touchpad. > > [Test] > Suspend the system 100 times and make sure non of the wakeup event is > caused by the touchpad and its IRQ line. > > [Where problems could occur] > Logically the power consumption can increase slightly, but in reality > there isn't any noticeable change. Since the quirk only applies to one > device, there isn't much regression risk. > > Hans de Goede (2): > HID: i2c-hid: Remove I2C_HID_QUIRK_SET_PWR_WAKEUP_DEV quirk > HID: i2c-hid: Renumber I2C_HID_QUIRK_ defines > > Kai-Heng Feng (1): > HID: i2c-hid: Skip SET_POWER SLEEP for Cirque touchpad on system > suspend > > drivers/hid/hid-ids.h | 3 +++ > drivers/hid/i2c-hid/i2c-hid-core.c | 22 +++++++++++----------- > 2 files changed, 14 insertions(+), 11 deletions(-) > Acked-by: Tim Gardner <tim.gardner@canonical.com>
On 01/02/2024 04:40, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/2051896 > > [Impact] > Spurious wakeup event caused by Cirque touchpad, prevent the system from > sleep properly. > > [Fix] > Skip SET_POWER SLEEP so there won't be any IRQ raised by the touchpad. > > [Test] > Suspend the system 100 times and make sure non of the wakeup event is > caused by the touchpad and its IRQ line. > > [Where problems could occur] > Logically the power consumption can increase slightly, but in reality > there isn't any noticeable change. Since the quirk only applies to one > device, there isn't much regression risk. > > Hans de Goede (2): > HID: i2c-hid: Remove I2C_HID_QUIRK_SET_PWR_WAKEUP_DEV quirk > HID: i2c-hid: Renumber I2C_HID_QUIRK_ defines > > Kai-Heng Feng (1): > HID: i2c-hid: Skip SET_POWER SLEEP for Cirque touchpad on system > suspend > > drivers/hid/hid-ids.h | 3 +++ > drivers/hid/i2c-hid/i2c-hid-core.c | 22 +++++++++++----------- > 2 files changed, 14 insertions(+), 11 deletions(-) > Applied to mantic master-next branch. Thanks!
On Thu, Feb 01, 2024 at 11:40:24AM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/2051896
Upstream applied when moving to v6.8.
BugLink: https://bugs.launchpad.net/bugs/2051896 [Impact] Spurious wakeup event caused by Cirque touchpad, prevent the system from sleep properly. [Fix] Skip SET_POWER SLEEP so there won't be any IRQ raised by the touchpad. [Test] Suspend the system 100 times and make sure non of the wakeup event is caused by the touchpad and its IRQ line. [Where problems could occur] Logically the power consumption can increase slightly, but in reality there isn't any noticeable change. Since the quirk only applies to one device, there isn't much regression risk. Hans de Goede (2): HID: i2c-hid: Remove I2C_HID_QUIRK_SET_PWR_WAKEUP_DEV quirk HID: i2c-hid: Renumber I2C_HID_QUIRK_ defines Kai-Heng Feng (1): HID: i2c-hid: Skip SET_POWER SLEEP for Cirque touchpad on system suspend drivers/hid/hid-ids.h | 3 +++ drivers/hid/i2c-hid/i2c-hid-core.c | 22 +++++++++++----------- 2 files changed, 14 insertions(+), 11 deletions(-)