mbox series

[0/5] update venice dts

Message ID 20240205190858.3076363-1-tharvey@gateworks.com
Headers show
Series update venice dts | expand

Message

Tim Harvey Feb. 5, 2024, 7:08 p.m. UTC
This series brings some recent upstream Linux dt updates into U-Boot for
the Gateworks Venice family.

Tim Harvey (5):
  arm: dts: imx8mm-venice-gw7901: add digital I/O direction control GPIO's
  arm: dts: imx8mm-venice-gw7901: add TPM device
  arm: dts: imx8mm-venice-gw71xx: fix USB OTG VBUS
  arm: dts: imx8mm-venice-gw71xx: add TPM device
  arm: dts: imx8mp-venice-gw71xx: add TPM device

 .../dts/imx8mm-venice-gw71xx-0x-u-boot.dtsi   |  7 ++++
 arch/arm/dts/imx8mm-venice-gw71xx.dtsi        | 40 +++++++++----------
 arch/arm/dts/imx8mm-venice-gw7901-u-boot.dtsi | 14 +++++++
 arch/arm/dts/imx8mm-venice-gw7901.dts         | 14 ++++++-
 .../dts/imx8mp-venice-gw71xx-2x-u-boot.dtsi   |  9 +++++
 arch/arm/dts/imx8mp-venice-gw71xx.dtsi        | 10 ++++-
 6 files changed, 69 insertions(+), 25 deletions(-)

Comments

Fabio Estevam Feb. 5, 2024, 7:22 p.m. UTC | #1
Hi Tim,

On Mon, Feb 5, 2024 at 4:09 PM Tim Harvey <tharvey@gateworks.com> wrote:
>
> This series brings some recent upstream Linux dt updates into U-Boot for
> the Gateworks Venice family.

Please specify what "some recent upstream Linux dt" means.

Is it 6.8-rc, linux-next, or Shawn's tree?

Can't you instead sync the imx8mm-venice DTs in U-Boot with this kernel tree?

> Tim Harvey (5):
>   arm: dts: imx8mm-venice-gw7901: add digital I/O direction control GPIO's
>   arm: dts: imx8mm-venice-gw7901: add TPM device
>   arm: dts: imx8mm-venice-gw71xx: fix USB OTG VBUS
>   arm: dts: imx8mm-venice-gw71xx: add TPM device
>   arm: dts: imx8mp-venice-gw71xx: add TPM device
>
>  .../dts/imx8mm-venice-gw71xx-0x-u-boot.dtsi   |  7 ++++
>  arch/arm/dts/imx8mm-venice-gw71xx.dtsi        | 40 +++++++++----------
>  arch/arm/dts/imx8mm-venice-gw7901-u-boot.dtsi | 14 +++++++

Why is u-boot.dtsi being touched? Please add a justification.

>  arch/arm/dts/imx8mm-venice-gw7901.dts         | 14 ++++++-
>  .../dts/imx8mp-venice-gw71xx-2x-u-boot.dtsi   |  9 +++++

Same here.
Tim Harvey Feb. 5, 2024, 8:19 p.m. UTC | #2
On Mon, Feb 5, 2024 at 11:22 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Tim,
>
> On Mon, Feb 5, 2024 at 4:09 PM Tim Harvey <tharvey@gateworks.com> wrote:
> >
> > This series brings some recent upstream Linux dt updates into U-Boot for
> > the Gateworks Venice family.
>
> Please specify what "some recent upstream Linux dt" means.
>
> Is it 6.8-rc, linux-next, or Shawn's tree?
>
> Can't you instead sync the imx8mm-venice DTs in U-Boot with this kernel tree?
>
> > Tim Harvey (5):
> >   arm: dts: imx8mm-venice-gw7901: add digital I/O direction control GPIO's
> >   arm: dts: imx8mm-venice-gw7901: add TPM device
> >   arm: dts: imx8mm-venice-gw71xx: fix USB OTG VBUS
> >   arm: dts: imx8mm-venice-gw71xx: add TPM device
> >   arm: dts: imx8mp-venice-gw71xx: add TPM device
> >
> >  .../dts/imx8mm-venice-gw71xx-0x-u-boot.dtsi   |  7 ++++
> >  arch/arm/dts/imx8mm-venice-gw71xx.dtsi        | 40 +++++++++----------
> >  arch/arm/dts/imx8mm-venice-gw7901-u-boot.dtsi | 14 +++++++
>
> Why is u-boot.dtsi being touched? Please add a justification.
>
> >  arch/arm/dts/imx8mm-venice-gw7901.dts         | 14 ++++++-
> >  .../dts/imx8mp-venice-gw71xx-2x-u-boot.dtsi   |  9 +++++
>
> Same here.

Fabio,

Ok, makes sense - drop this series. I will send a single patch instead
with more detail if needed in the commit log.

Best regards,

Tim
Tom Rini Feb. 5, 2024, 9:10 p.m. UTC | #3
On Mon, Feb 05, 2024 at 12:19:47PM -0800, Tim Harvey wrote:
> On Mon, Feb 5, 2024 at 11:22 AM Fabio Estevam <festevam@gmail.com> wrote:
> >
> > Hi Tim,
> >
> > On Mon, Feb 5, 2024 at 4:09 PM Tim Harvey <tharvey@gateworks.com> wrote:
> > >
> > > This series brings some recent upstream Linux dt updates into U-Boot for
> > > the Gateworks Venice family.
> >
> > Please specify what "some recent upstream Linux dt" means.
> >
> > Is it 6.8-rc, linux-next, or Shawn's tree?
> >
> > Can't you instead sync the imx8mm-venice DTs in U-Boot with this kernel tree?
> >
> > > Tim Harvey (5):
> > >   arm: dts: imx8mm-venice-gw7901: add digital I/O direction control GPIO's
> > >   arm: dts: imx8mm-venice-gw7901: add TPM device
> > >   arm: dts: imx8mm-venice-gw71xx: fix USB OTG VBUS
> > >   arm: dts: imx8mm-venice-gw71xx: add TPM device
> > >   arm: dts: imx8mp-venice-gw71xx: add TPM device
> > >
> > >  .../dts/imx8mm-venice-gw71xx-0x-u-boot.dtsi   |  7 ++++
> > >  arch/arm/dts/imx8mm-venice-gw71xx.dtsi        | 40 +++++++++----------
> > >  arch/arm/dts/imx8mm-venice-gw7901-u-boot.dtsi | 14 +++++++
> >
> > Why is u-boot.dtsi being touched? Please add a justification.
> >
> > >  arch/arm/dts/imx8mm-venice-gw7901.dts         | 14 ++++++-
> > >  .../dts/imx8mp-venice-gw71xx-2x-u-boot.dtsi   |  9 +++++
> >
> > Same here.
> 
> Fabio,
> 
> Ok, makes sense - drop this series. I will send a single patch instead
> with more detail if needed in the commit log.

Can you please look at
https://patchwork.ozlabs.org/project/uboot/list/?series=393337&state=*
and work on top of that? I would like to pull that in to v2024.04,
still, and that will be a better long term path for your platforms as
well.  And if it looks like it would be a problem, getting that kind of
feedback now is also appreciated. Thanks!