| Message ID | 20240204122032.399496-1-foss@volatilesystems.org |
|---|---|
| State | Accepted |
| Delegated to: | Sander Vanheule |
| Headers | show |
| Series | realtek: fix zyxel-vers usage for XGS1250-12 | expand |
Hi Stijn, On Sun, 2024-02-04 at 13:20 +0100, Stijn Segers wrote: > Commit daefc646e6d fixed a shell expansion issue with > zyxel-vers usage. Commit 045baca10b1 took care of this checkpatch.pl was complaining about the format of these references, so I amended that. > for the rtl838x and rtl839x subtargets, but the single > device officially supported in rtl930x - the XGS1250-12 - > was overlooked. This commit updates the XGS1250-12 > build recipe as well. > > Signed-off-by: Stijn Segers <foss@volatilesystems.org> > --- > target/linux/realtek/image/rtl930x.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks! Merged on main and backported to 23.05. Best, Sander
Hi Sander, Op zondag 4 februari 2024 om 13:35:48 +01:00:00 schreef Sander Vanheule <sander@svanheule.net>: > Hi Stijn, > > On Sun, 2024-02-04 at 13:20 +0100, Stijn Segers wrote: >> Commit daefc646e6d fixed a shell expansion issue with >> zyxel-vers usage. Commit 045baca10b1 took care of this > > checkpatch.pl was complaining about the format of these references, > so I amended that. Sorry, I'll try to remember running that next time. > >> for the rtl838x and rtl839x subtargets, but the single >> device officially supported in rtl930x - the XGS1250-12 - >> was overlooked. This commit updates the XGS1250-12 >> build recipe as well. >> >> Signed-off-by: Stijn Segers <foss@volatilesystems.org> >> --- >> target/linux/realtek/image/rtl930x.mk | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Thanks! Merged on main and backported to 23.05. Thanks! > > Best, > Sander
diff --git a/target/linux/realtek/image/rtl930x.mk b/target/linux/realtek/image/rtl930x.mk index f55c5c002b..891a18c517 100644 --- a/target/linux/realtek/image/rtl930x.mk +++ b/target/linux/realtek/image/rtl930x.mk @@ -11,7 +11,7 @@ define Device/zyxel_xgs1250-12 kernel-bin | \ append-dtb | \ gzip | \ - zyxel-vers $$$$(ZYXEL_VERS) | \ + zyxel-vers | \ uImage gzip endef TARGET_DEVICES += zyxel_xgs1250-12
Commit daefc646e6d fixed a shell expansion issue with zyxel-vers usage. Commit 045baca10b1 took care of this for the rtl838x and rtl839x subtargets, but the single device officially supported in rtl930x - the XGS1250-12 - was overlooked. This commit updates the XGS1250-12 build recipe as well. Signed-off-by: Stijn Segers <foss@volatilesystems.org> --- target/linux/realtek/image/rtl930x.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)