Message ID | 20240201001000.1695803-1-numans@ovn.org |
---|---|
State | Accepted |
Headers | show |
Series | [ovs-dev,v2] tests: Fix flaky test 'SB Port binding incremental processing'. | expand |
Context | Check | Description |
---|---|---|
ovsrobot/apply-robot | success | apply and check: success |
ovsrobot/github-robot-_ovn-kubernetes | success | github build: passed |
ovsrobot/github-robot-_Build_and_Test | fail | github build: failed |
On Thu, Feb 1, 2024 at 1:10 AM <numans@ovn.org> wrote: > From: Numan Siddique <numans@ovn.org> > > Fixes: 121661678317 ("northd: Move router ports SB PB options sync to > sync_to_sb_pb node.") > > Signed-off-by: Numan Siddique <numans@ovn.org> > --- > > v1 -> v2 > ----- > * Fix the checkpatch errors. > > tests/ovn-northd.at | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at > index 67e81ddba3..fbd0d9ef18 100644 > --- a/tests/ovn-northd.at > +++ b/tests/ovn-northd.at > @@ -10404,6 +10404,8 @@ CHECK_NO_CHANGE_AFTER_RECOMPUTE > # Make lrp a gateway port > check as northd ovn-appctl -t ovn-northd inc-engine/clear-stats > check ovn-nbctl --wait=sb lrp-set-gateway-chassis lrp hv1 > +wait_column "hosting-chassis=hv1" nb:Logical_Router_Port status name=lrp > + > # There will be 3 recomputes of northd engine node > # 1. missing handler for input NB_logical_router > # 2. missing handler for input SB_ha_chassis_group > -- > 2.43.0 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > Looks good to me, thanks. Acked-by: Ales Musil <amusil@redhat.com>
On Fri, Feb 2, 2024 at 5:37 AM Ales Musil <amusil@redhat.com> wrote: > > On Thu, Feb 1, 2024 at 1:10 AM <numans@ovn.org> wrote: > > > From: Numan Siddique <numans@ovn.org> > > > > Fixes: 121661678317 ("northd: Move router ports SB PB options sync to > > sync_to_sb_pb node.") > > > > Signed-off-by: Numan Siddique <numans@ovn.org> > > --- > > > > v1 -> v2 > > ----- > > * Fix the checkpatch errors. > > > > tests/ovn-northd.at | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at > > index 67e81ddba3..fbd0d9ef18 100644 > > --- a/tests/ovn-northd.at > > +++ b/tests/ovn-northd.at > > @@ -10404,6 +10404,8 @@ CHECK_NO_CHANGE_AFTER_RECOMPUTE > > # Make lrp a gateway port > > check as northd ovn-appctl -t ovn-northd inc-engine/clear-stats > > check ovn-nbctl --wait=sb lrp-set-gateway-chassis lrp hv1 > > +wait_column "hosting-chassis=hv1" nb:Logical_Router_Port status name=lrp > > + > > # There will be 3 recomputes of northd engine node > > # 1. missing handler for input NB_logical_router > > # 2. missing handler for input SB_ha_chassis_group > > -- > > 2.43.0 > > > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > > > > Looks good to me, thanks. > > Acked-by: Ales Musil <amusil@redhat.com> Thanks. I applied to the main. Numan > > -- > > Ales Musil > > Senior Software Engineer - OVN Core > > Red Hat EMEA <https://www.redhat.com> > > amusil@redhat.com > <https://red.ht/sig> > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at index 67e81ddba3..fbd0d9ef18 100644 --- a/tests/ovn-northd.at +++ b/tests/ovn-northd.at @@ -10404,6 +10404,8 @@ CHECK_NO_CHANGE_AFTER_RECOMPUTE # Make lrp a gateway port check as northd ovn-appctl -t ovn-northd inc-engine/clear-stats check ovn-nbctl --wait=sb lrp-set-gateway-chassis lrp hv1 +wait_column "hosting-chassis=hv1" nb:Logical_Router_Port status name=lrp + # There will be 3 recomputes of northd engine node # 1. missing handler for input NB_logical_router # 2. missing handler for input SB_ha_chassis_group