mbox series

[0/1,SRU,M] black screen when wake up from s3 with AMD W7600 gfx

Message ID 20240126102225.151471-1-acelan.kao@canonical.com
Headers show
Series black screen when wake up from s3 with AMD W7600 gfx | expand

Message

AceLan Kao Jan. 26, 2024, 10:22 a.m. UTC
From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>

BugLink: https://bugs.launchpad.net/bugs/2051341

[Impact]
The display is blank when resumed from s3 with AMD W7600 DGFx and Dell E2422H monitor

[Fix]
Mario points out the commit in 6.7 may help
3b401e30c249 drm/ttm: Reorder sys manager cleanup step

[Test]
1. Build W7600 dGFx + Monitor: E2422H Config and FIDA Ubunutu22.04 OS.
2. Boot OS, put SUT to suspend.
3. Wake up the System from suspend.
4. Right away reboot the system from Ubuntu OS.
5. Put SUT to suspend and wake up the system.
6. After wake up Suspend, SUT should not be black screen.
7. Repetition Step 2~6 30 cycles

[Where problems could occur]
Handling the system memory manager after the workqueue is destroyed prevents
from the pointer beeing used after free. Should be pretty safe to include it.

Karolina Stolarek (1):
  drm/ttm: Reorder sys manager cleanup step

 drivers/gpu/drm/ttm/ttm_device.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Thibault Ferrante Jan. 26, 2024, 2:29 p.m. UTC | #1
On 26-01-2024 11:22, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/2051341
> 
> [Impact]
> The display is blank when resumed from s3 with AMD W7600 DGFx and Dell E2422H monitor
> 
> [Fix]
> Mario points out the commit in 6.7 may help
> 3b401e30c249 drm/ttm: Reorder sys manager cleanup step
> 
> [Test]
> 1. Build W7600 dGFx + Monitor: E2422H Config and FIDA Ubunutu22.04 OS.
> 2. Boot OS, put SUT to suspend.
> 3. Wake up the System from suspend.
> 4. Right away reboot the system from Ubuntu OS.
> 5. Put SUT to suspend and wake up the system.
> 6. After wake up Suspend, SUT should not be black screen.
> 7. Repetition Step 2~6 30 cycles
> 
> [Where problems could occur]
> Handling the system memory manager after the workqueue is destroyed prevents
> from the pointer beeing used after free. Should be pretty safe to include it.
> 
> Karolina Stolarek (1):
>    drm/ttm: Reorder sys manager cleanup step
> 
>   drivers/gpu/drm/ttm/ttm_device.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 

Acked-by: Thibault Ferrante <thibault.ferrante@canonical.com>

--
Thibault
Tim Gardner Jan. 26, 2024, 4:54 p.m. UTC | #2
On 1/26/24 3:22 AM, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/2051341
> 
> [Impact]
> The display is blank when resumed from s3 with AMD W7600 DGFx and Dell E2422H monitor
> 
> [Fix]
> Mario points out the commit in 6.7 may help
> 3b401e30c249 drm/ttm: Reorder sys manager cleanup step
> 
> [Test]
> 1. Build W7600 dGFx + Monitor: E2422H Config and FIDA Ubunutu22.04 OS.
> 2. Boot OS, put SUT to suspend.
> 3. Wake up the System from suspend.
> 4. Right away reboot the system from Ubuntu OS.
> 5. Put SUT to suspend and wake up the system.
> 6. After wake up Suspend, SUT should not be black screen.
> 7. Repetition Step 2~6 30 cycles
> 
> [Where problems could occur]
> Handling the system memory manager after the workqueue is destroyed prevents
> from the pointer beeing used after free. Should be pretty safe to include it.
> 
> Karolina Stolarek (1):
>    drm/ttm: Reorder sys manager cleanup step
> 
>   drivers/gpu/drm/ttm/ttm_device.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Stefan Bader Jan. 31, 2024, 10:40 a.m. UTC | #3
On 26.01.24 11:22, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/2051341
> 
> [Impact]
> The display is blank when resumed from s3 with AMD W7600 DGFx and Dell E2422H monitor
> 
> [Fix]
> Mario points out the commit in 6.7 may help
> 3b401e30c249 drm/ttm: Reorder sys manager cleanup step
> 
> [Test]
> 1. Build W7600 dGFx + Monitor: E2422H Config and FIDA Ubunutu22.04 OS.
> 2. Boot OS, put SUT to suspend.
> 3. Wake up the System from suspend.
> 4. Right away reboot the system from Ubuntu OS.
> 5. Put SUT to suspend and wake up the system.
> 6. After wake up Suspend, SUT should not be black screen.
> 7. Repetition Step 2~6 30 cycles
> 
> [Where problems could occur]
> Handling the system memory manager after the workqueue is destroyed prevents
> from the pointer beeing used after free. Should be pretty safe to include it.
> 
> Karolina Stolarek (1):
>    drm/ttm: Reorder sys manager cleanup step
> 
>   drivers/gpu/drm/ttm/ttm_device.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 

This fix was already pending on Mantic via upstream stable 6.5.11. I 
only adjusted the commit message to include the additional bug reference.