mbox series

[ovs-dev,v4,0/8] python: Miscelaneous flow parsing fixes.

Message ID 20240117111902.1607239-1-amorenoz@redhat.com
Headers show
Series python: Miscelaneous flow parsing fixes. | expand

Message

Adrián Moreno Jan. 17, 2024, 11:18 a.m. UTC 
This series contains some miscelaneous fixes in the flow parsing
library.

V4:
 - Rebased and added a test to verify the length of the kv_lists
V3:
 - Fixed pytests and added more tests for each fix.
V2:
 - Rebased and dropped first patch.

Adrian Moreno (8):
  python: ovs: flow: Fix typo in n_packets.
  python: tests: Add info and key tests for OFPFlows.
  python: ovs: flow: Add sample to nested actions.
  python: ovs: flow: Add dp hash and meter actions.
  python: tests: Refactor test_odp section testing.
  python: ovs: flow: Add idle_age to openflow flows.
  python: ovs: flow: Make check_pkt_len action a list.
  python: ovs: flow: Add meter_id to controller.

 python/ovs/flow/odp.py       |  44 +++++++++------
 python/ovs/flow/ofp.py       |   3 +-
 python/ovs/flow/ofp_act.py   |   1 +
 python/ovs/tests/test_odp.py |  92 +++++++++++++++---------------
 python/ovs/tests/test_ofp.py | 105 +++++++++++++++++++++++++++++------
 5 files changed, 164 insertions(+), 81 deletions(-)

Comments

Simon Horman Jan. 17, 2024, 7:33 p.m. UTC | #1 
On Wed, Jan 17, 2024 at 12:18:49PM +0100, Adrian Moreno wrote:
> This series contains some miscelaneous fixes in the flow parsing
> library.
> 
> V4:
>  - Rebased and added a test to verify the length of the kv_lists
> V3:
>  - Fixed pytests and added more tests for each fix.
> V2:
>  - Rebased and dropped first patch.
> 
> Adrian Moreno (8):
>   python: ovs: flow: Fix typo in n_packets.
>   python: tests: Add info and key tests for OFPFlows.
>   python: ovs: flow: Add sample to nested actions.
>   python: ovs: flow: Add dp hash and meter actions.
>   python: tests: Refactor test_odp section testing.
>   python: ovs: flow: Add idle_age to openflow flows.
>   python: ovs: flow: Make check_pkt_len action a list.
>   python: ovs: flow: Add meter_id to controller.

Thanks Adrian,

applied as:
- python: ovs: flow: Add meter_id to controller.
  https://github.com/openvswitch/ovs/commit/253d90075874
- python: ovs: flow: Make check_pkt_len action a list.
  https://github.com/openvswitch/ovs/commit/ea44cafae235
- python: ovs: flow: Add idle_age to openflow flows.
  https://github.com/openvswitch/ovs/commit/32f6737b5cb1
- python: tests: Refactor test_odp section testing.
  https://github.com/openvswitch/ovs/commit/e72b7b6f174f
- python: ovs: flow: Add dp hash and meter actions.
  https://github.com/openvswitch/ovs/commit/5e45091ea888
- python: ovs: flow: Add sample to nested actions.
  https://github.com/openvswitch/ovs/commit/ab7d089612cd
- python: tests: Add info and key tests for OFPFlows.
  https://github.com/openvswitch/ovs/commit/9ef49ca85b9b
- python: ovs: flow: Fix typo in n_packets.
  https://github.com/openvswitch/ovs/commit/6bbbb766424d

As a follow-up I plan to backport this series as appropriate.
Adrián Moreno Jan. 18, 2024, 7:21 a.m. UTC | #2 
On 1/17/24 20:33, Simon Horman wrote:
> On Wed, Jan 17, 2024 at 12:18:49PM +0100, Adrian Moreno wrote:
>> This series contains some miscelaneous fixes in the flow parsing
>> library.
>>
>> V4:
>>   - Rebased and added a test to verify the length of the kv_lists
>> V3:
>>   - Fixed pytests and added more tests for each fix.
>> V2:
>>   - Rebased and dropped first patch.
>>
>> Adrian Moreno (8):
>>    python: ovs: flow: Fix typo in n_packets.
>>    python: tests: Add info and key tests for OFPFlows.
>>    python: ovs: flow: Add sample to nested actions.
>>    python: ovs: flow: Add dp hash and meter actions.
>>    python: tests: Refactor test_odp section testing.
>>    python: ovs: flow: Add idle_age to openflow flows.
>>    python: ovs: flow: Make check_pkt_len action a list.
>>    python: ovs: flow: Add meter_id to controller.
> 
> Thanks Adrian,
> 
> applied as:
> - python: ovs: flow: Add meter_id to controller.
>    https://github.com/openvswitch/ovs/commit/253d90075874
> - python: ovs: flow: Make check_pkt_len action a list.
>    https://github.com/openvswitch/ovs/commit/ea44cafae235
> - python: ovs: flow: Add idle_age to openflow flows.
>    https://github.com/openvswitch/ovs/commit/32f6737b5cb1
> - python: tests: Refactor test_odp section testing.
>    https://github.com/openvswitch/ovs/commit/e72b7b6f174f
> - python: ovs: flow: Add dp hash and meter actions.
>    https://github.com/openvswitch/ovs/commit/5e45091ea888
> - python: ovs: flow: Add sample to nested actions.
>    https://github.com/openvswitch/ovs/commit/ab7d089612cd
> - python: tests: Add info and key tests for OFPFlows.
>    https://github.com/openvswitch/ovs/commit/9ef49ca85b9b
> - python: ovs: flow: Fix typo in n_packets.
>    https://github.com/openvswitch/ovs/commit/6bbbb766424d
> 
> As a follow-up I plan to backport this series as appropriate.
> 

Thanks!
Simon Horman Jan. 19, 2024, 5:36 p.m. UTC | #3 
On Wed, Jan 17, 2024 at 07:33:40PM +0000, Simon Horman wrote:
> On Wed, Jan 17, 2024 at 12:18:49PM +0100, Adrian Moreno wrote:
> > This series contains some miscelaneous fixes in the flow parsing
> > library.
> > 
> > V4:
> >  - Rebased and added a test to verify the length of the kv_lists
> > V3:
> >  - Fixed pytests and added more tests for each fix.
> > V2:
> >  - Rebased and dropped first patch.
> > 
> > Adrian Moreno (8):
> >   python: ovs: flow: Fix typo in n_packets.
> >   python: tests: Add info and key tests for OFPFlows.
> >   python: ovs: flow: Add sample to nested actions.
> >   python: ovs: flow: Add dp hash and meter actions.
> >   python: tests: Refactor test_odp section testing.
> >   python: ovs: flow: Add idle_age to openflow flows.
> >   python: ovs: flow: Make check_pkt_len action a list.
> >   python: ovs: flow: Add meter_id to controller.
> 
> Thanks Adrian,
> 
> applied as:
> - python: ovs: flow: Add meter_id to controller.
>   https://github.com/openvswitch/ovs/commit/253d90075874
> - python: ovs: flow: Make check_pkt_len action a list.
>   https://github.com/openvswitch/ovs/commit/ea44cafae235
> - python: ovs: flow: Add idle_age to openflow flows.
>   https://github.com/openvswitch/ovs/commit/32f6737b5cb1
> - python: tests: Refactor test_odp section testing.
>   https://github.com/openvswitch/ovs/commit/e72b7b6f174f
> - python: ovs: flow: Add dp hash and meter actions.
>   https://github.com/openvswitch/ovs/commit/5e45091ea888
> - python: ovs: flow: Add sample to nested actions.
>   https://github.com/openvswitch/ovs/commit/ab7d089612cd
> - python: tests: Add info and key tests for OFPFlows.
>   https://github.com/openvswitch/ovs/commit/9ef49ca85b9b
> - python: ovs: flow: Fix typo in n_packets.
>   https://github.com/openvswitch/ovs/commit/6bbbb766424d
> 
> As a follow-up I plan to backport this series as appropriate.

Backport to branch-3.2:
- python: ovs: flow: Add meter_id to controller.
  https://github.com/openvswitch/ovs/commit/f6757eb214f5
- python: ovs: flow: Make check_pkt_len action a list.
  https://github.com/openvswitch/ovs/commit/dae1ffc17b49
- python: ovs: flow: Add idle_age to openflow flows.
  https://github.com/openvswitch/ovs/commit/699d26d425ac
- python: tests: Refactor test_odp section testing.
  https://github.com/openvswitch/ovs/commit/5bef199078e9
- python: ovs: flow: Add dp hash and meter actions.
  https://github.com/openvswitch/ovs/commit/e3f2eca15ddf
- python: ovs: flow: Add sample to nested actions.
  https://github.com/openvswitch/ovs/commit/1072d0d22146
- python: tests: Add info and key tests for OFPFlows.
  https://github.com/openvswitch/ovs/commit/065bdb3e15e0
- python: ovs: flow: Fix typo in n_packets.
  https://github.com/openvswitch/ovs/commit/4374b1e64eb7

Backport to branch-3.1:
- python: ovs: flow: Add meter_id to controller.
  https://github.com/openvswitch/ovs/commit/7bb4f13a3757
- python: ovs: flow: Make check_pkt_len action a list.
  https://github.com/openvswitch/ovs/commit/41b2ae516552
- python: ovs: flow: Add idle_age to openflow flows.
  https://github.com/openvswitch/ovs/commit/d0fc8a289281
- python: tests: Refactor test_odp section testing.
  https://github.com/openvswitch/ovs/commit/3e2791f8c6f2
- python: ovs: flow: Add dp hash and meter actions.
  https://github.com/openvswitch/ovs/commit/df59f9a225ce
- python: ovs: flow: Add sample to nested actions.
  https://github.com/openvswitch/ovs/commit/7958e50a1e8c
- python: tests: Add info and key tests for OFPFlows.
  https://github.com/openvswitch/ovs/commit/fc0fb041afd2
- python: ovs: flow: Fix typo in n_packets.
  https://github.com/openvswitch/ovs/commit/1d00d1da6f09

Backport to branch-3.0 with dependencies:
- python: ovs: flow: Add meter_id to controller.
  https://github.com/openvswitch/ovs/commit/53b2c486c87b
- python: ovs: flow: Make check_pkt_len action a list.
  https://github.com/openvswitch/ovs/commit/1eb9d67f9466
- python: ovs: flow: Add idle_age to openflow flows.
  https://github.com/openvswitch/ovs/commit/3cdd6943a0f0
- python: tests: Refactor test_odp section testing.
  https://github.com/openvswitch/ovs/commit/48e9e68cf71c
- python: ovs: flow: Add dp hash and meter actions.
  https://github.com/openvswitch/ovs/commit/e1990bab95cc
- python: ovs: flow: Add sample to nested actions.
  https://github.com/openvswitch/ovs/commit/7e46b2fb1011
- python: tests: Add info and key tests for OFPFlows.
  https://github.com/openvswitch/ovs/commit/53a346e62338
- python: ovs: flow: Fix typo in n_packets.
  https://github.com/openvswitch/ovs/commit/3539ceb46987
- python: Support case-insensitive OpenFlow actions.
  https://github.com/openvswitch/ovs/commit/c1253ba877a2
- python: Return list of actions for odp action clone.
  https://github.com/openvswitch/ovs/commit/063d784d7923
- python: Make key-value matching strict by default.
  https://github.com/openvswitch/ovs/commit/120f3dc4113a
- python: Add explicit decoders for all ofp actions.
  https://github.com/openvswitch/ovs/commit/4db644f26f8c
- python: Include aliases in ofp_fields.py.
  https://github.com/openvswitch/ovs/commit/7572cb65491f

No backport to branch-2.17, this series does not seem to be applicable there.