diff mbox series

[v2,1/3] dt-bindings: extcon: ptn5150: Describe the USB connector

Message ID 20231212174847.759164-1-festevam@gmail.com
State Not Applicable, archived
Headers show
Series [v2,1/3] dt-bindings: extcon: ptn5150: Describe the USB connector | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Fabio Estevam Dec. 12, 2023, 5:48 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

PTN5150 supports USB Type-C connector, so improve the bindings by
allowing to describe the connector like it is done on nxp,ptn5110.yaml.

Signed-off-by: Fabio Estevam <festevam@denx.de>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
---
Changes since v1:
- Removed type and unevaluatedProperties: false (Conor).

 Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml | 3 +++
 1 file changed, 3 insertions(+)

Comments

Shawn Guo Dec. 14, 2023, 3:07 a.m. UTC | #1 
On Tue, Dec 12, 2023 at 02:48:46PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Describe the PTN5150 USB-C connector to improve the devicetree description
> and fix the following dt-schema warning:
> 
> imx8mn-var-som-symphony.dtb: typec@3d: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/extcon/extcon-ptn5150.yaml#
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!
Shawn Guo Dec. 14, 2023, 3:07 a.m. UTC | #2 
On Tue, Dec 12, 2023 at 02:48:47PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Describe the PTN5150 USB-C connector to improve the devicetree description
> and fix the following dt-schema warning:
> 
> imx8mp-dhcom-pdk3.dtb: typec@3d: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/extcon/extcon-ptn5150.yaml#
> 	
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!
Marek Vasut Jan. 13, 2024, 9:30 p.m. UTC | #3 
On 12/14/23 04:07, Shawn Guo wrote:
> On Tue, Dec 12, 2023 at 02:48:47PM -0300, Fabio Estevam wrote:
>> From: Fabio Estevam <festevam@denx.de>
>>
>> Describe the PTN5150 USB-C connector to improve the devicetree description
>> and fix the following dt-schema warning:
>>
>> imx8mp-dhcom-pdk3.dtb: typec@3d: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
>> 	from schema $id: http://devicetree.org/schemas/extcon/extcon-ptn5150.yaml#
>> 	
>> Signed-off-by: Fabio Estevam <festevam@denx.de>
> 
> Applied, thanks!

This patch breaks USB-C port on this board.

If I plug in USB-C storage device, it is not detected. If I revert this 
patch, it is detected.

Please drop this patch for now.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml b/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml
index d5cfa32ea52d..b3e5c0df0cd7 100644
--- a/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml
+++ b/Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml
@@ -37,6 +37,9 @@  properties:
       GPIO pin (output) used to control VBUS. If skipped, no such control
       takes place.
 
+  connector:
+    $ref: /schemas/connector/usb-connector.yaml#
+
 required:
   - compatible
   - interrupts