| Message ID | 20231201145551.23337-1-francesco@dolcini.it |
|---|---|
| Headers | show |
| Series | arm64: dts: ti: add verdin am62 mallow board | expand |
On 15:55-20231201, Francesco Dolcini wrote: > From: Joao Paulo Goncalves <joao.goncalves@toradex.com> [...] > + > + tpm@1 { > + compatible = "infineon,slb9670", "tcg,tpm_tis-spi"; arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-mallow.dtb: /bus@f0000/spi@20110000/tpm@1: failed to match any schema with compatible: ['infineon,slb9670', 'tcg,tpm_tis-spi'] arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-mallow.dtb: /bus@f0000/spi@20110000/tpm@1: failed to match any schema with compatible: ['infineon,slb9670', 'tcg,tpm_tis-spi'] We should either drop this node OR introduce bindings and later introduce this series. Yes, I know there are other places where the compatible is already used arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts etc.. But, unfortunately, I'd rather see the binding Documentation/devicetree/bindings/security/tpm/tpm_tis_spi.txt transition over to yaml prior to picking things up. (NOTE: the same rules apply to TI devs as well..) > + reg = <1>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_qspi1_dqs_gpio>; > + interrupt-parent = <&main_gpio1>; > + interrupts = <18 IRQ_TYPE_EDGE_FALLING>; > + spi-max-frequency = <18500000>; [...]
Hello Nishanth, On Mon, Dec 04, 2023 at 12:13:36PM -0600, Nishanth Menon wrote: > On 15:55-20231201, Francesco Dolcini wrote: > > From: Joao Paulo Goncalves <joao.goncalves@toradex.com> > > [...] > > > + > > + tpm@1 { > > + compatible = "infineon,slb9670", "tcg,tpm_tis-spi"; > > arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-mallow.dtb: /bus@f0000/spi@20110000/tpm@1: failed to match any schema with compatible: ['infineon,slb9670', 'tcg,tpm_tis-spi'] > arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-mallow.dtb: /bus@f0000/spi@20110000/tpm@1: failed to match any schema with compatible: ['infineon,slb9670', 'tcg,tpm_tis-spi'] > > We should either drop this node OR introduce bindings and later > introduce this series. > > Yes, I know there are other places where the compatible is already used > arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts > arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts1G > etc.. But, unfortunately, I'd rather see the binding > Documentation/devicetree/bindings/security/tpm/tpm_tis_spi.txt > transition over to yaml prior to picking things up. (NOTE: the same > rules apply to TI devs as well..) I disagree (and I also know that in the end is your call to take patches or not and I will just accept your decision whatever it is). What you are asking here is to not use any binding that was not already converted from txt to yaml, I do not think it is fair to force this decision just for TI DT files. I'd like also to add that a conversion to yaml of this binding is in the work [1] and this DT is compliant with it. What's DT maintainers opinion on this matter? Rob recently provided feedback on TPM bindings txt to yaml conversion so it should be fresh on his mind. Francesco [1] https://lore.kernel.org/all/cover.1701093036.git.lukas@wunner.de/
On Mon, Dec 04, 2023 at 12:13:36PM -0600, Nishanth Menon wrote: > On 15:55-20231201, Francesco Dolcini wrote: > > From: Joao Paulo Goncalves <joao.goncalves@toradex.com> > > + > > + tpm@1 { > > + compatible = "infineon,slb9670", "tcg,tpm_tis-spi"; > > arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-mallow.dtb: /bus@f0000/spi@20110000/tpm@1: failed to match any schema with compatible: ['infineon,slb9670', 'tcg,tpm_tis-spi'] > arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-mallow.dtb: /bus@f0000/spi@20110000/tpm@1: failed to match any schema with compatible: ['infineon,slb9670', 'tcg,tpm_tis-spi'] > > We should either drop this node OR introduce bindings and later > introduce this series. > > Yes, I know there are other places where the compatible is already used > arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts > arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts > etc.. But, unfortunately, I'd rather see the binding > Documentation/devicetree/bindings/security/tpm/tpm_tis_spi.txt > transition over to yaml prior to picking things up. Thy will be done: https://git.kernel.org/linus/26c9d152ebf3 The TPM bindings are now converted to YAML, so the change rejected above can be resubmitted. Thanks, Lukas
On Sat, Jan 13, 2024 at 10:20:25AM +0100, Lukas Wunner wrote: > On Mon, Dec 04, 2023 at 12:13:36PM -0600, Nishanth Menon wrote: > > On 15:55-20231201, Francesco Dolcini wrote: > > > From: Joao Paulo Goncalves <joao.goncalves@toradex.com> > > > + > > > + tpm@1 { > > > + compatible = "infineon,slb9670", "tcg,tpm_tis-spi"; > > > > arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-mallow.dtb: /bus@f0000/spi@20110000/tpm@1: failed to match any schema with compatible: ['infineon,slb9670', 'tcg,tpm_tis-spi'] > > arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-mallow.dtb: /bus@f0000/spi@20110000/tpm@1: failed to match any schema with compatible: ['infineon,slb9670', 'tcg,tpm_tis-spi'] > > > > We should either drop this node OR introduce bindings and later > > introduce this series. > > > > Yes, I know there are other places where the compatible is already used > > arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts > > arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts > > etc.. But, unfortunately, I'd rather see the binding > > Documentation/devicetree/bindings/security/tpm/tpm_tis_spi.txt > > transition over to yaml prior to picking things up. > > Thy will be done: > > https://git.kernel.org/linus/26c9d152ebf3 > > The TPM bindings are now converted to YAML, so the change rejected above > can be resubmitted. Thanks Lukas, it's ready to be sent, just waiting for rc1 to be out. Francesco
From: Francesco Dolcini <francesco.dolcini@toradex.com> Add Toradex Verdin AM62 Mallow carrier board support. Mallow is a low-cost carrier board in the Verdin family with a small form factor and build for volume production making it ideal for industrial and embedded applications. https://www.toradex.com/products/carrier-board/mallow-carrier-board v1: - https://lore.kernel.org/all/20231123112826.16549-1-francesco@dolcini.it/ v2: - fixed temperature sensor compatible (s/tmp75c/tmp1075) - add Acked-by: Krzysztof Joao Paulo Goncalves (3): arm64: dts: ti: verdin-am62: improve spi1 chip-select pinctrl dt-bindings: arm: ti: add verdin am62 mallow board arm64: dts: ti: add verdin am62 mallow board .../devicetree/bindings/arm/ti/k3.yaml | 2 + arch/arm64/boot/dts/ti/Makefile | 2 + .../boot/dts/ti/k3-am62-verdin-mallow.dtsi | 198 ++++++++++++++++++ arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi | 17 +- .../dts/ti/k3-am625-verdin-nonwifi-mallow.dts | 22 ++ .../dts/ti/k3-am625-verdin-wifi-mallow.dts | 22 ++ 6 files changed, 261 insertions(+), 2 deletions(-) create mode 100644 arch/arm64/boot/dts/ti/k3-am62-verdin-mallow.dtsi create mode 100644 arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-mallow.dts create mode 100644 arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-mallow.dts