Message ID | 20240105071913.593978-1-cederman@gaisler.com |
---|---|
State | New |
Headers | show |
> pr88077 fails on SPARC since char HeaderStr[1] in pr88077_1.c and > long HeaderStr in pr88077_0.c differs in alignment. > > warning: alignment 4 of normal symbol `HeaderStr' in c_lto_pr88077_0.o is > smaller than 8 used by the common definition in c_lto_pr88077_1.o I have never seen it though. Is that really a warning issued by GCC?
On 2024-01-08 10:20, Eric Botcazou wrote: >> pr88077 fails on SPARC since char HeaderStr[1] in pr88077_1.c and >> long HeaderStr in pr88077_0.c differs in alignment. >> >> warning: alignment 4 of normal symbol `HeaderStr' in c_lto_pr88077_0.o is >> smaller than 8 used by the common definition in c_lto_pr88077_1.o > > I have never seen it though. Is that really a warning issued by GCC? > Hello Eric! Thank you for reviewing the patches! No, this warning is not from GCC, it is from binutils ld. I forgot to mention that in the message. I get a similar warning from older versions of ld, so I do not think it is a new warning. It is also there with GCC 10. For the OK:ed patches (with your changes), can I push them to release/gcc-13 in addition to master? /Daniel
> Hello Eric! Thank you for reviewing the patches! You're welcome. > No, this warning is not from GCC, it is from binutils ld. I forgot to > mention that in the message. I get a similar warning from older versions > of ld, so I do not think it is a new warning. It is also there with GCC 10. I see, thanks for the explanation, the patch is OK then. > For the OK:ed patches (with your changes), can I push them to > release/gcc-13 in addition to master? Sure.
diff --git a/gcc/testsuite/gcc.dg/lto/pr88077_0.c b/gcc/testsuite/gcc.dg/lto/pr88077_0.c index 924fe9fc3f01..9455295051fc 100644 --- a/gcc/testsuite/gcc.dg/lto/pr88077_0.c +++ b/gcc/testsuite/gcc.dg/lto/pr88077_0.c @@ -1,3 +1,7 @@ /* { dg-lto-do link } */ +#if defined __sparc__ +long long HeaderStr; +#else long HeaderStr; +#endif