mbox series

[v4,0/3] Add imx93-var-som support

Message ID 20240104091350.18252-1-othacehe@gnu.org
Headers show
Series Add imx93-var-som support | expand

Message

Mathieu Othacehe Jan. 4, 2024, 9:13 a.m. UTC
From: Mathieu Othacehe <m.othacehe@gmail.com>

Hello,

This v4 rebases the series on top of the next branch and fixes Fabio's
remarks.

Thanks,

Mathieu

v3: https://lists.denx.de/pipermail/u-boot/2023-December/542111.html

Mathieu Othacehe (3):
  spl: binman: Disable u_boot_any symbols for i.MX93 boards
  mach-imx: Add i.MX93 binman support.
  Add imx93-var-som support

 arch/arm/dts/Makefile                         |    3 +-
 arch/arm/dts/imx93-u-boot.dtsi                |   88 +
 .../dts/imx93-var-som-symphony-u-boot.dtsi    |  266 +++
 arch/arm/dts/imx93-var-som-symphony.dts       |  305 ++++
 arch/arm/dts/imx93-var-som.dtsi               |  111 ++
 arch/arm/include/asm/arch-imx9/clock.h        |    1 +
 arch/arm/mach-imx/Makefile                    |   22 +-
 arch/arm/mach-imx/imx9/Kconfig                |    7 +
 board/variscite/common/eth.c                  |   58 +
 board/variscite/common/eth.h                  |   12 +
 board/variscite/common/imx9_eeprom.c          |  190 +++
 board/variscite/common/imx9_eeprom.h          |   83 +
 board/variscite/common/mmc.c                  |   47 +
 board/variscite/imx93_var_som/Kconfig         |   12 +
 board/variscite/imx93_var_som/MAINTAINERS     |    7 +
 board/variscite/imx93_var_som/Makefile        |   17 +
 board/variscite/imx93_var_som/container.cfg   |   10 +
 board/variscite/imx93_var_som/imx93_var_som.c |  126 ++
 .../variscite/imx93_var_som/imx93_var_som.env |   99 ++
 board/variscite/imx93_var_som/imximage.cfg    |   10 +
 .../variscite/imx93_var_som/lpddr4x_timing.c  | 1488 +++++++++++++++++
 board/variscite/imx93_var_som/spl.c           |  143 ++
 common/spl/Kconfig                            |    2 +-
 common/spl/Kconfig.tpl                        |    2 +-
 common/spl/Kconfig.vpl                        |    2 +-
 configs/imx93_var_som_defconfig               |  156 ++
 doc/board/variscite/imx93_var_som.rst         |   68 +
 doc/board/variscite/index.rst                 |    1 +
 include/configs/imx93_var_som.h               |   48 +
 29 files changed, 3379 insertions(+), 5 deletions(-)
 create mode 100644 arch/arm/dts/imx93-u-boot.dtsi
 create mode 100644 arch/arm/dts/imx93-var-som-symphony-u-boot.dtsi
 create mode 100644 arch/arm/dts/imx93-var-som-symphony.dts
 create mode 100644 arch/arm/dts/imx93-var-som.dtsi
 create mode 100644 board/variscite/common/eth.c
 create mode 100644 board/variscite/common/eth.h
 create mode 100644 board/variscite/common/imx9_eeprom.c
 create mode 100644 board/variscite/common/imx9_eeprom.h
 create mode 100644 board/variscite/common/mmc.c
 create mode 100644 board/variscite/imx93_var_som/Kconfig
 create mode 100644 board/variscite/imx93_var_som/MAINTAINERS
 create mode 100644 board/variscite/imx93_var_som/Makefile
 create mode 100644 board/variscite/imx93_var_som/container.cfg
 create mode 100644 board/variscite/imx93_var_som/imx93_var_som.c
 create mode 100644 board/variscite/imx93_var_som/imx93_var_som.env
 create mode 100644 board/variscite/imx93_var_som/imximage.cfg
 create mode 100644 board/variscite/imx93_var_som/lpddr4x_timing.c
 create mode 100644 board/variscite/imx93_var_som/spl.c
 create mode 100644 configs/imx93_var_som_defconfig
 create mode 100644 doc/board/variscite/imx93_var_som.rst
 create mode 100644 include/configs/imx93_var_som.h

Comments

Fabio Estevam Jan. 4, 2024, 2:29 p.m. UTC | #1
Hi Mathieu,

On Thu, Jan 4, 2024 at 6:14 AM Mathieu Othacehe <othacehe@gnu.org> wrote:
>
> From: Mathieu Othacehe <m.othacehe@gmail.com>
>
> Hello,
>
> This v4 rebases the series on top of the next branch and fixes Fabio's
> remarks.

I ran your v4 series through CI, but it failed:

https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/764727

Take a look at the xilinx_zynqmp_virt and imx8mm-cl-iot-gate errors,
for example.

Thanks
Mathieu Othacehe Jan. 4, 2024, 3:53 p.m. UTC | #2
Hello,

> https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/764727
>
> Take a look at the xilinx_zynqmp_virt and imx8mm-cl-iot-gate errors,
> for example.

Due to multi-threaded testing the output is a bit hard to read but I
think that those configs are working fine.

The faulty config seems to be imx93_11x11_[ld]_evk and I can reproduce
the issue locally.

The problem is the following line in mach-imx Makefile:

--8<---------------cut here---------------start------------->8---
u-boot-container.cfgout: $(IMX_CONTAINER_CFG) FORCE
	$(Q)mkdir -p $(dir $@)
--8<---------------cut here---------------end--------------->8---

We are expecting CONFIG_IMX_CONTAINER_CFG to be set for all the IMX9
boards which is not the case for the existing IMX9 boards:
imx93_11x11_[ld]_evk.

In v5, I propose to fix that by adding binman support for the
imx93_11x11_[ld]_evk boards. I cannot test that but I expect those
boards to behave the same way as the imx93_var_som.

Thanks,

Mathieu