diff mbox series

[2/5] smbios: type2: contained object handles

Message ID 20231223004429.247301-3-xypron.glpk@gmx.de
State Changes Requested
Delegated to: Tom Rini
Headers show
Series cmd: provide command to display SMBIOS information | expand

Commit Message

Heinrich Schuchardt Dec. 23, 2023, 12:44 a.m. UTC 
The type 2 structure must include information about the contained objects.
It is fine to set the number of contained object handles to 0.

Add the missing field.

Fixes: 721e992a8af5 ("x86: Add SMBIOS table support")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 include/smbios.h | 1 +
 1 file changed, 1 insertion(+)

--
2.43.0

Comments

Simon Glass Dec. 26, 2023, 9:50 a.m. UTC | #1 
Hi Heinrich,

On Sat, Dec 23, 2023 at 12:49 AM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> The type 2 structure must include information about the contained objects.
> It is fine to set the number of contained object handles to 0.
>
> Add the missing field.
>
> Fixes: 721e992a8af5 ("x86: Add SMBIOS table support")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  include/smbios.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/smbios.h b/include/smbios.h
> index e601283d29..88c19ae062 100644
> --- a/include/smbios.h
> +++ b/include/smbios.h
> @@ -139,6 +139,7 @@ struct __packed smbios_type2 {
>         u8 chassis_location;
>         u16 chassis_handle;
>         u8 board_type;
> +       u8 number_contained_objects;
>         char eos[SMBIOS_STRUCT_EOS_BYTES];
>  };
>
> --
> 2.43.0

I thought I already saw this patch elsewhere, but this one is not a v2?

Regards,
Simon
Heinrich Schuchardt Dec. 26, 2023, 9:53 a.m. UTC | #2 
On 12/26/23 10:50, Simon Glass wrote:
> Hi Heinrich,
>
> On Sat, Dec 23, 2023 at 12:49 AM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>>
>> The type 2 structure must include information about the contained objects.
>> It is fine to set the number of contained object handles to 0.
>>
>> Add the missing field.
>>
>> Fixes: 721e992a8af5 ("x86: Add SMBIOS table support")
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>> ---
>>   include/smbios.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/include/smbios.h b/include/smbios.h
>> index e601283d29..88c19ae062 100644
>> --- a/include/smbios.h
>> +++ b/include/smbios.h
>> @@ -139,6 +139,7 @@ struct __packed smbios_type2 {
>>          u8 chassis_location;
>>          u16 chassis_handle;
>>          u8 board_type;
>> +       u8 number_contained_objects;
>>          char eos[SMBIOS_STRUCT_EOS_BYTES];
>>   };
>>
>> --
>> 2.43.0
>
> I thought I already saw this patch elsewhere, but this one is not a v2?

I should have marked it as re-sent.

Best regards

Heinrich
Ilias Apalodimas Dec. 27, 2023, 2:14 p.m. UTC | #3 
On Sat, Dec 23, 2023 at 01:44:26AM +0100, Heinrich Schuchardt wrote:
> The type 2 structure must include information about the contained objects.
> It is fine to set the number of contained object handles to 0.
>
> Add the missing field.
>
> Fixes: 721e992a8af5 ("x86: Add SMBIOS table support")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  include/smbios.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/smbios.h b/include/smbios.h
> index e601283d29..88c19ae062 100644
> --- a/include/smbios.h
> +++ b/include/smbios.h
> @@ -139,6 +139,7 @@ struct __packed smbios_type2 {
>  	u8 chassis_location;
>  	u16 chassis_handle;
>  	u8 board_type;
> +	u8 number_contained_objects;
>  	char eos[SMBIOS_STRUCT_EOS_BYTES];
>  };
>
> --
> 2.43.0
>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
diff mbox series

Patch

diff --git a/include/smbios.h b/include/smbios.h
index e601283d29..88c19ae062 100644
--- a/include/smbios.h
+++ b/include/smbios.h
@@ -139,6 +139,7 @@  struct __packed smbios_type2 {
 	u8 chassis_location;
 	u16 chassis_handle;
 	u8 board_type;
+	u8 number_contained_objects;
 	char eos[SMBIOS_STRUCT_EOS_BYTES];
 };