| Message ID | 20231219103418.3445886-11-danishanwar@ti.com |
|---|---|
| State | RFC |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Introduce ICSSG Ethernet driver | expand |
On Tue, Dec 19, 2023 at 04:04:12PM +0530, MD Danish Anwar wrote: > The ICSSG IP on AM65x SoCs have two Industrial Ethernet Peripherals (IEPs) > to manage/generate Industrial Ethernet functions such as time stamping. > Each IEP sub-module is sourced from an internal clock mux that can be > sourced from either of the IP instance's ICSSG_IEP_GCLK or ICSSG_ICLK. > Add the IEP nodes for all the ICSSG instances. > > Signed-off-by: MD Danish Anwar <danishanwar@ti.com> > --- > arch/arm/dts/k3-am65-main.dtsi | 36 ++++++++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) What's the status of all of the DT side of this, upstream?
Hi Tom, On 19/12/23 11:16 pm, Tom Rini wrote: > On Tue, Dec 19, 2023 at 04:04:12PM +0530, MD Danish Anwar wrote: > >> The ICSSG IP on AM65x SoCs have two Industrial Ethernet Peripherals (IEPs) >> to manage/generate Industrial Ethernet functions such as time stamping. >> Each IEP sub-module is sourced from an internal clock mux that can be >> sourced from either of the IP instance's ICSSG_IEP_GCLK or ICSSG_ICLK. >> Add the IEP nodes for all the ICSSG instances. >> >> Signed-off-by: MD Danish Anwar <danishanwar@ti.com> >> --- >> arch/arm/dts/k3-am65-main.dtsi | 36 ++++++++++++++++++++++++++++++++++ >> 1 file changed, 36 insertions(+) > > What's the status of all of the DT side of this, upstream? > All of the DT patches are already part of upstream linux kernel except for patch 08/16. This patch is currently in linux-next and will be in linux in 6.8-rc1.
On 10:17-20231220, MD Danish Anwar wrote: > Hi Tom, > > On 19/12/23 11:16 pm, Tom Rini wrote: > > On Tue, Dec 19, 2023 at 04:04:12PM +0530, MD Danish Anwar wrote: > > > >> The ICSSG IP on AM65x SoCs have two Industrial Ethernet Peripherals (IEPs) > >> to manage/generate Industrial Ethernet functions such as time stamping. > >> Each IEP sub-module is sourced from an internal clock mux that can be > >> sourced from either of the IP instance's ICSSG_IEP_GCLK or ICSSG_ICLK. > >> Add the IEP nodes for all the ICSSG instances. > >> > >> Signed-off-by: MD Danish Anwar <danishanwar@ti.com> > >> --- > >> arch/arm/dts/k3-am65-main.dtsi | 36 ++++++++++++++++++++++++++++++++++ > >> 1 file changed, 36 insertions(+) > > > > What's the status of all of the DT side of this, upstream? > > > > All of the DT patches are already part of upstream linux kernel except > for patch 08/16. This patch is currently in linux-next and will be in > linux in 6.8-rc1. > NAK. Send a sync at 6.8-rc1 and then start working - DONOT SEND patches modifying SoC dtsi or evm files directly in u-boot. I think you need to start talking to other folks in the team who have have received the same feedback.
On 12/20/2023 6:22 PM, Nishanth Menon wrote: > On 10:17-20231220, MD Danish Anwar wrote: >> Hi Tom, >> >> On 19/12/23 11:16 pm, Tom Rini wrote: >>> On Tue, Dec 19, 2023 at 04:04:12PM +0530, MD Danish Anwar wrote: >>> >>>> The ICSSG IP on AM65x SoCs have two Industrial Ethernet Peripherals (IEPs) >>>> to manage/generate Industrial Ethernet functions such as time stamping. >>>> Each IEP sub-module is sourced from an internal clock mux that can be >>>> sourced from either of the IP instance's ICSSG_IEP_GCLK or ICSSG_ICLK. >>>> Add the IEP nodes for all the ICSSG instances. >>>> >>>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com> >>>> --- >>>> arch/arm/dts/k3-am65-main.dtsi | 36 ++++++++++++++++++++++++++++++++++ >>>> 1 file changed, 36 insertions(+) >>> >>> What's the status of all of the DT side of this, upstream? >>> >> >> All of the DT patches are already part of upstream linux kernel except >> for patch 08/16. This patch is currently in linux-next and will be in >> linux in 6.8-rc1. >> > > NAK. > > Send a sync at 6.8-rc1 and then start working - DONOT SEND patches > modifying SoC dtsi or evm files directly in u-boot. > Sorry. I wasn't aware of this. I will resend this only after the changes are in mainline linux. > I think you need to start talking to other folks in the team who have > have received the same feedback. > Sure Nishant. Will do.
diff --git a/arch/arm/dts/k3-am65-main.dtsi b/arch/arm/dts/k3-am65-main.dtsi index 7f10520236..da48887559 100644 --- a/arch/arm/dts/k3-am65-main.dtsi +++ b/arch/arm/dts/k3-am65-main.dtsi @@ -969,6 +969,18 @@ }; }; + icssg0_iep0: iep@2e000 { + compatible = "ti,am654-icss-iep"; + reg = <0x2e000 0x1000>; + clocks = <&icssg0_iepclk_mux>; + }; + + icssg0_iep1: iep@2f000 { + compatible = "ti,am654-icss-iep"; + reg = <0x2f000 0x1000>; + clocks = <&icssg0_iepclk_mux>; + }; + icssg0_mii_rt: mii-rt@32000 { compatible = "ti,pruss-mii", "syscon"; reg = <0x32000 0x100>; @@ -1110,6 +1122,18 @@ }; }; + icssg1_iep0: iep@2e000 { + compatible = "ti,am654-icss-iep"; + reg = <0x2e000 0x1000>; + clocks = <&icssg1_iepclk_mux>; + }; + + icssg1_iep1: iep@2f000 { + compatible = "ti,am654-icss-iep"; + reg = <0x2f000 0x1000>; + clocks = <&icssg1_iepclk_mux>; + }; + icssg1_mii_rt: mii-rt@32000 { compatible = "ti,pruss-mii", "syscon"; reg = <0x32000 0x100>; @@ -1256,6 +1280,18 @@ reg = <0x32000 0x100>; }; + icssg2_iep0: iep@2e000 { + compatible = "ti,am654-icss-iep"; + reg = <0x2e000 0x1000>; + clocks = <&icssg2_iepclk_mux>; + }; + + icssg2_iep1: iep@2f000 { + compatible = "ti,am654-icss-iep"; + reg = <0x2f000 0x1000>; + clocks = <&icssg2_iepclk_mux>; + }; + icssg2_mii_g_rt: mii-g-rt@33000 { compatible = "ti,pruss-mii-g", "syscon"; reg = <0x33000 0x1000>;
The ICSSG IP on AM65x SoCs have two Industrial Ethernet Peripherals (IEPs) to manage/generate Industrial Ethernet functions such as time stamping. Each IEP sub-module is sourced from an internal clock mux that can be sourced from either of the IP instance's ICSSG_IEP_GCLK or ICSSG_ICLK. Add the IEP nodes for all the ICSSG instances. Signed-off-by: MD Danish Anwar <danishanwar@ti.com> --- arch/arm/dts/k3-am65-main.dtsi | 36 ++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+)