diff mbox series

[RFC,14/16] configs: am65x_evm_a53_defconfig: add SPL_LOAD_FIT_APPLY_OVERLAY

Message ID 20231219103418.3445886-15-danishanwar@ti.com
State RFC
Delegated to: Tom Rini
Headers show
Series Introduce ICSSG Ethernet driver | expand

Commit Message

MD Danish Anwar Dec. 19, 2023, 10:34 a.m. UTC
We want SPL to apply DTB overlays (e.g. NAND card overlay) so
enable SPL_LOAD_FIT_APPLY_OVERLAY.
Increase SPL_LOAD_FIT_APPLY_OVERLAY_BUF_SZ and
SPL_STACK_R_MALLOC_SIMPLE_LEN. Without this SPL hangs.

Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
---
 configs/am65x_evm_a53_defconfig | 3 +++
 1 file changed, 3 insertions(+)

Comments

Roger Quadros Dec. 20, 2023, 10:02 a.m. UTC | #1
On 19/12/2023 12:34, MD Danish Anwar wrote:
> We want SPL to apply DTB overlays (e.g. NAND card overlay) so
> enable SPL_LOAD_FIT_APPLY_OVERLAY.
> Increase SPL_LOAD_FIT_APPLY_OVERLAY_BUF_SZ and
> SPL_STACK_R_MALLOC_SIMPLE_LEN. Without this SPL hangs.
> 
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> ---
>  configs/am65x_evm_a53_defconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/configs/am65x_evm_a53_defconfig b/configs/am65x_evm_a53_defconfig
> index e79a961317..2755d7082f 100644
> --- a/configs/am65x_evm_a53_defconfig
> +++ b/configs/am65x_evm_a53_defconfig
> @@ -70,6 +70,9 @@ CONFIG_CMD_I2C=y
>  CONFIG_CMD_MMC=y
>  CONFIG_CMD_PCI=y
>  CONFIG_CMD_REMOTEPROC=y
> +CONFIG_SPL_LOAD_FIT_APPLY_OVERLAY=y
> +CONFIG_SPL_LOAD_FIT_APPLY_OVERLAY_BUF_SZ=0x100000
> +CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x1000000

This change to 16MB is not required. I suppose default is 4MB.
Did you face issues with it?

>  CONFIG_CMD_USB=y
>  CONFIG_CMD_TIME=y
>  CONFIG_MTDIDS_DEFAULT="nor0=47040000.spi.0"
MD Danish Anwar Dec. 21, 2023, 5:57 a.m. UTC | #2
Roger,

On 20/12/23 3:32 pm, Roger Quadros wrote:
> 
> 
> On 19/12/2023 12:34, MD Danish Anwar wrote:
>> We want SPL to apply DTB overlays (e.g. NAND card overlay) so
>> enable SPL_LOAD_FIT_APPLY_OVERLAY.
>> Increase SPL_LOAD_FIT_APPLY_OVERLAY_BUF_SZ and
>> SPL_STACK_R_MALLOC_SIMPLE_LEN. Without this SPL hangs.
>>
>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>> ---
>>  configs/am65x_evm_a53_defconfig | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/configs/am65x_evm_a53_defconfig b/configs/am65x_evm_a53_defconfig
>> index e79a961317..2755d7082f 100644
>> --- a/configs/am65x_evm_a53_defconfig
>> +++ b/configs/am65x_evm_a53_defconfig
>> @@ -70,6 +70,9 @@ CONFIG_CMD_I2C=y
>>  CONFIG_CMD_MMC=y
>>  CONFIG_CMD_PCI=y
>>  CONFIG_CMD_REMOTEPROC=y
>> +CONFIG_SPL_LOAD_FIT_APPLY_OVERLAY=y
>> +CONFIG_SPL_LOAD_FIT_APPLY_OVERLAY_BUF_SZ=0x100000
>> +CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x1000000
> 
> This change to 16MB is not required. I suppose default is 4MB.
> Did you face issues with it?
> 

Without these I see below error in uboot,

U-Boot SPL 2024.01-rc5-00539-gdc3afd4d5b (Dec 21 2023 - 11:23:56 +0530)
SYSFW ABI: 3.1 (firmware rev 0x0009 '9.1.6--v09.01.06 (Kool Koala)')
Trying to boot from MMC2
spl_register_fat_device: fat register err - -1
spl_load_image_fat: error reading image u-boot.img, err - -1
SPL: failed to boot from all boot devices
### ERROR ### Please RESET the board ###

The only way to recover from here is to do a power cycle reset. But when
you boot again, the issue is seen again. So I think these changes are
also needed. Without this, SPL doesn't work properly.

>>  CONFIG_CMD_USB=y
>>  CONFIG_CMD_TIME=y
>>  CONFIG_MTDIDS_DEFAULT="nor0=47040000.spi.0"
>
diff mbox series

Patch

diff --git a/configs/am65x_evm_a53_defconfig b/configs/am65x_evm_a53_defconfig
index e79a961317..2755d7082f 100644
--- a/configs/am65x_evm_a53_defconfig
+++ b/configs/am65x_evm_a53_defconfig
@@ -70,6 +70,9 @@  CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_PCI=y
 CONFIG_CMD_REMOTEPROC=y
+CONFIG_SPL_LOAD_FIT_APPLY_OVERLAY=y
+CONFIG_SPL_LOAD_FIT_APPLY_OVERLAY_BUF_SZ=0x100000
+CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x1000000
 CONFIG_CMD_USB=y
 CONFIG_CMD_TIME=y
 CONFIG_MTDIDS_DEFAULT="nor0=47040000.spi.0"