Message ID | 20231208075037.114598-1-anshulusr@gmail.com |
---|---|
State | Not Applicable |
Headers | show |
Series | [v1] dt-bindings: input: convert gpio-mouse to json-schema | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | warning | total: 0 errors, 2 warnings, 68 lines checked |
robh/patch-applied | success | |
robh/dtbs-check | warning | build log |
robh/dt-meta-schema | success |
On 08/12/2023 08:50, Anshul Dalal wrote: > Convert device tree binding documentation for GPIO attached mouse to > json-schema. > > Signed-off-by: Anshul Dalal <anshulusr@gmail.com> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> You cannot have v1 being already reviewed. This is some newer version. > --- Missing changelog. Best regards, Krzysztof
On 12/8/23 15:57, Krzysztof Kozlowski wrote: > On 08/12/2023 08:50, Anshul Dalal wrote: >> Convert device tree binding documentation for GPIO attached mouse to >> json-schema. >> >> Signed-off-by: Anshul Dalal <anshulusr@gmail.com> >> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > You cannot have v1 being already reviewed. This is some newer version. > >> --- > > Missing changelog. This is a copy of an earlier patch[1]. Since the patch had been sitting idle for past 10 days, I reposed it with the Reviewed-by tags added in. Please let me know if this is the right way or if there is need for a changelog. [1]: https://lore.kernel.org/lkml/20231126103029.851742-1-anshulusr@gmail.com/ Best regards, Anshul
On 08/12/2023 11:33, Anshul Dalal wrote: > > > On 12/8/23 15:57, Krzysztof Kozlowski wrote: >> On 08/12/2023 08:50, Anshul Dalal wrote: >>> Convert device tree binding documentation for GPIO attached mouse to >>> json-schema. >>> >>> Signed-off-by: Anshul Dalal <anshulusr@gmail.com> >>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> You cannot have v1 being already reviewed. This is some newer version. >> >>> --- >> >> Missing changelog. > > This is a copy of an earlier patch[1]. Since the patch had been sitting > idle for past 10 days, I reposed it with the Reviewed-by tags added in. > Please let me know if this is the right way or if there is need for a > changelog. > > [1]: > https://lore.kernel.org/lkml/20231126103029.851742-1-anshulusr@gmail.com/ OK, then it should be: "[PATCH RESEND] ...." with a short changelog like: --- Resending with collected tags. ... (Sharing this for future, no need to resend it now) Best regards, Krzysztof
On Fri, Dec 08, 2023 at 01:20:35PM +0530, Anshul Dalal wrote: > Convert device tree binding documentation for GPIO attached mouse to > json-schema. > > Signed-off-by: Anshul Dalal <anshulusr@gmail.com> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Applied, thank you.
diff --git a/Documentation/devicetree/bindings/input/gpio-mouse.txt b/Documentation/devicetree/bindings/input/gpio-mouse.txt deleted file mode 100644 index 519510a11af9..000000000000 --- a/Documentation/devicetree/bindings/input/gpio-mouse.txt +++ /dev/null @@ -1,32 +0,0 @@ -Device-Tree bindings for GPIO attached mice - -This simply uses standard GPIO handles to define a simple mouse connected -to 5-7 GPIO lines. - -Required properties: - - compatible: must be "gpio-mouse" - - scan-interval-ms: The scanning interval in milliseconds - - up-gpios: GPIO line phandle to the line indicating "up" - - down-gpios: GPIO line phandle to the line indicating "down" - - left-gpios: GPIO line phandle to the line indicating "left" - - right-gpios: GPIO line phandle to the line indicating "right" - -Optional properties: - - button-left-gpios: GPIO line handle to the left mouse button - - button-middle-gpios: GPIO line handle to the middle mouse button - - button-right-gpios: GPIO line handle to the right mouse button -Example: - -#include <dt-bindings/gpio/gpio.h> - -gpio-mouse { - compatible = "gpio-mouse"; - scan-interval-ms = <50>; - up-gpios = <&gpio0 0 GPIO_ACTIVE_LOW>; - down-gpios = <&gpio0 1 GPIO_ACTIVE_LOW>; - left-gpios = <&gpio0 2 GPIO_ACTIVE_LOW>; - right-gpios = <&gpio0 3 GPIO_ACTIVE_LOW>; - button-left-gpios = <&gpio0 4 GPIO_ACTIVE_LOW>; - button-middle-gpios = <&gpio0 5 GPIO_ACTIVE_LOW>; - button-right-gpios = <&gpio0 6 GPIO_ACTIVE_LOW>; -}; diff --git a/Documentation/devicetree/bindings/input/gpio-mouse.yaml b/Documentation/devicetree/bindings/input/gpio-mouse.yaml new file mode 100644 index 000000000000..3928ec6aff1d --- /dev/null +++ b/Documentation/devicetree/bindings/input/gpio-mouse.yaml @@ -0,0 +1,68 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/gpio-mouse.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: GPIO attached mouse + +description: | + This simply uses standard GPIO handles to define a simple mouse connected + to 5-7 GPIO lines. + +maintainers: + - Anshul Dalal <anshulusr@gmail.com> + +properties: + compatible: + const: gpio-mouse + + scan-interval-ms: + maxItems: 1 + + up-gpios: + maxItems: 1 + + down-gpios: + maxItems: 1 + + left-gpios: + maxItems: 1 + + right-gpios: + maxItems: 1 + + button-left-gpios: + maxItems: 1 + + button-middle-gpios: + maxItems: 1 + + button-right-gpios: + maxItems: 1 + +required: + - compatible + - scan-interval-ms + - up-gpios + - down-gpios + - left-gpios + - right-gpios + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + gpio-mouse { + compatible = "gpio-mouse"; + scan-interval-ms = <50>; + up-gpios = <&gpio0 0 GPIO_ACTIVE_LOW>; + down-gpios = <&gpio0 1 GPIO_ACTIVE_LOW>; + left-gpios = <&gpio0 2 GPIO_ACTIVE_LOW>; + right-gpios = <&gpio0 3 GPIO_ACTIVE_LOW>; + button-left-gpios = <&gpio0 4 GPIO_ACTIVE_LOW>; + button-middle-gpios = <&gpio0 5 GPIO_ACTIVE_LOW>; + button-right-gpios = <&gpio0 6 GPIO_ACTIVE_LOW>; + };