| Message ID | 20231126151701.16534-1-sven@svenpeter.dev |
|---|---|
| Headers | show |
| Series | Apple M1 USB4/Thunderbolt DART support | expand |
On Sun, Nov 26, 2023 at 10:17 AM Sven Peter <sven@svenpeter.dev> wrote: > > Hi, > > The M1 SoCs have a second slightly different variant of the regular > DART used for the USB4 PCIe ports. It supports 64 instead of 16 streams > which requires a minor change to the MMIO layout. > There seems to be no way to tell them apart from the regular DARTs by > just looking at the DART_PARAMs register so we have to add a new > compatible for those. > > Changes since v3: > none > > Changes since v2: > - drop the manual bypass disable > - added Rob's tag > > Changes since v1: > - apple,t8103-usb4-dart instead of apple,t8103-dart-usb4 as the > compatible > - collected Hector's tags > > Best, > > Sven > > Sven Peter (3): > dt-bindings: iommu: dart: Add t8103-usb4-dart compatible > iommu: dart: Write to all DART_T8020_STREAM_SELECT > iommu: dart: Add support for t8103 USB4 DART > > .../devicetree/bindings/iommu/apple,dart.yaml | 1 + > drivers/iommu/apple-dart.c | 35 +++++++++++++++++-- > 2 files changed, 34 insertions(+), 2 deletions(-) > > -- > 2.34.1 > > Series LGTM. Reviewed-by: Neal Gompa <neal@gompa.dev>
On Sun, Nov 26, 2023 at 04:16:58PM +0100, Sven Peter wrote: > Sven Peter (3): > dt-bindings: iommu: dart: Add t8103-usb4-dart compatible > iommu: dart: Write to all DART_T8020_STREAM_SELECT > iommu: dart: Add support for t8103 USB4 DART > > .../devicetree/bindings/iommu/apple,dart.yaml | 1 + > drivers/iommu/apple-dart.c | 35 +++++++++++++++++-- > 2 files changed, 34 insertions(+), 2 deletions(-) Applied, thanks.
Hi, The M1 SoCs have a second slightly different variant of the regular DART used for the USB4 PCIe ports. It supports 64 instead of 16 streams which requires a minor change to the MMIO layout. There seems to be no way to tell them apart from the regular DARTs by just looking at the DART_PARAMs register so we have to add a new compatible for those. Changes since v3: none Changes since v2: - drop the manual bypass disable - added Rob's tag Changes since v1: - apple,t8103-usb4-dart instead of apple,t8103-dart-usb4 as the compatible - collected Hector's tags Best, Sven Sven Peter (3): dt-bindings: iommu: dart: Add t8103-usb4-dart compatible iommu: dart: Write to all DART_T8020_STREAM_SELECT iommu: dart: Add support for t8103 USB4 DART .../devicetree/bindings/iommu/apple,dart.yaml | 1 + drivers/iommu/apple-dart.c | 35 +++++++++++++++++-- 2 files changed, 34 insertions(+), 2 deletions(-)