| Message ID | 20231124101619.6470-11-hkallweit1@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON | expand |
On Fri, Nov 24, 2023 at 3:16 AM Heiner Kallweit <hkallweit1@gmail.com> wrote: > > After removal of the legacy eeprom driver the only remaining I2C > client device driver supporting I2C_CLASS_SPD is jc42. Because this > driver also supports I2C_CLASS_HWMON, adapters don't have to > declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON. > It's one step towards getting rid of I2C_CLASS_SPD mid-term. > > Series was created supported by Coccinelle and its splitpatch. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > Acked: > --- > drivers/i2c/busses/scx200_acb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/scx200_acb.c b/drivers/i2c/busses/scx200_acb.c > index 83c1db610..3648382b8 100644 > --- a/drivers/i2c/busses/scx200_acb.c > +++ b/drivers/i2c/busses/scx200_acb.c > @@ -427,7 +427,7 @@ static struct scx200_acb_iface *scx200_create_iface(const char *text, > snprintf(adapter->name, sizeof(adapter->name), "%s ACB%d", text, index); > adapter->owner = THIS_MODULE; > adapter->algo = &scx200_acb_algorithm; > - adapter->class = I2C_CLASS_HWMON | I2C_CLASS_SPD; > + adapter->class = I2C_CLASS_HWMON; > adapter->dev.parent = dev; > > mutex_init(&iface->mutex); >
On 26.11.2023 07:03, jim.cromie@gmail.com wrote: > On Fri, Nov 24, 2023 at 3:16 AM Heiner Kallweit <hkallweit1@gmail.com> wrote: >> >> After removal of the legacy eeprom driver the only remaining I2C >> client device driver supporting I2C_CLASS_SPD is jc42. Because this >> driver also supports I2C_CLASS_HWMON, adapters don't have to >> declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON. >> It's one step towards getting rid of I2C_CLASS_SPD mid-term. >> >> Series was created supported by Coccinelle and its splitpatch. >> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> >> > > Acked: > Thanks. Could you please respond with a proper Acked-by tag so that patchwork can pick it up? > >> --- >> drivers/i2c/busses/scx200_acb.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/i2c/busses/scx200_acb.c b/drivers/i2c/busses/scx200_acb.c >> index 83c1db610..3648382b8 100644 >> --- a/drivers/i2c/busses/scx200_acb.c >> +++ b/drivers/i2c/busses/scx200_acb.c >> @@ -427,7 +427,7 @@ static struct scx200_acb_iface *scx200_create_iface(const char *text, >> snprintf(adapter->name, sizeof(adapter->name), "%s ACB%d", text, index); >> adapter->owner = THIS_MODULE; >> adapter->algo = &scx200_acb_algorithm; >> - adapter->class = I2C_CLASS_HWMON | I2C_CLASS_SPD; >> + adapter->class = I2C_CLASS_HWMON; >> adapter->dev.parent = dev; >> >> mutex_init(&iface->mutex); >>
Hi Heiner, in this last patch I will add a couple of minor comments valid for the previous, as well. On Fri, Nov 24, 2023 at 11:16:19AM +0100, Heiner Kallweit wrote: > After removal of the legacy eeprom driver the only remaining I2C > client device driver supporting I2C_CLASS_SPD is jc42. Because this > driver also supports I2C_CLASS_HWMON, adapters don't have to > declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON. > It's one step towards getting rid of I2C_CLASS_SPD mid-term. > > Series was created supported by Coccinelle and its splitpatch. this sentence is grammatically incorrect, I guess you meant: "The series was created with support from Coccinelle and its splitpatch feature." Please fix it if you are going to resend it. > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > Just for you to know, all your patches have a blank line after your SoB, it doesn't really matter as I guess git removes it. In any case, as before: Acked-by: Andi Shyti <andi.shyti@kernel.org> and I believe: Acked-by: Jim Cromie <jim.cromie@gmail.com> so that patchwork takes it. Thanks, Andi
diff --git a/drivers/i2c/busses/scx200_acb.c b/drivers/i2c/busses/scx200_acb.c index 83c1db610..3648382b8 100644 --- a/drivers/i2c/busses/scx200_acb.c +++ b/drivers/i2c/busses/scx200_acb.c @@ -427,7 +427,7 @@ static struct scx200_acb_iface *scx200_create_iface(const char *text, snprintf(adapter->name, sizeof(adapter->name), "%s ACB%d", text, index); adapter->owner = THIS_MODULE; adapter->algo = &scx200_acb_algorithm; - adapter->class = I2C_CLASS_HWMON | I2C_CLASS_SPD; + adapter->class = I2C_CLASS_HWMON; adapter->dev.parent = dev; mutex_init(&iface->mutex);
After removal of the legacy eeprom driver the only remaining I2C client device driver supporting I2C_CLASS_SPD is jc42. Because this driver also supports I2C_CLASS_HWMON, adapters don't have to declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON. It's one step towards getting rid of I2C_CLASS_SPD mid-term. Series was created supported by Coccinelle and its splitpatch. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/i2c/busses/scx200_acb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)