mbox series

[0/3,Unstable,Noble] Include SD 7.0 card Realtek RTS5264 support

Message ID 20231121035358.2523345-1-vicamo.yang@canonical.com
Headers show
Series Include SD 7.0 card Realtek RTS5264 support | expand

Message

You-Sheng Yang Nov. 21, 2023, 3:53 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2039925

[Impact]

Missing Realtek RTS5264 SD 7.0 cardreader support:
```
$ lspci -nnnk
0000:56:00.0 Unassigned class [ff00]: Realtek Semiconductor Co., Ltd. Device [10ec:5264] (rev 01)
        Subsystem: Dell Device [1028:0cc8]
        Kernel driver in use: rtsx_pci
        Kernel modules: rtsx_pci
```

[Fix]

V4 patchset under review:
https://patchwork.kernel.org/project/linux-mmc/patch/bf45a73f01cc43669dc3796ccff25598@realtek.com/

[Test Case]

With kernel driver probed and loaded successfully, there should be a line in the
dmesg:
```
rtsx_pci 0000:56:00.0: enabling device (0000 -> 0002)
```

[Where problems could occur]

New hardware, expecting all possible way to go wrong.

[Other Info]

Nominated for oem-6.5 and Noble.

Ricky WU (3):
  UBUNTU: SAUCE: misc: rtsx: add to support new card reader rts5264 new
    definition and function
  UBUNTU: SAUCE: misc: rtsx: add to support new card reader rts5264
  UBUNTU: SAUCE: mmc: rtsx: add rts5264 to support sd express card

 drivers/misc/cardreader/Makefile   |   2 +-
 drivers/misc/cardreader/rts5264.c  | 886 +++++++++++++++++++++++++++++
 drivers/misc/cardreader/rts5264.h  | 278 +++++++++
 drivers/misc/cardreader/rtsx_pcr.c |  30 +-
 drivers/misc/cardreader/rtsx_pcr.h |   1 +
 drivers/mmc/host/rtsx_pci_sdmmc.c  |  17 +-
 include/linux/rtsx_pci.h           |   8 +
 7 files changed, 1215 insertions(+), 7 deletions(-)
 create mode 100644 drivers/misc/cardreader/rts5264.c
 create mode 100644 drivers/misc/cardreader/rts5264.h

Comments

Tim Gardner Nov. 22, 2023, 2:22 p.m. UTC | #1
On 11/20/23 8:53 PM, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/2039925
> 
> [Impact]
> 
> Missing Realtek RTS5264 SD 7.0 cardreader support:
> ```
> $ lspci -nnnk
> 0000:56:00.0 Unassigned class [ff00]: Realtek Semiconductor Co., Ltd. Device [10ec:5264] (rev 01)
>          Subsystem: Dell Device [1028:0cc8]
>          Kernel driver in use: rtsx_pci
>          Kernel modules: rtsx_pci
> ```
> 
> [Fix]
> 
> V4 patchset under review:
> https://patchwork.kernel.org/project/linux-mmc/patch/bf45a73f01cc43669dc3796ccff25598@realtek.com/
> 
> [Test Case]
> 
> With kernel driver probed and loaded successfully, there should be a line in the
> dmesg:
> ```
> rtsx_pci 0000:56:00.0: enabling device (0000 -> 0002)
> ```
> 
> [Where problems could occur]
> 
> New hardware, expecting all possible way to go wrong.
> 
> [Other Info]
> 
> Nominated for oem-6.5 and Noble.
> 
> Ricky WU (3):
>    UBUNTU: SAUCE: misc: rtsx: add to support new card reader rts5264 new
>      definition and function
>    UBUNTU: SAUCE: misc: rtsx: add to support new card reader rts5264
>    UBUNTU: SAUCE: mmc: rtsx: add rts5264 to support sd express card
> 
>   drivers/misc/cardreader/Makefile   |   2 +-
>   drivers/misc/cardreader/rts5264.c  | 886 +++++++++++++++++++++++++++++
>   drivers/misc/cardreader/rts5264.h  | 278 +++++++++
>   drivers/misc/cardreader/rtsx_pcr.c |  30 +-
>   drivers/misc/cardreader/rtsx_pcr.h |   1 +
>   drivers/mmc/host/rtsx_pci_sdmmc.c  |  17 +-
>   include/linux/rtsx_pci.h           |   8 +
>   7 files changed, 1215 insertions(+), 7 deletions(-)
>   create mode 100644 drivers/misc/cardreader/rts5264.c
>   create mode 100644 drivers/misc/cardreader/rts5264.h
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>

Looks to be self contained. Is it going upstream soon ?
Manuel Diewald Nov. 22, 2023, 5:23 p.m. UTC | #2
On Tue, Nov 21, 2023 at 11:53:55AM +0800, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/2039925
> 
> [Impact]
> 
> Missing Realtek RTS5264 SD 7.0 cardreader support:
> ```
> $ lspci -nnnk
> 0000:56:00.0 Unassigned class [ff00]: Realtek Semiconductor Co., Ltd. Device [10ec:5264] (rev 01)
>         Subsystem: Dell Device [1028:0cc8]
>         Kernel driver in use: rtsx_pci
>         Kernel modules: rtsx_pci
> ```
> 
> [Fix]
> 
> V4 patchset under review:
> https://patchwork.kernel.org/project/linux-mmc/patch/bf45a73f01cc43669dc3796ccff25598@realtek.com/
> 
> [Test Case]
> 
> With kernel driver probed and loaded successfully, there should be a line in the
> dmesg:
> ```
> rtsx_pci 0000:56:00.0: enabling device (0000 -> 0002)
> ```
> 
> [Where problems could occur]
> 
> New hardware, expecting all possible way to go wrong.
> 
> [Other Info]
> 
> Nominated for oem-6.5 and Noble.
> 
> Ricky WU (3):
>   UBUNTU: SAUCE: misc: rtsx: add to support new card reader rts5264 new
>     definition and function
>   UBUNTU: SAUCE: misc: rtsx: add to support new card reader rts5264
>   UBUNTU: SAUCE: mmc: rtsx: add rts5264 to support sd express card
> 
>  drivers/misc/cardreader/Makefile   |   2 +-
>  drivers/misc/cardreader/rts5264.c  | 886 +++++++++++++++++++++++++++++
>  drivers/misc/cardreader/rts5264.h  | 278 +++++++++
>  drivers/misc/cardreader/rtsx_pcr.c |  30 +-
>  drivers/misc/cardreader/rtsx_pcr.h |   1 +
>  drivers/mmc/host/rtsx_pci_sdmmc.c  |  17 +-
>  include/linux/rtsx_pci.h           |   8 +
>  7 files changed, 1215 insertions(+), 7 deletions(-)
>  create mode 100644 drivers/misc/cardreader/rts5264.c
>  create mode 100644 drivers/misc/cardreader/rts5264.h
> 
> -- 
> 2.40.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Acked-by: Manuel Diewald <manuel.diewald@canonical.com>
Andrea Righi Jan. 2, 2024, 12:12 p.m. UTC | #3
On Wed, Nov 22, 2023 at 07:22:46AM -0700, Tim Gardner wrote:
> On 11/20/23 8:53 PM, You-Sheng Yang wrote:
> > BugLink: https://bugs.launchpad.net/bugs/2039925
> > 
> > [Impact]
> > 
> > Missing Realtek RTS5264 SD 7.0 cardreader support:
> > ```
> > $ lspci -nnnk
> > 0000:56:00.0 Unassigned class [ff00]: Realtek Semiconductor Co., Ltd. Device [10ec:5264] (rev 01)
> >          Subsystem: Dell Device [1028:0cc8]
> >          Kernel driver in use: rtsx_pci
> >          Kernel modules: rtsx_pci
> > ```
> > 
> > [Fix]
> > 
> > V4 patchset under review:
> > https://patchwork.kernel.org/project/linux-mmc/patch/bf45a73f01cc43669dc3796ccff25598@realtek.com/
> > 
> > [Test Case]
> > 
> > With kernel driver probed and loaded successfully, there should be a line in the
> > dmesg:
> > ```
> > rtsx_pci 0000:56:00.0: enabling device (0000 -> 0002)
> > ```
> > 
> > [Where problems could occur]
> > 
> > New hardware, expecting all possible way to go wrong.
> > 
> > [Other Info]
> > 
> > Nominated for oem-6.5 and Noble.
> > 
> > Ricky WU (3):
> >    UBUNTU: SAUCE: misc: rtsx: add to support new card reader rts5264 new
> >      definition and function
> >    UBUNTU: SAUCE: misc: rtsx: add to support new card reader rts5264
> >    UBUNTU: SAUCE: mmc: rtsx: add rts5264 to support sd express card
> > 
> >   drivers/misc/cardreader/Makefile   |   2 +-
> >   drivers/misc/cardreader/rts5264.c  | 886 +++++++++++++++++++++++++++++
> >   drivers/misc/cardreader/rts5264.h  | 278 +++++++++
> >   drivers/misc/cardreader/rtsx_pcr.c |  30 +-
> >   drivers/misc/cardreader/rtsx_pcr.h |   1 +
> >   drivers/mmc/host/rtsx_pci_sdmmc.c  |  17 +-
> >   include/linux/rtsx_pci.h           |   8 +
> >   7 files changed, 1215 insertions(+), 7 deletions(-)
> >   create mode 100644 drivers/misc/cardreader/rts5264.c
> >   create mode 100644 drivers/misc/cardreader/rts5264.h
> > 
> Acked-by: Tim Gardner <tim.gardner@canonical.com>
> 
> Looks to be self contained. Is it going upstream soon ?

I have the same question... is there any plan to upstream this?
Otherwise, we need a plan to maintain this.

Thanks,
-Andrea