| Message ID | 20231103190454.454748-1-i.maximets@ovn.org |
|---|---|
| State | Accepted |
| Commit | 4d74e230730ab0643aaad14d11a6712408cbd705 |
| Delegated to: | Ilya Maximets |
| Headers | show |
| Series | [ovs-dev] build-aux/extract-ofp-fields: Fix the number of Summary columns. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
On Fri, Nov 03, 2023 at 08:04:53PM +0100, Ilya Maximets wrote: > The table has only 6 columns, not 7. This doesn't really affect > rendering. Only slightly affects calculations around how much space > the table needs. > > Fixes: 96fee5e0a2a0 ("ovs-fields: New manpage to document Open vSwitch and OpenFlow fields.") > Signed-off-by: Ilya Maximets <i.maximets@ovn.org> Thanks Ilya, this looks good to me. FWIIW, I was not able to observe any difference in the rendering of vs-fields.7. Acked-by: Simon Horman <horms@ovn.org>
On 11/14/23 14:28, Simon Horman wrote: > On Fri, Nov 03, 2023 at 08:04:53PM +0100, Ilya Maximets wrote: >> The table has only 6 columns, not 7. This doesn't really affect >> rendering. Only slightly affects calculations around how much space >> the table needs. >> >> Fixes: 96fee5e0a2a0 ("ovs-fields: New manpage to document Open vSwitch and OpenFlow fields.") >> Signed-off-by: Ilya Maximets <i.maximets@ovn.org> > > Thanks Ilya, > > this looks good to me. > > FWIIW, I was not able to observe any difference in the rendering > of vs-fields.7. > > Acked-by: Simon Horman <horms@ovn.org> Thanks! Applied. I didn't backport this for now as it doesn't affect anything visible. Can be backported later if needed to resolve conflicts for some other backports. Best regards, Ilya Maximets.
diff --git a/build-aux/extract-ofp-fields b/build-aux/extract-ofp-fields index 89d80c208..2657d9249 100755 --- a/build-aux/extract-ofp-fields +++ b/build-aux/extract-ofp-fields @@ -318,7 +318,7 @@ def group_xml_to_nroff(group_node, fields): '.SS "Summary:"\n', ".TS\n", "tab(;),nowarn;\n", - "l l l l l l l.\n", + "l l l l l l.\n", "Name;Bytes;Mask;RW?;Prereqs;NXM/OXM Support\n", r"\_;\_;\_;\_;\_;\_", "\n",
The table has only 6 columns, not 7. This doesn't really affect rendering. Only slightly affects calculations around how much space the table needs. Fixes: 96fee5e0a2a0 ("ovs-fields: New manpage to document Open vSwitch and OpenFlow fields.") Signed-off-by: Ilya Maximets <i.maximets@ovn.org> --- build-aux/extract-ofp-fields | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)