| Message ID | 20231114185613.322570-2-afd@ti.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [1/4] dt-bindings: spi: Convert spi-davinci.txt to YAML | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 59 lines checked |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Tue, 14 Nov 2023 12:56:11 -0600, Andrew Davis wrote: > Convert keystone-gate.txt to ti,keystone,psc-clock.yaml. > > Signed-off-by: Andrew Davis <afd@ti.com> > --- > .../bindings/clock/keystone-gate.txt | 29 --------- > .../bindings/clock/ti,keystone,psc-clock.yaml | 59 +++++++++++++++++++ > 2 files changed, 59 insertions(+), 29 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/clock/keystone-gate.txt > create mode 100644 Documentation/devicetree/bindings/clock/ti,keystone,psc-clock.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/clock/ti,keystone,psc-clock.example.dts:18.24-26.11: Warning (unit_address_vs_reg): /example-0/clkusb: node has a reg or ranges property, but no unit name doc reference errors (make refcheckdocs): Warning: Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.txt references a file that doesn't exist: Documentation/devicetree/bindings/clock/keystone-gate.txt Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.txt: Documentation/devicetree/bindings/clock/keystone-gate.txt See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231114185613.322570-2-afd@ti.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/clock/keystone-gate.txt b/Documentation/devicetree/bindings/clock/keystone-gate.txt deleted file mode 100644 index c5aa187026e3a..0000000000000 --- a/Documentation/devicetree/bindings/clock/keystone-gate.txt +++ /dev/null @@ -1,29 +0,0 @@ -Status: Unstable - ABI compatibility may be broken in the future - -Binding for Keystone gate control driver which uses PSC controller IP. - -This binding uses the common clock binding[1]. - -[1] Documentation/devicetree/bindings/clock/clock-bindings.txt - -Required properties: -- compatible : shall be "ti,keystone,psc-clock". -- #clock-cells : from common clock binding; shall be set to 0. -- clocks : parent clock phandle -- reg : psc control and domain address address space -- reg-names : psc control and domain registers -- domain-id : psc domain id needed to check the transition state register - -Optional properties: -- clock-output-names : From common clock binding to override the - default output clock name -Example: - clkusb: clkusb { - #clock-cells = <0>; - compatible = "ti,keystone,psc-clock"; - clocks = <&chipclk16>; - clock-output-names = "usb"; - reg = <0x02350008 0xb00>, <0x02350000 0x400>; - reg-names = "control", "domain"; - domain-id = <0>; - }; diff --git a/Documentation/devicetree/bindings/clock/ti,keystone,psc-clock.yaml b/Documentation/devicetree/bindings/clock/ti,keystone,psc-clock.yaml new file mode 100644 index 0000000000000..3da5cdc2affa9 --- /dev/null +++ b/Documentation/devicetree/bindings/clock/ti,keystone,psc-clock.yaml @@ -0,0 +1,59 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/clock/ti,keystone,psc-clock.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Keystone gate control driver which uses PSC controller IP + +maintainers: + - Andrew Davis <afd@ti.com> + +properties: + compatible: + const: ti,keystone,psc-clock + + reg: + items: + - description: PSC control registers + - description: Domain registers + + reg-names: + items: + - const: control + - const: domain + + domain-id: + description: PSC domain id needed to check the transition state register + $ref: /schemas/types.yaml#/definitions/uint32 + + clocks: + maxItems: 1 + + clock-output-names: + maxItems: 1 + + "#clock-cells": + const: 0 + +required: + - compatible + - reg + - reg-names + - domain-id + - clocks + - "#clock-cells" + +additionalProperties: false + +examples: + - | + clkusb: clkusb { + compatible = "ti,keystone,psc-clock"; + reg = <0x02350008 0xb00>, <0x02350000 0x400>; + reg-names = "control", "domain"; + domain-id = <0>; + clocks = <&chipclk16>; + clock-output-names = "usb"; + #clock-cells = <0>; + };
Convert keystone-gate.txt to ti,keystone,psc-clock.yaml. Signed-off-by: Andrew Davis <afd@ti.com> --- .../bindings/clock/keystone-gate.txt | 29 --------- .../bindings/clock/ti,keystone,psc-clock.yaml | 59 +++++++++++++++++++ 2 files changed, 59 insertions(+), 29 deletions(-) delete mode 100644 Documentation/devicetree/bindings/clock/keystone-gate.txt create mode 100644 Documentation/devicetree/bindings/clock/ti,keystone,psc-clock.yaml