mbox series

[0/1,mantic:linux] Revert: drm/ast: report connection status on Display Port

Message ID 20231107102546.39000-1-philip.cox@canonical.com
Headers show
Series Revert: drm/ast: report connection status on Display Port | expand

Message

Philip Cox Nov. 7, 2023, 10:25 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2042850

SRU Justification:

[Impact]
On systems with Aspeed 2600 revision 52 GPUs, the display fails to progress to the login prompt.  Without reverting 

   commit: 916ae609a033cbb55661905d310ba2358b7621ea
   Author:  Jocelyn Falempe <jfalempe@redhat.com>
   Date:    Thu Jul 13 15:41:31 2023 +0200
   Subject: drm/ast: report connection status on Display Port.

the kernel command line option of "nomodeset" needs to be passed in order to have the system reach the login prompt. 


[Fix]
The fix for now is to revert this change to restore the previous behaviour.  This will restore the functionality that we had prior to the regression in 6.5.0-6.6. 

[Test Plan]
I have tested this on multiple versions of Aspeed 2600 GPU enabled BMCs, and the revision 52 systems that required the nomodeset option to boot, now boot fine, and there is no regression on the other systems.

[Where problems could occur]
As this reverts the mantic kernel's Aspeed GPU driver to the state it was was in the mantic 6.5.0-5.5 kernel, I think there is little room for regressions.  

----

Philip Cox (1):
  UBUNTU: SAUCE: (no-up) Revert "drm/ast: report connection status on
    Display Port."

 drivers/gpu/drm/ast/ast_dp.c    | 11 ----------
 drivers/gpu/drm/ast/ast_dp501.c | 37 +++++++++++----------------------
 drivers/gpu/drm/ast/ast_drv.h   |  2 --
 drivers/gpu/drm/ast/ast_mode.c  | 30 ++------------------------
 4 files changed, 14 insertions(+), 66 deletions(-)

Comments

Philip Cox Nov. 7, 2023, 1:49 p.m. UTC | #1
Looks like I have found the proper fix for the regression, so will send
out the fix shortly

On Tue, 2023-11-07 at 12:25 +0200, Philip Cox wrote:
> 
> 
> BugLink: https://bugs.launchpad.net/bugs/2042850
> 
> SRU Justification:
> 
> [Impact]
> On systems with Aspeed 2600 revision 52 GPUs, the display fails to
> progress to the login prompt.  Without reverting 
> 
>    commit: 916ae609a033cbb55661905d310ba2358b7621ea
>    Author:  Jocelyn Falempe <jfalempe@redhat.com>
>    Date:    Thu Jul 13 15:41:31 2023 +0200
>    Subject: drm/ast: report connection status on Display Port.
> 
> the kernel command line option of "nomodeset" needs to be passed in
> order to have the system reach the login prompt. 
> 
> 
> [Fix]
> The fix for now is to revert this change to restore the previous
> behaviour.  This will restore the functionality that we had prior to
> the regression in 6.5.0-6.6. 
> 
> [Test Plan]
> I have tested this on multiple versions of Aspeed 2600 GPU enabled
> BMCs, and the revision 52 systems that required the nomodeset option
> to boot, now boot fine, and there is no regression on the other
> systems.
> 
> [Where problems could occur]
> As this reverts the mantic kernel's Aspeed GPU driver to the state it
> was was in the mantic 6.5.0-5.5 kernel, I think there is little room
> for regressions.  
> 
> ----
> 
> Philip Cox (1):
>   UBUNTU: SAUCE: (no-up) Revert "drm/ast: report connection status on
>     Display Port."
> 
>  drivers/gpu/drm/ast/ast_dp.c    | 11 ----------
>  drivers/gpu/drm/ast/ast_dp501.c | 37 +++++++++++--------------------
> --
>  drivers/gpu/drm/ast/ast_drv.h   |  2 --
>  drivers/gpu/drm/ast/ast_mode.c  | 30 ++------------------------
>  4 files changed, 14 insertions(+), 66 deletions(-)
>