| Message ID | 20230823154547.10711-1-oleksandr.suvorov@foundries.io |
|---|---|
| State | Accepted |
| Commit | 9b8ebd3aec40b35c57973682e5c2df62279417c2 |
| Delegated to: | Jaehoon Chung |
| Headers | show |
| Series | mmc: spl: select SPL_BLK for SPL_DM_MMC | expand |
On Wed, Aug 23, 2023 at 06:45:45PM +0300, Oleksandr Suvorov wrote: > mmc_bind() in mmc-uclass.c calls blk_create_devicef() which is > defined in blk-uclass.c, so SPL_BLK is required by SPL_DM_MMC. > Implicitly select SPL_BLK for SPL_DM_MMC. > > Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io> Reviewed-by: Tom Rini <trini@konsulko.com>
On 8/24/23 00:45, Oleksandr Suvorov wrote: > mmc_bind() in mmc-uclass.c calls blk_create_devicef() which is > defined in blk-uclass.c, so SPL_BLK is required by SPL_DM_MMC. > Implicitly select SPL_BLK for SPL_DM_MMC. > > Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io> > Reviewed-by: Tom Rini <trini@konsulko.com> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Best Regards, Jaehoon Chung > --- > > drivers/mmc/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig > index de01b9687ba..d24677de076 100644 > --- a/drivers/mmc/Kconfig > +++ b/drivers/mmc/Kconfig > @@ -46,6 +46,7 @@ config SPL_DM_MMC > depends on SPL_DM && DM_MMC > default n if ARCH_MVEBU && !MVEBU_SPL_BOOT_DEVICE_MMC > default y > + select SPL_BLK > help > This enables the MultiMediaCard (MMC) uclass which supports MMC and > Secure Digital I/O (SDIO) cards. Both removable (SD, micro-SD, etc.)
> -----Original Message----- > From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Jaehoon Chung > Sent: Tuesday, October 31, 2023 2:04 PM > To: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>; u-boot@lists.denx.de > Cc: Peng Fan <peng.fan@nxp.com> > Subject: Re: [PATCH] mmc: spl: select SPL_BLK for SPL_DM_MMC > > On 8/24/23 00:45, Oleksandr Suvorov wrote: > > mmc_bind() in mmc-uclass.c calls blk_create_devicef() which is > > defined in blk-uclass.c, so SPL_BLK is required by SPL_DM_MMC. > > Implicitly select SPL_BLK for SPL_DM_MMC. > > > > Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io> > > Reviewed-by: Tom Rini <trini@konsulko.com> > > Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Applied to u-boot-mmc/master. Thanks! Best Regards, Jaehoon Chung > > Best Regards, > Jaehoon Chung > > > --- > > > > drivers/mmc/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig > > index de01b9687ba..d24677de076 100644 > > --- a/drivers/mmc/Kconfig > > +++ b/drivers/mmc/Kconfig > > @@ -46,6 +46,7 @@ config SPL_DM_MMC > > depends on SPL_DM && DM_MMC > > default n if ARCH_MVEBU && !MVEBU_SPL_BOOT_DEVICE_MMC > > default y > > + select SPL_BLK > > help > > This enables the MultiMediaCard (MMC) uclass which supports MMC and > > Secure Digital I/O (SDIO) cards. Both removable (SD, micro-SD, etc.)
diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig index de01b9687ba..d24677de076 100644 --- a/drivers/mmc/Kconfig +++ b/drivers/mmc/Kconfig @@ -46,6 +46,7 @@ config SPL_DM_MMC depends on SPL_DM && DM_MMC default n if ARCH_MVEBU && !MVEBU_SPL_BOOT_DEVICE_MMC default y + select SPL_BLK help This enables the MultiMediaCard (MMC) uclass which supports MMC and Secure Digital I/O (SDIO) cards. Both removable (SD, micro-SD, etc.)
mmc_bind() in mmc-uclass.c calls blk_create_devicef() which is defined in blk-uclass.c, so SPL_BLK is required by SPL_DM_MMC. Implicitly select SPL_BLK for SPL_DM_MMC. Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io> --- drivers/mmc/Kconfig | 1 + 1 file changed, 1 insertion(+)