diff mbox series

New SMB3.1.1 command

Message ID CAH2r5mvxf3j6aXGdzh8b7cRYJ=fHvjfkv=aHPStJRYR+x8auiA@mail.gmail.com
State New
Headers show
Series New SMB3.1.1 command | expand

Commit Message

Steve French Oct. 9, 2023, 4:15 a.m. UTC 
Add structs and defines for new SMB3.1.1 command, server to client notification.

    See MS-SMB2 section 2.2.44

Also another minor patch to clarify some of the unused CreateOptions flags

   See MS-SMB2 section 2.2.13

See attached.

Comments

Bharath SM Oct. 30, 2023, 12:44 p.m. UTC | #1 
> Also another minor patch to clarify some of the unused CreateOptions flags
>
>    See MS-SMB2 section 2.2.13
+/* FILE_OPEN_REMOTE_INSTANcE cpu_to_le32(0x00000400) should be zero, ignored */
INSTANcE should be corrected to INSTANCE
Steve French Oct. 30, 2023, 2:59 p.m. UTC | #2 
corrected - and updated the changeset in for-next

On Mon, Oct 30, 2023 at 7:44 AM Bharath SM <bharathsm.hsk@gmail.com> wrote:
>
> > Also another minor patch to clarify some of the unused CreateOptions flags
> >
> >    See MS-SMB2 section 2.2.13
> +/* FILE_OPEN_REMOTE_INSTANcE cpu_to_le32(0x00000400) should be zero, ignored */
> INSTANcE should be corrected to INSTANCE
diff mbox series

Patch

From 37a52ceb9b7b6e098846472e1b81ee95bfc0f6cb Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@microsoft.com>
Date: Sun, 8 Oct 2023 23:11:38 -0500
Subject: [PATCH] SMB3: clarify some of the unused CreateOption flags

Update comments to show flags which should be not set (zero).

See MS-SMB2 section 2.2.13

Signed-off-by: Steve French <stfrench@microsoft.com>
---
 fs/smb/common/smb2pdu.h | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/fs/smb/common/smb2pdu.h b/fs/smb/common/smb2pdu.h
index 73cdcf14ef27..8a469929cf62 100644
--- a/fs/smb/common/smb2pdu.h
+++ b/fs/smb/common/smb2pdu.h
@@ -1112,16 +1112,23 @@  struct smb2_server_client_notification {
 #define FILE_WRITE_THROUGH_LE		cpu_to_le32(0x00000002)
 #define FILE_SEQUENTIAL_ONLY_LE		cpu_to_le32(0x00000004)
 #define FILE_NO_INTERMEDIATE_BUFFERING_LE cpu_to_le32(0x00000008)
+/* FILE_SYNCHRONOUS_IO_ALERT_LE		cpu_to_le32(0x00000010) should be zero, ignored */
+/* FILE_SYNCHRONOUS_IO_NONALERT		cpu_to_le32(0x00000020) should be zero, ignored */
 #define FILE_NON_DIRECTORY_FILE_LE	cpu_to_le32(0x00000040)
 #define FILE_COMPLETE_IF_OPLOCKED_LE	cpu_to_le32(0x00000100)
 #define FILE_NO_EA_KNOWLEDGE_LE		cpu_to_le32(0x00000200)
+/* FILE_OPEN_REMOTE_INSTANcE		cpu_to_le32(0x00000400) should be zero, ignored */
 #define FILE_RANDOM_ACCESS_LE		cpu_to_le32(0x00000800)
-#define FILE_DELETE_ON_CLOSE_LE		cpu_to_le32(0x00001000)
+#define FILE_DELETE_ON_CLOSE_LE		cpu_to_le32(0x00001000) /* MBZ */
 #define FILE_OPEN_BY_FILE_ID_LE		cpu_to_le32(0x00002000)
 #define FILE_OPEN_FOR_BACKUP_INTENT_LE	cpu_to_le32(0x00004000)
 #define FILE_NO_COMPRESSION_LE		cpu_to_le32(0x00008000)
+/* FILE_OPEN_REQUIRING_OPLOCK		cpu_to_le32(0x00010000) should be zero, ignored */
+/* FILE_DISALLOW_EXCLUSIVE		cpu_to_le32(0x00020000) should be zero, ignored */
+/* FILE_RESERVE_OPFILTER		cpu_to_le32(0x00100000) MBZ */
 #define FILE_OPEN_REPARSE_POINT_LE	cpu_to_le32(0x00200000)
 #define FILE_OPEN_NO_RECALL_LE		cpu_to_le32(0x00400000)
+/* #define FILE_OPEN_FOR_FREE_SPACE_QUERY cpu_to_le32(0x00800000) should be zero, ignored */
 #define CREATE_OPTIONS_MASK_LE          cpu_to_le32(0x00FFFFFF)
 
 #define FILE_READ_RIGHTS_LE (FILE_READ_DATA_LE | FILE_READ_EA_LE \
-- 
2.39.2