| Message ID | 20231027073115.170201-1-dlemoal@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | [GIT,PULL] ata fixes for 6.6-final | expand |
On Thu, 26 Oct 2023 at 21:31, Damien Le Moal <dlemoal@kernel.org> wrote: > > A single patch to fix a regression introduced by the recent > suspend/resume fixes. The regression is that ATA disks are not stopped > on system shutdown, which is not recommended and increases the disks > SMART counters for unclean power off events. This patch fixes this by > refining the recent rework of the scsi device manage_xxx flags. Side note: I think 'bool' ends up always using a whole byte in 'struct scsi_device' (because you can't take an address of a single bit). And while it might all end up being unnoticeable due to padding, those bools are right next to bitfields. Which just makes me go "those should all have been just 'unsigned:1' fields". Of course, maybe they actually have their address taken, and it's all very intentional. Linus
The pull request you sent on Fri, 27 Oct 2023 16:31:15 +0900:
> ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata tags/ata-6.6-final
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/832328c9f8aa4b41423f29a53ba7080eb7214976
Thank you!
On 10/28/23 08:43, Linus Torvalds wrote: > On Thu, 26 Oct 2023 at 21:31, Damien Le Moal <dlemoal@kernel.org> wrote: >> >> A single patch to fix a regression introduced by the recent >> suspend/resume fixes. The regression is that ATA disks are not stopped >> on system shutdown, which is not recommended and increases the disks >> SMART counters for unclean power off events. This patch fixes this by >> refining the recent rework of the scsi device manage_xxx flags. > > Side note: I think 'bool' ends up always using a whole byte in 'struct > scsi_device' (because you can't take an address of a single bit). > > And while it might all end up being unnoticeable due to padding, those > bools are right next to bitfields. > > Which just makes me go "those should all have been just 'unsigned:1' fields". > > Of course, maybe they actually have their address taken, and it's all > very intentional. I will check. Thanks. > > Linus
Linus, The following changes since commit 626b13f015e080e434b1dee9a0c116ddbf4fb695: scsi: Do not rescan devices with a suspended queue (2023-10-10 14:42:22 +0900) are available in the Git repository at: ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata tags/ata-6.6-final for you to fetch changes up to 24eca2dce0f8d19db808c972b0281298d0bafe99: scsi: sd: Introduce manage_shutdown device flag (2023-10-27 10:00:19 +0900) ---------------------------------------------------------------- ATA fixes for 6.6-final A single patch to fix a regression introduced by the recent suspend/resume fixes. The regression is that ATA disks are not stopped on system shutdown, which is not recommended and increases the disks SMART counters for unclean power off events. This patch fixes this by refining the recent rework of the scsi device manage_xxx flags. ---------------------------------------------------------------- Damien Le Moal (1): scsi: sd: Introduce manage_shutdown device flag drivers/ata/libata-scsi.c | 5 +++-- drivers/firewire/sbp2.c | 1 + drivers/scsi/sd.c | 39 ++++++++++++++++++++++++++++++++++++--- include/scsi/scsi_device.h | 20 ++++++++++++++++++-- 4 files changed, 58 insertions(+), 7 deletions(-)