diff mbox series

[kvmtool,v2,6/6] riscv: Fix guest/init linkage for multilib toolchain

Message ID 20230918125730.1371985-7-apatel@ventanamicro.com
State Superseded
Headers show
Series RISC-V AIA irqchip and Svnapot support | expand

Commit Message

Anup Patel Sept. 18, 2023, 12:57 p.m. UTC 
For RISC-V multilib toolchains, we must specify -mabi and -march
options when linking guest/init.

Fixes: 2e99678314c2 ("riscv: Initial skeletal support")
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
---
 Makefile | 2 ++
 1 file changed, 2 insertions(+)

Comments

Andrew Jones Oct. 25, 2023, 1:42 p.m. UTC | #1 
On Mon, Sep 18, 2023 at 06:27:30PM +0530, Anup Patel wrote:
> For RISC-V multilib toolchains, we must specify -mabi and -march
> options when linking guest/init.
> 
> Fixes: 2e99678314c2 ("riscv: Initial skeletal support")
> Signed-off-by: Anup Patel <apatel@ventanamicro.com>
> ---
>  Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index acd5ffd..d84dc8e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -223,9 +223,11 @@ ifeq ($(ARCH),riscv)
>  	OBJS		+= riscv/aia.o
>  	ifeq ($(RISCV_XLEN),32)
>  		CFLAGS	+= -mabi=ilp32d -march=rv32gc
> +		GUEST_INIT_FLAGS += -mabi=ilp32d -march=rv32gc
>  	endif
>  	ifeq ($(RISCV_XLEN),64)
>  		CFLAGS	+= -mabi=lp64d -march=rv64gc
> +		GUEST_INIT_FLAGS += -mabi=lp64d -march=rv64gc
>  	endif
>  
>  	ARCH_WANT_LIBFDT := y
> -- 
> 2.34.1
>

Looks good and like something that could be posted independently of this
series.

Reviewed-by: Andrew Jones <ajones@ventanamicro.com>

Thanks,
drew
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index acd5ffd..d84dc8e 100644
--- a/Makefile
+++ b/Makefile
@@ -223,9 +223,11 @@  ifeq ($(ARCH),riscv)
 	OBJS		+= riscv/aia.o
 	ifeq ($(RISCV_XLEN),32)
 		CFLAGS	+= -mabi=ilp32d -march=rv32gc
+		GUEST_INIT_FLAGS += -mabi=ilp32d -march=rv32gc
 	endif
 	ifeq ($(RISCV_XLEN),64)
 		CFLAGS	+= -mabi=lp64d -march=rv64gc
+		GUEST_INIT_FLAGS += -mabi=lp64d -march=rv64gc
 	endif
 
 	ARCH_WANT_LIBFDT := y