diff mbox series

dt-bindings: regulator: dlg,da9210: Convert to json-schema

Message ID bfd1cf9d620a8229f5a5e62e6fe9e59c153d0830.1698051619.git.geert+renesas@glider.be
State Not Applicable, archived
Headers show
Series dt-bindings: regulator: dlg,da9210: Convert to json-schema | expand

Checks

Context Check Description
robh/checkpatch warning total: 0 errors, 2 warnings, 52 lines checked
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Geert Uytterhoeven Oct. 23, 2023, 9:04 a.m. UTC
Convert the Dialog Semiconductor DA9210 Multi-Phase 12A DC-DC Buck
Converter Device Tree binding documentation to json-schema.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 .../devicetree/bindings/regulator/da9210.txt  | 29 -----------
 .../bindings/regulator/dlg,da9210.yaml        | 52 +++++++++++++++++++
 2 files changed, 52 insertions(+), 29 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/regulator/da9210.txt
 create mode 100644 Documentation/devicetree/bindings/regulator/dlg,da9210.yaml

Comments

Conor Dooley Oct. 23, 2023, 4:18 p.m. UTC | #1
On Mon, Oct 23, 2023 at 11:04:45AM +0200, Geert Uytterhoeven wrote:
> Convert the Dialog Semiconductor DA9210 Multi-Phase 12A DC-DC Buck
> Converter Device Tree binding documentation to json-schema.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  .../devicetree/bindings/regulator/da9210.txt  | 29 -----------
>  .../bindings/regulator/dlg,da9210.yaml        | 52 +++++++++++++++++++
>  2 files changed, 52 insertions(+), 29 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/regulator/da9210.txt
>  create mode 100644 Documentation/devicetree/bindings/regulator/dlg,da9210.yaml
> 
> diff --git a/Documentation/devicetree/bindings/regulator/da9210.txt b/Documentation/devicetree/bindings/regulator/da9210.txt
> deleted file mode 100644
> index 58065ca9e3b46892..0000000000000000
> --- a/Documentation/devicetree/bindings/regulator/da9210.txt
> +++ /dev/null
> @@ -1,29 +0,0 @@
> -* Dialog Semiconductor DA9210 Multi-phase 12A DCDC BUCK Converter
> -
> -Required properties:
> -
> -- compatible:	must be "dlg,da9210"
> -- reg:		the i2c slave address of the regulator. It should be 0x68.
> -
> -Optional properties:
> -
> -- interrupts:	a reference to the DA9210 interrupt, if available.
> -
> -Any standard regulator properties can be used to configure the single da9210
> -DCDC.
> -
> -Example:
> -
> -	da9210@68 {
> -		compatible = "dlg,da9210";
> -		reg = <0x68>;
> -
> -		interrupt-parent = <...>;
> -		interrupts = <...>;
> -
> -		regulator-min-microvolt = <300000>;
> -		regulator-max-microvolt = <1570000>;
> -		regulator-min-microamp = <1600000>;
> -		regulator-max-microamp = <4600000>;
> -		regulator-boot-on;
> -	};
> diff --git a/Documentation/devicetree/bindings/regulator/dlg,da9210.yaml b/Documentation/devicetree/bindings/regulator/dlg,da9210.yaml
> new file mode 100644
> index 0000000000000000..81f23de36de4c2f1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/dlg,da9210.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/dlg,da9210.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Dialog Semiconductor DA9210 Multi-Phase 12A DC-DC Buck Converter
> +
> +maintainers:
> +  - Support Opensource <support.opensource@diasemi.com>

This should really be a person... Does your work with Renesas cover you
for dialog stuff too?

Otherwise,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> +
> +allOf:
> +  - $ref: regulator.yaml#
> +
> +properties:
> +  compatible:
> +    const: dlg,da9210
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        regulator@68 {
> +            compatible = "dlg,da9210";
> +            reg = <0x68>;
> +
> +            interrupt-parent = <&irqc0>;
> +            interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> +
> +            regulator-min-microvolt = <300000>;
> +            regulator-max-microvolt = <1570000>;
> +            regulator-min-microamp = <1600000>;
> +            regulator-max-microamp = <4600000>;
> +            regulator-boot-on;
> +        };
> +    };
> -- 
> 2.34.1
>
Geert Uytterhoeven Oct. 23, 2023, 5:58 p.m. UTC | #2
Hi Conor,

CC David, Adam

On Mon, Oct 23, 2023 at 6:18 PM Conor Dooley <conor@kernel.org> wrote:
> On Mon, Oct 23, 2023 at 11:04:45AM +0200, Geert Uytterhoeven wrote:
> > Convert the Dialog Semiconductor DA9210 Multi-Phase 12A DC-DC Buck
> > Converter Device Tree binding documentation to json-schema.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/regulator/dlg,da9210.yaml
> > @@ -0,0 +1,52 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/regulator/dlg,da9210.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Dialog Semiconductor DA9210 Multi-Phase 12A DC-DC Buck Converter
> > +
> > +maintainers:
> > +  - Support Opensource <support.opensource@diasemi.com>
>
> This should really be a person... Does your work with Renesas cover you
> for dialog stuff too?

I'm not really into the PMICs department, only into making dtbs_check
for "my" DTS files clean ;-)
I hope one of the Dialog/Renesas PMIC people can point me to a better
address.  Steve Twiss sent a goodbye message to some kernel people
and lkml three years ago, but it is not on lore, as it contained HTML.

Ah, according to git log, David and Adam touched some of the files
lately, so perhaps they can help?

> Otherwise,
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks!

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Conor Dooley Oct. 24, 2023, 4:33 p.m. UTC | #3
On Mon, Oct 23, 2023 at 07:58:51PM +0200, Geert Uytterhoeven wrote:
> CC David, Adam
> 
> On Mon, Oct 23, 2023 at 6:18 PM Conor Dooley <conor@kernel.org> wrote:
> > On Mon, Oct 23, 2023 at 11:04:45AM +0200, Geert Uytterhoeven wrote:

> > > +maintainers:
> > > +  - Support Opensource <support.opensource@diasemi.com>
> >
> > This should really be a person... Does your work with Renesas cover you
> > for dialog stuff too?
> 
> I'm not really into the PMICs department, only into making dtbs_check
> for "my" DTS files clean ;-)
> I hope one of the Dialog/Renesas PMIC people can point me to a better
> address.  Steve Twiss sent a goodbye message to some kernel people
> and lkml three years ago, but it is not on lore, as it contained HTML.
> 
> Ah, according to git log, David and Adam touched some of the files
> lately, so perhaps they can help?

It'd be great if one of them could volunteer, aye. I do feel like I
recall seeing one of the folks involved with the dialog stuff in
mainline stepping down shortly after the merger though  :|
Mark Brown Oct. 24, 2023, 7:10 p.m. UTC | #4
On Mon, 23 Oct 2023 11:04:45 +0200, Geert Uytterhoeven wrote:
> Convert the Dialog Semiconductor DA9210 Multi-Phase 12A DC-DC Buck
> Converter Device Tree binding documentation to json-schema.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] dt-bindings: regulator: dlg,da9210: Convert to json-schema
      commit: 7a198e0d48167db90e50777aab5a83a74e351f71

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
DLG Adam Ward Nov. 1, 2023, 10:51 a.m. UTC | #5
On Tues, Oct 24, 2023 at 5:34 PM, Conor Dooley wrote:
> On Mon, Oct 23, 2023 at 07:58:51PM +0200, Geert Uytterhoeven wrote:
> > CC David, Adam
> > 
> > On Mon, Oct 23, 2023 at 6:18 PM Conor Dooley <conor@kernel.org> wrote:
> > > On Mon, Oct 23, 2023 at 11:04:45AM +0200, Geert Uytterhoeven wrote:
>
> > > > +maintainers:
> > > > +  - Support Opensource <support.opensource@diasemi.com>
> > >
> > > This should really be a person... Does your work with Renesas cover you
> > > for dialog stuff too?
> > 
> > I'm not really into the PMICs department, only into making dtbs_check
> > for "my" DTS files clean ;-)
> > I hope one of the Dialog/Renesas PMIC people can point me to a better
> > address.  Steve Twiss sent a goodbye message to some kernel people
> > and lkml three years ago, but it is not on lore, as it contained HTML.
> > 
> > Ah, according to git log, David and Adam touched some of the files
> > lately, so perhaps they can help?
>
> It'd be great if one of them could volunteer, aye. I do feel like I
> recall seeing one of the folks involved with the dialog stuff in
> mainline stepping down shortly after the merger though  :|

Yes, Adam Thomson also left the company, leaving PMIC experience/support rather thin.
The merger implied server changes, and the diasemi.com URL is likely to be end-of-lifed. 
Adam attempted to update MAINTAINERS with the sustainable mailing list address, but this was rejected.

I appreciate the desire for an accountable name, but it's not that clear-cut who may be able to pick up effort.
The mailing list was created as a backstop against employee churn/leave, so worth keeping - albeit updated.
We do have a new employee who is slowly getting familiar with various aspects, but Mr T left decade sized boots to fill!
At the risk of receiving every email twice, I suggest:

+maintainers:
+  - Atif Emre Ofluoglu <DLG-Atif.Ofluoglu.opensource@dm.renesas.com>
+  - Adam Ward <DLG-Adam.Ward.opensource@dm.renesas.com>
+  - DLG Support Opensource <DLG-Support.Opensource@lm.renesas.com>

But, frankly, having a specific name to nag will not increase resources nor adjust priorities; the increase in visibility is illusory.
I'd rather keep to just the mailing list, but this is the second time it's been rebuffed, so...

I'll try to get the above into MAINTAINERS for PMICs (splitting off Audio products to David Rau), once I have time to get my Linux/LKML hat properly on again.
Right now I'm fighting other fires...

Anyway, thanks Conor for taking this on, and sorry for the slow response.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/regulator/da9210.txt b/Documentation/devicetree/bindings/regulator/da9210.txt
deleted file mode 100644
index 58065ca9e3b46892..0000000000000000
--- a/Documentation/devicetree/bindings/regulator/da9210.txt
+++ /dev/null
@@ -1,29 +0,0 @@ 
-* Dialog Semiconductor DA9210 Multi-phase 12A DCDC BUCK Converter
-
-Required properties:
-
-- compatible:	must be "dlg,da9210"
-- reg:		the i2c slave address of the regulator. It should be 0x68.
-
-Optional properties:
-
-- interrupts:	a reference to the DA9210 interrupt, if available.
-
-Any standard regulator properties can be used to configure the single da9210
-DCDC.
-
-Example:
-
-	da9210@68 {
-		compatible = "dlg,da9210";
-		reg = <0x68>;
-
-		interrupt-parent = <...>;
-		interrupts = <...>;
-
-		regulator-min-microvolt = <300000>;
-		regulator-max-microvolt = <1570000>;
-		regulator-min-microamp = <1600000>;
-		regulator-max-microamp = <4600000>;
-		regulator-boot-on;
-	};
diff --git a/Documentation/devicetree/bindings/regulator/dlg,da9210.yaml b/Documentation/devicetree/bindings/regulator/dlg,da9210.yaml
new file mode 100644
index 0000000000000000..81f23de36de4c2f1
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/dlg,da9210.yaml
@@ -0,0 +1,52 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/dlg,da9210.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Dialog Semiconductor DA9210 Multi-Phase 12A DC-DC Buck Converter
+
+maintainers:
+  - Support Opensource <support.opensource@diasemi.com>
+
+allOf:
+  - $ref: regulator.yaml#
+
+properties:
+  compatible:
+    const: dlg,da9210
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        regulator@68 {
+            compatible = "dlg,da9210";
+            reg = <0x68>;
+
+            interrupt-parent = <&irqc0>;
+            interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
+
+            regulator-min-microvolt = <300000>;
+            regulator-max-microvolt = <1570000>;
+            regulator-min-microamp = <1600000>;
+            regulator-max-microamp = <4600000>;
+            regulator-boot-on;
+        };
+    };