| Message ID | 20231010174138.1888396-2-megi@xff.cz |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Add support for poweroff via RK806 PMIC | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Tue, 10 Oct 2023 19:41:16 +0200, Ondřej Jirman wrote: > From: Ondrej Jirman <megi@xff.cz> > > Deprecate support for this property in favor of standard > system-power-controller one. > > Signed-off-by: Ondrej Jirman <megi@xff.cz> > --- > Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml | 3 +++ > Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml | 3 +++ > Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml | 3 +++ > Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 3 +++ > Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml | 3 +++ > 5 files changed, 15 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
On Tue, 10 Oct 2023, Ondřej Jirman wrote: > From: Ondrej Jirman <megi@xff.cz> > > Deprecate support for this property in favor of standard > system-power-controller one. > > Signed-off-by: Ondrej Jirman <megi@xff.cz> > --- > Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml | 3 +++ > Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml | 3 +++ > Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml | 3 +++ > Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 3 +++ > Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml | 3 +++ > 5 files changed, 15 insertions(+) I don't see anything wrong with it. It would be nice to have a DT Ack though.
On 19/10/2023 12:29, Lee Jones wrote: > On Tue, 10 Oct 2023, Ondřej Jirman wrote: > >> From: Ondrej Jirman <megi@xff.cz> >> >> Deprecate support for this property in favor of standard >> system-power-controller one. >> >> Signed-off-by: Ondrej Jirman <megi@xff.cz> >> --- >> Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml | 3 +++ >> Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml | 3 +++ >> Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml | 3 +++ >> Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 3 +++ >> Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml | 3 +++ >> 5 files changed, 15 insertions(+) > > I don't see anything wrong with it. > > It would be nice to have a DT Ack though. Rob gave review on 12th Oct. Best regards, Krzysztof
On Thu, 19 Oct 2023, Krzysztof Kozlowski wrote: > On 19/10/2023 12:29, Lee Jones wrote: > > On Tue, 10 Oct 2023, Ondřej Jirman wrote: > > > >> From: Ondrej Jirman <megi@xff.cz> > >> > >> Deprecate support for this property in favor of standard > >> system-power-controller one. > >> > >> Signed-off-by: Ondrej Jirman <megi@xff.cz> > >> --- > >> Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml | 3 +++ > >> Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml | 3 +++ > >> Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml | 3 +++ > >> Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 3 +++ > >> Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml | 3 +++ > >> 5 files changed, 15 insertions(+) > > > > I don't see anything wrong with it. > > > > It would be nice to have a DT Ack though. > > Rob gave review on 12th Oct. This new version was submitted on the 10th Oct.
On Thu, Oct 19, 2023 at 02:50:32PM +0100, Lee Jones wrote: > > On Thu, 19 Oct 2023, Krzysztof Kozlowski wrote: > > > On 19/10/2023 12:29, Lee Jones wrote: > > > On Tue, 10 Oct 2023, Ondřej Jirman wrote: > > > > > >> From: Ondrej Jirman <megi@xff.cz> > > >> > > >> Deprecate support for this property in favor of standard > > >> system-power-controller one. > > >> > > >> Signed-off-by: Ondrej Jirman <megi@xff.cz> > > >> --- > > >> Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml | 3 +++ > > >> Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml | 3 +++ > > >> Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml | 3 +++ > > >> Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 3 +++ > > >> Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml | 3 +++ > > >> 5 files changed, 15 insertions(+) > > > > > > I don't see anything wrong with it. > > > > > > It would be nice to have a DT Ack though. > > > > Rob gave review on 12th Oct. > > This new version was submitted on the 10th Oct. https://lore.kernel.org/lkml/169714081353.1587536.2767150298208259976.robh@kernel.org/ > -- > Lee Jones [李琼斯]
On Thu, 19 Oct 2023, Ondřej Jirman wrote: > On Thu, Oct 19, 2023 at 02:50:32PM +0100, Lee Jones wrote: > > > > On Thu, 19 Oct 2023, Krzysztof Kozlowski wrote: > > > > > On 19/10/2023 12:29, Lee Jones wrote: > > > > On Tue, 10 Oct 2023, Ondřej Jirman wrote: > > > > > > > >> From: Ondrej Jirman <megi@xff.cz> > > > >> > > > >> Deprecate support for this property in favor of standard > > > >> system-power-controller one. > > > >> > > > >> Signed-off-by: Ondrej Jirman <megi@xff.cz> > > > >> --- > > > >> Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml | 3 +++ > > > >> Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml | 3 +++ > > > >> Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml | 3 +++ > > > >> Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 3 +++ > > > >> Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml | 3 +++ > > > >> 5 files changed, 15 insertions(+) > > > > > > > > I don't see anything wrong with it. > > > > > > > > It would be nice to have a DT Ack though. > > > > > > Rob gave review on 12th Oct. > > > > This new version was submitted on the 10th Oct. > > https://lore.kernel.org/lkml/169714081353.1587536.2767150298208259976.robh@kernel.org/ Please collect it up along with any other tags you've received and submit a [RESEND] set. Thanks.
diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml index 4992f71b6fc3..ec5e0fadef95 100644 --- a/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml @@ -42,9 +42,12 @@ properties: rockchip,system-power-controller: type: boolean + deprecated: true description: Telling whether or not this PMIC is controlling the system power. + system-power-controller: true + wakeup-source: type: boolean description: diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml index f5908fa01a61..f1364c66cd62 100644 --- a/Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml @@ -37,9 +37,12 @@ properties: rockchip,system-power-controller: type: boolean + deprecated: true description: Telling whether or not this PMIC is controlling the system power. + system-power-controller: true + wakeup-source: type: boolean description: diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml index 7fb849ac74a7..382bb2f87a54 100644 --- a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml @@ -37,9 +37,12 @@ properties: rockchip,system-power-controller: type: boolean + deprecated: true description: Telling whether or not this PMIC is controlling the system power. + system-power-controller: true + wakeup-source: type: boolean description: diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml index 269fb85b2027..92b1592e8942 100644 --- a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml @@ -38,9 +38,12 @@ properties: rockchip,system-power-controller: type: boolean + deprecated: true description: Telling whether or not this PMIC is controlling the system power. + system-power-controller: true + wakeup-source: type: boolean description: diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml index b57c4b005cf4..038804ff708d 100644 --- a/Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml @@ -37,9 +37,12 @@ properties: rockchip,system-power-controller: type: boolean + deprecated: true description: Telling whether or not this PMIC is controlling the system power. + system-power-controller: true + wakeup-source: type: boolean description: