Message ID | 20231017192517.13135-1-mps@arvanta.net |
---|---|
State | Superseded |
Delegated to: | Simon Glass |
Headers | show |
Series | cros_ec: spi: disable annoying key echo on console | expand |
On Tue, 17 Oct 2023 at 13:25, Milan P. Stanić <mps@arvanta.net> wrote: > > on Peach-pi console every key press is echoed with message > 'cros_ec_command: Returned status 1' > > this is not proper fix, just hack to disable this message > --- > drivers/misc/cros_ec_spi.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org> I thought a similar patch went in ages ago but I now see it was in cros_ec_i2c.c > > diff --git a/drivers/misc/cros_ec_spi.c b/drivers/misc/cros_ec_spi.c > index 001f0a85ca..7317f4b0f1 100644 > --- a/drivers/misc/cros_ec_spi.c > +++ b/drivers/misc/cros_ec_spi.c > @@ -151,7 +151,6 @@ int cros_ec_spi_command(struct udevice *udev, uint8_t cmd, int cmd_version, > > /* Response code is first byte of message */ > if (p[0] != EC_RES_SUCCESS) { > - printf("%s: Returned status %d\n", __func__, p[0]); log_debug() (without the __func__) would be better > return -(int)(p[0]); > } > > -- > 2.42.0 >
diff --git a/drivers/misc/cros_ec_spi.c b/drivers/misc/cros_ec_spi.c index 001f0a85ca..7317f4b0f1 100644 --- a/drivers/misc/cros_ec_spi.c +++ b/drivers/misc/cros_ec_spi.c @@ -151,7 +151,6 @@ int cros_ec_spi_command(struct udevice *udev, uint8_t cmd, int cmd_version, /* Response code is first byte of message */ if (p[0] != EC_RES_SUCCESS) { - printf("%s: Returned status %d\n", __func__, p[0]); return -(int)(p[0]); }