mbox series

[SRU,mantic:linux-gcp/aws,lunar:linux-gcp/aws,0/1] Kernel oops on 32-0bit kernels due to x86_cache_alignment initialization

Message ID 20231012153054.29953-1-john.cabaj@canonical.com
Headers show
Series Kernel oops on 32-0bit kernels due to x86_cache_alignment initialization | expand

Message

John Cabaj Oct. 12, 2023, 3:30 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2039191

[Impact]

* Kernel OOPS encountered on 32-bit kernels due to commit cd0e9ab from
  git://git.launchpad.net/~canonical-kernel/ubuntu/+source/linux-gcp/+git/lunar

[Fix]

* Clean cherry pick from linux-next, commit 3e3255265291

[Test Case]

* Compile tested
* Boot tested
* To be tested by Google

[Where things could go wrong]

* Low chance of regression, isolated fix slightly modifying when value becomes
  available.

Dave Hansen (1):
  x86/boot: Move x86_cache_alignment initialization to correct spot

 arch/x86/kernel/cpu/common.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Tim Gardner Oct. 12, 2023, 6:01 p.m. UTC | #1
On 10/12/23 9:30 AM, John Cabaj wrote:
> BugLink: https://bugs.launchpad.net/bugs/2039191
> 
> [Impact]
> 
> * Kernel OOPS encountered on 32-bit kernels due to commit cd0e9ab from
>    git://git.launchpad.net/~canonical-kernel/ubuntu/+source/linux-gcp/+git/lunar
> 
> [Fix]
> 
> * Clean cherry pick from linux-next, commit 3e3255265291
> 
> [Test Case]
> 
> * Compile tested
> * Boot tested
> * To be tested by Google
> 
> [Where things could go wrong]
> 
> * Low chance of regression, isolated fix slightly modifying when value becomes
>    available.
> 
> Dave Hansen (1):
>    x86/boot: Move x86_cache_alignment initialization to correct spot
> 
>   arch/x86/kernel/cpu/common.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Stefan Bader Oct. 13, 2023, 7:45 a.m. UTC | #2
On 12.10.23 17:30, John Cabaj wrote:
> BugLink: https://bugs.launchpad.net/bugs/2039191
> 
> [Impact]
> 
> * Kernel OOPS encountered on 32-bit kernels due to commit cd0e9ab from
>    git://git.launchpad.net/~canonical-kernel/ubuntu/+source/linux-gcp/+git/lunar
> 
> [Fix]
> 
> * Clean cherry pick from linux-next, commit 3e3255265291
> 
> [Test Case]
> 
> * Compile tested
> * Boot tested
> * To be tested by Google
> 
> [Where things could go wrong]
> 
> * Low chance of regression, isolated fix slightly modifying when value becomes
>    available.
> 
> Dave Hansen (1):
>    x86/boot: Move x86_cache_alignment initialization to correct spot
> 
>   arch/x86/kernel/cpu/common.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 

Small nitpick on the tracking bug. There are nominations for jammy 
without any classification which is confusing (does it need fixing there 
or not?). Also in general I would not leave states as new (put at least 
triaged there, I'd use in-progress for things I have submitted 
something) and importance unset (for the kernel I would say critical is 
something causing data loss or production systems to be unavailable, 
high is crashes and everything else medium). That might be adjusted 
before applying so:

Acked-by: Stefan Bader <stefan.bader@canonical.com>
John Cabaj Oct. 13, 2023, 2:52 p.m. UTC | #3
On 10/13/23 2:45 AM, Stefan Bader wrote:
> On 12.10.23 17:30, John Cabaj wrote:
>> BugLink: https://bugs.launchpad.net/bugs/2039191
>>
>> [Impact]
>>
>> * Kernel OOPS encountered on 32-bit kernels due to commit cd0e9ab from
>>    git://git.launchpad.net/~canonical-kernel/ubuntu/+source/linux-gcp/+git/lunar
>>
>> [Fix]
>>
>> * Clean cherry pick from linux-next, commit 3e3255265291
>>
>> [Test Case]
>>
>> * Compile tested
>> * Boot tested
>> * To be tested by Google
>>
>> [Where things could go wrong]
>>
>> * Low chance of regression, isolated fix slightly modifying when value becomes
>>    available.
>>
>> Dave Hansen (1):
>>    x86/boot: Move x86_cache_alignment initialization to correct spot
>>
>>   arch/x86/kernel/cpu/common.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
> 
> Small nitpick on the tracking bug. There are nominations for jammy without any classification which is confusing (does it need fixing there or not?). Also in general I would not leave states as new (put at least triaged there, I'd use in-progress for things I have submitted something) and importance unset (for the kernel I would say critical is something causing data loss or production systems to be unavailable, high is crashes and everything else medium). That might be adjusted before applying so:
> 

As jammy:linux-gcp-6.2 and jammy:linux-aws-6.2 will be getting the patch via lunar:linux-gcp and lunar:linux-aws respectively, I'll remove from the LP bug.


Thanks,
John

> Acked-by: Stefan Bader <stefan.bader@canonical.com>
John Cabaj Oct. 13, 2023, 4:27 p.m. UTC | #4
On 10/12/23 10:30 AM, John Cabaj wrote:
> BugLink: https://bugs.launchpad.net/bugs/2039191
> 
> [Impact]
> 
> * Kernel OOPS encountered on 32-bit kernels due to commit cd0e9ab from
>   git://git.launchpad.net/~canonical-kernel/ubuntu/+source/linux-gcp/+git/lunar
> 
> [Fix]
> 
> * Clean cherry pick from linux-next, commit 3e3255265291
> 
> [Test Case]
> 
> * Compile tested
> * Boot tested
> * To be tested by Google
> 
> [Where things could go wrong]
> 
> * Low chance of regression, isolated fix slightly modifying when value becomes
>   available.
> 
> Dave Hansen (1):
>   x86/boot: Move x86_cache_alignment initialization to correct spot
> 
>  arch/x86/kernel/cpu/common.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

Applied to mantic:linux-gcp, lunar:linux-gcp, mantic:linux-aws, and lunar:linux-aws master-next branches.


Thanks,
John