mbox series

[0/3] Cleanup tst_ioctl.c, libswap.c

Message ID 20231011160822.578637-1-pvorel@suse.cz
Headers show
Series Cleanup tst_ioctl.c, libswap.c | expand

Message

Petr Vorel Oct. 11, 2023, 4:08 p.m. UTC 
Hi,

this is somehow related to #1091 [1], but independent on it.

I also wonder if we should move tst_fibmap() out of lib/tst_ioctl.c
(it's the only function there) somewhere. include/tst_fs.h is used
several files, I wonder if there should be lib/tst_fs.c.

Maybe not all C files which use include/tst_fs.h should be merged in it,
but some of them contain only single function (e.g. lib/tst_fs_has_free.c).
Is there any benefit to have that separate? Size? In the end we link libltp.a
to every test binary (unfortunately). I also don't think that for
readability purposes of the sources we need 5 C files in lib/ which use
tst_test.h.

Kind regards,
Petr

[1] https://github.com/linux-test-project/ltp/issues/1091

Petr Vorel (3):
  tst_ioctl: Cleanup the code
  tst_fs.h: Improve tst_fibmap() doc
  libltpswap: TCONF on EPERM

 include/tst_fs.h          |  5 ++++-
 lib/tst_ioctl.c           | 18 ++++--------------
 libs/libltpswap/libswap.c | 10 +++++++---
 3 files changed, 15 insertions(+), 18 deletions(-)

Comments

Marius Kittler Oct. 11, 2023, 4:18 p.m. UTC | #1 
LGTM

Reviewed-by: Marius Kittler <mkittler@suse.de>