mbox series

[linux,dev-6.5,0/4] ARM: dts: aspeed: p10bmc: Add fan controller properties

Message ID 20231006172735.420566-1-eajames@linux.ibm.com
Headers show
Series ARM: dts: aspeed: p10bmc: Add fan controller properties | expand

Message

Eddie James Oct. 6, 2023, 5:27 p.m. UTC
Now that the max31785 driver can parse the relevant properties, update
the device trees with the necessary properties.

Eddie James (4):
  ARM: dts: aspeed: Rainier: Add fan controller properties
  ARM: dts: aspeed: Everest: Add fan controller properties
  ARM: dts: aspeed: Bonnell: Add fan controller properties
  ARM: dts: aspeed: Rainier 4U: Delete fan dual-tach properties

 .../dts/aspeed/aspeed-bmc-ibm-bonnell.dts     | 14 +++++++
 .../dts/aspeed/aspeed-bmc-ibm-everest.dts     | 28 +++++++++++++
 .../dts/aspeed/aspeed-bmc-ibm-rainier-4u.dts  | 24 +++++++++++
 .../dts/aspeed/aspeed-bmc-ibm-rainier.dts     | 42 +++++++++++++++++++
 4 files changed, 108 insertions(+)

Comments

Ninad Palsule Oct. 6, 2023, 6:24 p.m. UTC | #1
On 10/6/23 12:27, Eddie James wrote:
> Now that the max31785 driver can parse the relevant properties, update
> the device trees with the necessary properties.
>
> Eddie James (4):
>    ARM: dts: aspeed: Rainier: Add fan controller properties
>    ARM: dts: aspeed: Everest: Add fan controller properties
>    ARM: dts: aspeed: Bonnell: Add fan controller properties
>    ARM: dts: aspeed: Rainier 4U: Delete fan dual-tach properties
>
>   .../dts/aspeed/aspeed-bmc-ibm-bonnell.dts     | 14 +++++++
>   .../dts/aspeed/aspeed-bmc-ibm-everest.dts     | 28 +++++++++++++
>   .../dts/aspeed/aspeed-bmc-ibm-rainier-4u.dts  | 24 +++++++++++
>   .../dts/aspeed/aspeed-bmc-ibm-rainier.dts     | 42 +++++++++++++++++++
>   4 files changed, 108 insertions(+)
>
Reviewed-by: Ninad Palsule <ninad@linux.ibm.com>
Joel Stanley Oct. 11, 2023, 1:46 a.m. UTC | #2
On Sat, 7 Oct 2023 at 03:58, Eddie James <eajames@linux.ibm.com> wrote:
>
> Now that the max31785 driver can parse the relevant properties, update

I can't see a patch that adds that support. Can you point it out?

Cheers,

Joel

> the device trees with the necessary properties.
>
> Eddie James (4):
>   ARM: dts: aspeed: Rainier: Add fan controller properties
>   ARM: dts: aspeed: Everest: Add fan controller properties
>   ARM: dts: aspeed: Bonnell: Add fan controller properties
>   ARM: dts: aspeed: Rainier 4U: Delete fan dual-tach properties
>
>  .../dts/aspeed/aspeed-bmc-ibm-bonnell.dts     | 14 +++++++
>  .../dts/aspeed/aspeed-bmc-ibm-everest.dts     | 28 +++++++++++++
>  .../dts/aspeed/aspeed-bmc-ibm-rainier-4u.dts  | 24 +++++++++++
>  .../dts/aspeed/aspeed-bmc-ibm-rainier.dts     | 42 +++++++++++++++++++
>  4 files changed, 108 insertions(+)
>
> --
> 2.39.3
>
Eddie James Oct. 11, 2023, 1:43 p.m. UTC | #3
On 10/10/23 20:46, Joel Stanley wrote:
> On Sat, 7 Oct 2023 at 03:58, Eddie James <eajames@linux.ibm.com> wrote:
>> Now that the max31785 driver can parse the relevant properties, update
> I can't see a patch that adds that support. Can you point it out?


Sure, 
https://github.com/openbmc/linux/commit/ebd863b5c2a2f5bc3ee26fadf39a213a2cdc6efb


Thanks,

Eddie


>
> Cheers,
>
> Joel
>
>> the device trees with the necessary properties.
>>
>> Eddie James (4):
>>    ARM: dts: aspeed: Rainier: Add fan controller properties
>>    ARM: dts: aspeed: Everest: Add fan controller properties
>>    ARM: dts: aspeed: Bonnell: Add fan controller properties
>>    ARM: dts: aspeed: Rainier 4U: Delete fan dual-tach properties
>>
>>   .../dts/aspeed/aspeed-bmc-ibm-bonnell.dts     | 14 +++++++
>>   .../dts/aspeed/aspeed-bmc-ibm-everest.dts     | 28 +++++++++++++
>>   .../dts/aspeed/aspeed-bmc-ibm-rainier-4u.dts  | 24 +++++++++++
>>   .../dts/aspeed/aspeed-bmc-ibm-rainier.dts     | 42 +++++++++++++++++++
>>   4 files changed, 108 insertions(+)
>>
>> --
>> 2.39.3
>>
Joel Stanley Oct. 13, 2023, 1:19 a.m. UTC | #4
On Thu, 12 Oct 2023 at 00:13, Eddie James <eajames@linux.ibm.com> wrote:
>
>
> On 10/10/23 20:46, Joel Stanley wrote:
> > On Sat, 7 Oct 2023 at 03:58, Eddie James <eajames@linux.ibm.com> wrote:
> >> Now that the max31785 driver can parse the relevant properties, update
> > I can't see a patch that adds that support. Can you point it out?
>
>
> Sure,
> https://github.com/openbmc/linux/commit/ebd863b5c2a2f5bc3ee26fadf39a213a2cdc6efb

Right, that's the openbmc downstream patch. We would like to see that
patch go upstream. Are you able to work on that?