diff mbox series

pwm: brcmstb: Checked clk_prepare_enable() return value

Message ID 20231005164728.1846726-1-florian.fainelli@broadcom.com
State Accepted
Headers show
Series pwm: brcmstb: Checked clk_prepare_enable() return value | expand

Commit Message

Florian Fainelli Oct. 5, 2023, 4:47 p.m. UTC
Check the clk_prepare_enable() return value and propagate it.

Suggested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
This change depends upon:

https://lore.kernel.org/all/20231004175414.1738475-1-florian.fainelli@broadcom.com/

 drivers/pwm/pwm-brcmstb.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Uwe Kleine-König Oct. 9, 2023, 10:01 a.m. UTC | #1
On Thu, Oct 05, 2023 at 09:47:27AM -0700, Florian Fainelli wrote:
> Check the clk_prepare_enable() return value and propagate it.
> 
> Suggested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>

Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Thanks
Uwe
Thierry Reding Oct. 12, 2023, 1:55 p.m. UTC | #2
On Thu, 05 Oct 2023 09:47:27 -0700, Florian Fainelli wrote:
> Check the clk_prepare_enable() return value and propagate it.
> 
> 

Applied, thanks!

[1/1] pwm: brcmstb: Checked clk_prepare_enable() return value
      commit: d559f11591900a283b2a0b1087d68992e6c2062a

Best regards,
diff mbox series

Patch

diff --git a/drivers/pwm/pwm-brcmstb.c b/drivers/pwm/pwm-brcmstb.c
index a7d529bf76ad..de9cbda2e4ff 100644
--- a/drivers/pwm/pwm-brcmstb.c
+++ b/drivers/pwm/pwm-brcmstb.c
@@ -297,9 +297,7 @@  static int brcmstb_pwm_resume(struct device *dev)
 {
 	struct brcmstb_pwm *p = dev_get_drvdata(dev);
 
-	clk_prepare_enable(p->clk);
-
-	return 0;
+	return clk_prepare_enable(p->clk);
 }
 #endif