diff mbox series

dt-bindings: mfd: rk806: Allow rockchip,system-power-controller property

Message ID 20231008142118.1174090-1-megi@xff.cz
State Superseded, archived
Headers show
Series dt-bindings: mfd: rk806: Allow rockchip,system-power-controller property | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Ondřej Jirman Oct. 8, 2023, 2:21 p.m. UTC
From: Ondrej Jirman <megi@xff.cz>

Declare support for this property.

Signed-off-by: Ondrej Jirman <megi@xff.cz>
---
 Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Sebastian Reichel Oct. 8, 2023, 6:55 p.m. UTC | #1
Hi,

On Sun, Oct 08, 2023 at 04:21:17PM +0200, Ondřej Jirman wrote:
> From: Ondrej Jirman <megi@xff.cz>
> 
> Declare support for this property.
> 
> Signed-off-by: Ondrej Jirman <megi@xff.cz>
> ---

This is missing the accompanying driver change. Right now
this property does nothing for rk806.

-- Sebastian

>  Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml
> index cf2500f2e9a0..e8c9f17f6ea8 100644
> --- a/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml
> @@ -29,6 +29,11 @@ properties:
>    '#gpio-cells':
>      const: 2
>  
> +  rockchip,system-power-controller:
> +    type: boolean
> +    description:
> +      Telling whether or not this PMIC is controlling the system power.
> +
>    vcc1-supply:
>      description:
>        The input supply for dcdc-reg1.
> -- 
> 2.42.0
>
Ondřej Jirman Oct. 8, 2023, 7:01 p.m. UTC | #2
On Sun, Oct 08, 2023 at 08:55:59PM +0200, Sebastian Reichel wrote:
> Hi,
> 
> On Sun, Oct 08, 2023 at 04:21:17PM +0200, Ondřej Jirman wrote:
> > From: Ondrej Jirman <megi@xff.cz>
> > 
> > Declare support for this property.
> > 
> > Signed-off-by: Ondrej Jirman <megi@xff.cz>
> > ---
> 
> This is missing the accompanying driver change. Right now
> this property does nothing for rk806.

Ah, I assumed it does, but looks like it's just implemented in my tree:

https://megous.com/git/linux/commit/?h=ppp-drivers-6.6&id=6394918f339fda0b89f63faac4c4fe162d5ace42

I'll re-send with the driver patch.

Thanks and regards,
	o.


> -- Sebastian
> 
> >  Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml
> > index cf2500f2e9a0..e8c9f17f6ea8 100644
> > --- a/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml
> > @@ -29,6 +29,11 @@ properties:
> >    '#gpio-cells':
> >      const: 2
> >  
> > +  rockchip,system-power-controller:
> > +    type: boolean
> > +    description:
> > +      Telling whether or not this PMIC is controlling the system power.
> > +
> >    vcc1-supply:
> >      description:
> >        The input supply for dcdc-reg1.
> > -- 
> > 2.42.0
> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml
index cf2500f2e9a0..e8c9f17f6ea8 100644
--- a/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml
+++ b/Documentation/devicetree/bindings/mfd/rockchip,rk806.yaml
@@ -29,6 +29,11 @@  properties:
   '#gpio-cells':
     const: 2
 
+  rockchip,system-power-controller:
+    type: boolean
+    description:
+      Telling whether or not this PMIC is controlling the system power.
+
   vcc1-supply:
     description:
       The input supply for dcdc-reg1.