diff mbox series

[2/2] dm: adc: imx93-adc depends on ADC (fix boot)

Message ID 20231004090810.28923-3-sebastien.szymanski@armadeus.com
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show
Series Fixes i.MX93 11x11 EVK boot failures | expand

Commit Message

Sébastien Szymanski Oct. 4, 2023, 9:08 a.m. UTC
The i.MX93 11x11 EVK fails to boot with following error:

 Model: NXP i.MX93 11X11 EVK board
 DRAM:  2 GiB
 Error binding driver 'imx93-adc': -96
 Some drivers failed to bind
 Error binding driver 'simple_bus': -96
 Some drivers failed to bind
 Error binding driver 'simple_bus': -96
 Some drivers failed to bind
 initcall sequence 00000000fffb8f28 failed at call 000000008021e0d4 (err=-96)
 ### ERROR ### Please RESET the board ###

That's because since commit e7ff54d96303 ("imx93_evk: defconfig: add adc
support") CONFIG_ADC_IMX93 is enabled but CONFIG_ADC is not.
Fix this by enabling CONFIG_ADC in imx93_11x11_evk_defconfig.

Make sure this situation won't happen again in future i.MX93 defconfig by
making CONFIG_ADC_IMX93 depend on CONFIG_ADC.

Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
---
 configs/imx93_11x11_evk_defconfig | 1 +
 drivers/adc/Kconfig               | 1 +
 2 files changed, 2 insertions(+)

Comments

Fabio Estevam Oct. 7, 2023, 12:55 p.m. UTC | #1
On Wed, Oct 4, 2023 at 6:09 AM Sébastien Szymanski
<sebastien.szymanski@armadeus.com> wrote:
>
> The i.MX93 11x11 EVK fails to boot with following error:
>
>  Model: NXP i.MX93 11X11 EVK board
>  DRAM:  2 GiB
>  Error binding driver 'imx93-adc': -96
>  Some drivers failed to bind
>  Error binding driver 'simple_bus': -96
>  Some drivers failed to bind
>  Error binding driver 'simple_bus': -96
>  Some drivers failed to bind
>  initcall sequence 00000000fffb8f28 failed at call 000000008021e0d4 (err=-96)
>  ### ERROR ### Please RESET the board ###
>
> That's because since commit e7ff54d96303 ("imx93_evk: defconfig: add adc
> support") CONFIG_ADC_IMX93 is enabled but CONFIG_ADC is not.
> Fix this by enabling CONFIG_ADC in imx93_11x11_evk_defconfig.
>
> Make sure this situation won't happen again in future i.MX93 defconfig by
> making CONFIG_ADC_IMX93 depend on CONFIG_ADC.
>
> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>
diff mbox series

Patch

diff --git a/configs/imx93_11x11_evk_defconfig b/configs/imx93_11x11_evk_defconfig
index 89130c437d6d..7a7978c280a5 100644
--- a/configs/imx93_11x11_evk_defconfig
+++ b/configs/imx93_11x11_evk_defconfig
@@ -81,6 +81,7 @@  CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_SPL_DM=y
 CONFIG_REGMAP=y
 CONFIG_SYSCON=y
+CONFIG_ADC=y
 CONFIG_ADC_IMX93=y
 CONFIG_CPU=y
 CONFIG_CPU_IMX=y
diff --git a/drivers/adc/Kconfig b/drivers/adc/Kconfig
index 4336732dee56..a01d73846b74 100644
--- a/drivers/adc/Kconfig
+++ b/drivers/adc/Kconfig
@@ -66,6 +66,7 @@  config STM32_ADC
 
 config ADC_IMX93
 	bool "Enable NXP IMX93 ADC driver"
+	depends on ADC
 	help
 	  This enables basic driver for NXP IMX93 ADC.
 	  It provides: