Message ID | 1326454935-30817-1-git-send-email-david.henningsson@canonical.com |
---|---|
State | New |
Headers | show |
On 13.01.2012 12:42, David Henningsson wrote: > Several users have reported "choppy" audio under the 3.2 kernel, > and that changing position_fix to 1 has resolved their problem. > The chip is an nVidia Corporation MCP89 High Definition Audio, > [10de:0d94] (rev a2). > > Cc: stable@kernel.org (v3.2+) > BugLink: https://bugs.launchpad.net/bugs/909419 > Signed-off-by: David Henningsson <david.henningsson@canonical.com> > Signed-off-by: Takashi Iwai <tiwai@suse.de> > (cherry picked from commit b01de4fb40137fbda7530550ff0cd37171dafb0c, > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git) > --- > > * Several macbooks (with the same ID, see duplicates to bug 909419) > seem to be hitting this one, so it might be worth picking it for > our next upload, instead of waiting for stable. > > sound/pci/hda/hda_intel.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > index c2f79e6..5b2b75b 100644 > --- a/sound/pci/hda/hda_intel.c > +++ b/sound/pci/hda/hda_intel.c > @@ -2509,6 +2509,7 @@ static struct snd_pci_quirk position_fix_list[] __devinitdata = { > SND_PCI_QUIRK(0x1043, 0x81e7, "ASUS M2V", POS_FIX_LPIB), > SND_PCI_QUIRK(0x1043, 0x83ce, "ASUS 1101HA", POS_FIX_LPIB), > SND_PCI_QUIRK(0x104d, 0x9069, "Sony VPCS11V9E", POS_FIX_LPIB), > + SND_PCI_QUIRK(0x10de, 0xcb89, "Macbook Pro 7,1", POS_FIX_LPIB), > SND_PCI_QUIRK(0x1297, 0x3166, "Shuttle", POS_FIX_LPIB), > SND_PCI_QUIRK(0x1458, 0xa022, "ga-ma770-ud3", POS_FIX_LPIB), > SND_PCI_QUIRK(0x1462, 0x1002, "MSI Wind U115", POS_FIX_LPIB), Patch looks ok and is upstream and actually already queued up for the next stable update. I guess that will happen soon as well. -Stefan
On Fri, Jan 13, 2012 at 12:42:14PM +0100, David Henningsson wrote: > Several users have reported "choppy" audio under the 3.2 kernel, > and that changing position_fix to 1 has resolved their problem. > The chip is an nVidia Corporation MCP89 High Definition Audio, > [10de:0d94] (rev a2). > > Cc: stable@kernel.org (v3.2+) > BugLink: https://bugs.launchpad.net/bugs/909419 > Signed-off-by: David Henningsson <david.henningsson@canonical.com> > Signed-off-by: Takashi Iwai <tiwai@suse.de> > (cherry picked from commit b01de4fb40137fbda7530550ff0cd37171dafb0c, > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git) > --- > > * Several macbooks (with the same ID, see duplicates to bug 909419) > seem to be hitting this one, so it might be worth picking it for > our next upload, instead of waiting for stable. > > sound/pci/hda/hda_intel.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > index c2f79e6..5b2b75b 100644 > --- a/sound/pci/hda/hda_intel.c > +++ b/sound/pci/hda/hda_intel.c > @@ -2509,6 +2509,7 @@ static struct snd_pci_quirk position_fix_list[] __devinitdata = { > SND_PCI_QUIRK(0x1043, 0x81e7, "ASUS M2V", POS_FIX_LPIB), > SND_PCI_QUIRK(0x1043, 0x83ce, "ASUS 1101HA", POS_FIX_LPIB), > SND_PCI_QUIRK(0x104d, 0x9069, "Sony VPCS11V9E", POS_FIX_LPIB), > + SND_PCI_QUIRK(0x10de, 0xcb89, "Macbook Pro 7,1", POS_FIX_LPIB), > SND_PCI_QUIRK(0x1297, 0x3166, "Shuttle", POS_FIX_LPIB), > SND_PCI_QUIRK(0x1458, 0xa022, "ga-ma770-ud3", POS_FIX_LPIB), > SND_PCI_QUIRK(0x1462, 0x1002, "MSI Wind U115", POS_FIX_LPIB), As this is so small and we are so near to the next milestone it would probabally be good to pull this in as a pre-stable patch. Acked-by: Andy Whitcroft <apw@canonical.com> -apw
This has also hit mainline so updated the commentary to match. Applied to Precise. -apw
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index c2f79e6..5b2b75b 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2509,6 +2509,7 @@ static struct snd_pci_quirk position_fix_list[] __devinitdata = { SND_PCI_QUIRK(0x1043, 0x81e7, "ASUS M2V", POS_FIX_LPIB), SND_PCI_QUIRK(0x1043, 0x83ce, "ASUS 1101HA", POS_FIX_LPIB), SND_PCI_QUIRK(0x104d, 0x9069, "Sony VPCS11V9E", POS_FIX_LPIB), + SND_PCI_QUIRK(0x10de, 0xcb89, "Macbook Pro 7,1", POS_FIX_LPIB), SND_PCI_QUIRK(0x1297, 0x3166, "Shuttle", POS_FIX_LPIB), SND_PCI_QUIRK(0x1458, 0xa022, "ga-ma770-ud3", POS_FIX_LPIB), SND_PCI_QUIRK(0x1462, 0x1002, "MSI Wind U115", POS_FIX_LPIB),