| Message ID | 20231004083124.29206-1-jmeng@redhat.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [ovs-dev,1/3] netdev-dpdk: Document status options for VF MAC address. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | warning | apply and check: warning |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
On Wed, Oct 04, 2023 at 10:31:25AM +0200, jmeng@redhat.com wrote: > From: Jakob Meng <code@jakobmeng.de> > > The status options pci-vendor_id and pci-device_id for dpdk netdevs > have been replaced by bus_info. This patch updates the documentation > in vswitchd/vswitch.xml accordingly. > > Fixes: a77c7796f23a ("dpdk: Update to use v22.11.1.") Reviewed-by: Simon Horman <horms@kernel.org>
On Wed, Oct 04, 2023 at 11:28:38AM +0200, Simon Horman wrote: > On Wed, Oct 04, 2023 at 10:31:25AM +0200, jmeng@redhat.com wrote: > > From: Jakob Meng <code@jakobmeng.de> > > > > The status options pci-vendor_id and pci-device_id for dpdk netdevs > > have been replaced by bus_info. This patch updates the documentation > > in vswitchd/vswitch.xml accordingly. > > > > Fixes: a77c7796f23a ("dpdk: Update to use v22.11.1.") > > Reviewed-by: Simon Horman <horms@kernel.org> Sorry, I meant, Acked-by: Simon Horman <horms@ovn.org>
Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Jakob Meng <code@jakobmeng.de> needs to sign off. Lines checked: 40, Warnings: 0, Errors: 1 Please check this out. If you feel there has been an error, please email aconole@redhat.com Thanks, 0-day Robot
On 04.10.23 10:31, jmeng@redhat.com wrote: > From: Jakob Meng <code@jakobmeng.de> > > The status options pci-vendor_id and pci-device_id for dpdk netdevs > have been replaced by bus_info. This patch updates the documentation > in vswitchd/vswitch.xml accordingly. > > Fixes: a77c7796f23a ("dpdk: Update to use v22.11.1.") > --- > vswitchd/vswitch.xml | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml > index 797fb05bf..006d1e6a4 100644 > --- a/vswitchd/vswitch.xml > +++ b/vswitchd/vswitch.xml > @@ -3797,12 +3797,9 @@ ovs-vsctl add-port br0 p0 -- set Interface p0 type=patch options:peer=p1 \ > Interface description string. > </column> > > - <column name="status" key="pci-vendor_id"> > - Vendor ID of PCI device. > - </column> > - > - <column name="status" key="pci-device_id"> > - Device ID of PCI device. > + <column name="status" key="bus_info"> > + Bus name and bus info such as Vendor ID and Device ID of PCI > + device. > </column> > > <column name="status" key="dpdk-vf-mac"> Signed-off-by: Jakob Meng <code@jakobmeng.de>
On 4 Oct 2023, at 10:31, jmeng@redhat.com wrote: > From: Jakob Meng <code@jakobmeng.de> > > The status options pci-vendor_id and pci-device_id for dpdk netdevs > have been replaced by bus_info. This patch updates the documentation > in vswitchd/vswitch.xml accordingly. > > Fixes: a77c7796f23a ("dpdk: Update to use v22.11.1.") Thanks for fixing the documentation, however I think the commit message should somehow state this is related to the documentation. //Eelco > --- > vswitchd/vswitch.xml | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml > index 797fb05bf..006d1e6a4 100644 > --- a/vswitchd/vswitch.xml > +++ b/vswitchd/vswitch.xml > @@ -3797,12 +3797,9 @@ ovs-vsctl add-port br0 p0 -- set Interface p0 type=patch options:peer=p1 \ > Interface description string. > </column> > > - <column name="status" key="pci-vendor_id"> > - Vendor ID of PCI device. > - </column> > - > - <column name="status" key="pci-device_id"> > - Device ID of PCI device. > + <column name="status" key="bus_info"> > + Bus name and bus info such as Vendor ID and Device ID of PCI > + device. > </column> > > <column name="status" key="dpdk-vf-mac"> > -- > 2.39.2 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 05/10/2023 13:52, Eelco Chaudron wrote: > > > On 4 Oct 2023, at 10:31, jmeng@redhat.com wrote: > >> From: Jakob Meng <code@jakobmeng.de> >> >> The status options pci-vendor_id and pci-device_id for dpdk netdevs >> have been replaced by bus_info. This patch updates the documentation >> in vswitchd/vswitch.xml accordingly. >> >> Fixes: a77c7796f23a ("dpdk: Update to use v22.11.1.") > > Thanks for fixing the documentation, however I think the commit message should somehow state this is related to the documentation. > Message it probably ok, but yeah title might mislead so should mention docs. Acked-by: Kevin Traynor <ktraynor@redhat.com> > //Eelco > >> --- >> vswitchd/vswitch.xml | 9 +++------ >> 1 file changed, 3 insertions(+), 6 deletions(-) >> >> diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml >> index 797fb05bf..006d1e6a4 100644 >> --- a/vswitchd/vswitch.xml >> +++ b/vswitchd/vswitch.xml >> @@ -3797,12 +3797,9 @@ ovs-vsctl add-port br0 p0 -- set Interface p0 type=patch options:peer=p1 \ >> Interface description string. >> </column> >> >> - <column name="status" key="pci-vendor_id"> >> - Vendor ID of PCI device. >> - </column> >> - >> - <column name="status" key="pci-device_id"> >> - Device ID of PCI device. >> + <column name="status" key="bus_info"> >> + Bus name and bus info such as Vendor ID and Device ID of PCI >> + device. >> </column> >> >> <column name="status" key="dpdk-vf-mac"> >> -- >> 2.39.2 >> >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
On 05.10.23 17:53, Kevin Traynor wrote: > On 05/10/2023 13:52, Eelco Chaudron wrote: >> On 4 Oct 2023, at 10:31, jmeng@redhat.com wrote: >> >>> From: Jakob Meng <code@jakobmeng.de> >>> >>> The status options pci-vendor_id and pci-device_id for dpdk netdevs >>> have been replaced by bus_info. This patch updates the documentation >>> in vswitchd/vswitch.xml accordingly. >>> >>> Fixes: a77c7796f23a ("dpdk: Update to use v22.11.1.") >> >> Thanks for fixing the documentation, however I think the commit message should somehow state this is related to the documentation. >> > > Message it probably ok, but yeah title might mislead so should mention docs. Maybe "netdev-dpdk: Update docs for interface info in vswitchd/vswitch.xml."?
On 6 Oct 2023, at 9:21, Jakob Meng wrote: > On 05.10.23 17:53, Kevin Traynor wrote: >> On 05/10/2023 13:52, Eelco Chaudron wrote: >>> On 4 Oct 2023, at 10:31, jmeng@redhat.com wrote: >>> >>>> From: Jakob Meng <code@jakobmeng.de> >>>> >>>> The status options pci-vendor_id and pci-device_id for dpdk netdevs >>>> have been replaced by bus_info. This patch updates the documentation >>>> in vswitchd/vswitch.xml accordingly. >>>> >>>> Fixes: a77c7796f23a ("dpdk: Update to use v22.11.1.") >>> >>> Thanks for fixing the documentation, however I think the commit message should somehow state this is related to the documentation. >>> >> >> Message it probably ok, but yeah title might mislead so should mention docs. I meant the subject of the commit message ;) > Maybe "netdev-dpdk: Update docs for interface info in vswitchd/vswitch.xml."? This looks good to me! Maybe send a new rev with this subject fixed and the added sign-off, and add my ACKs. Then Kevin, if you want, you can try to merge them. Cheers, Eelco
On 06.10.23 10:55, Eelco Chaudron wrote: > On 6 Oct 2023, at 9:21, Jakob Meng wrote: > >> On 05.10.23 17:53, Kevin Traynor wrote: >>> On 05/10/2023 13:52, Eelco Chaudron wrote: >>>> On 4 Oct 2023, at 10:31, jmeng@redhat.com wrote: >>>> >>>>> From: Jakob Meng <code@jakobmeng.de> >>>>> >>>>> The status options pci-vendor_id and pci-device_id for dpdk netdevs >>>>> have been replaced by bus_info. This patch updates the documentation >>>>> in vswitchd/vswitch.xml accordingly. >>>>> >>>>> Fixes: a77c7796f23a ("dpdk: Update to use v22.11.1.") >>>> Thanks for fixing the documentation, however I think the commit message should somehow state this is related to the documentation. >>>> >>> Message it probably ok, but yeah title might mislead so should mention docs. > I meant the subject of the commit message ;) > >> Maybe "netdev-dpdk: Update docs for interface info in vswitchd/vswitch.xml."? > This looks good to me! Maybe send a new rev with this subject fixed and the added sign-off, and add my ACKs. > > Then Kevin, if you want, you can try to merge them. Thank you, done ☺️ Patch v2: https://patchwork.ozlabs.org/project/openvswitch/patch/20231006090703.701871-1-jmeng@redhat.com/
On 6 Oct 2023, at 11:10, Jakob Meng wrote: > On 06.10.23 10:55, Eelco Chaudron wrote: >> On 6 Oct 2023, at 9:21, Jakob Meng wrote: >> >>> On 05.10.23 17:53, Kevin Traynor wrote: >>>> On 05/10/2023 13:52, Eelco Chaudron wrote: >>>>> On 4 Oct 2023, at 10:31, jmeng@redhat.com wrote: >>>>> >>>>>> From: Jakob Meng <code@jakobmeng.de> >>>>>> >>>>>> The status options pci-vendor_id and pci-device_id for dpdk >>>>>> netdevs >>>>>> have been replaced by bus_info. This patch updates the >>>>>> documentation >>>>>> in vswitchd/vswitch.xml accordingly. >>>>>> >>>>>> Fixes: a77c7796f23a ("dpdk: Update to use v22.11.1.") >>>>> Thanks for fixing the documentation, however I think the commit >>>>> message should somehow state this is related to the documentation. >>>>> >>>> Message it probably ok, but yeah title might mislead so should >>>> mention docs. >> I meant the subject of the commit message ;) >> >>> Maybe "netdev-dpdk: Update docs for interface info in >>> vswitchd/vswitch.xml."? >> This looks good to me! Maybe send a new rev with this subject fixed >> and the added sign-off, and add my ACKs. >> >> Then Kevin, if you want, you can try to merge them. > Thank you, done ☺️ > > Patch v2: > https://patchwork.ozlabs.org/project/openvswitch/patch/20231006090703.701871-1-jmeng@redhat.com/ One request, can you sent a v3 with for the whole series? If you make a change to a patch in a series, you should re-sent the entire series, including any ACKs added (or removed, if you made changes). This way we only need to track the latest version of the series, rather than each patch individually. Thanks, Eelco
On 06.10.23 11:17, Eelco Chaudron wrote: > > On 6 Oct 2023, at 11:10, Jakob Meng wrote: > > On 06.10.23 10:55, Eelco Chaudron wrote: >> On 6 Oct 2023, at 9:21, Jakob Meng wrote: >> >>> On 05.10.23 17:53, Kevin Traynor wrote: >>>> On 05/10/2023 13:52, Eelco Chaudron wrote: >>>>> On 4 Oct 2023, at 10:31, jmeng@redhat.com wrote: >>>>> >>>>>> From: Jakob Meng <code@jakobmeng.de> >>>>>> >>>>>> The status options pci-vendor_id and pci-device_id for dpdk netdevs >>>>>> have been replaced by bus_info. This patch updates the documentation >>>>>> in vswitchd/vswitch.xml accordingly. >>>>>> >>>>>> Fixes: a77c7796f23a ("dpdk: Update to use v22.11.1.") >>>>> Thanks for fixing the documentation, however I think the commit message should somehow state this is related to the documentation. >>>>> >>>> Message it probably ok, but yeah title might mislead so should mention docs. >> I meant the subject of the commit message ;) >> >>> Maybe "netdev-dpdk: Update docs for interface info in vswitchd/vswitch.xml."? >> This looks good to me! Maybe send a new rev with this subject fixed and the added sign-off, and add my ACKs. >> >> Then Kevin, if you want, you can try to merge them. > Thank you, done ☺️ > > Patch v2: https://patchwork.ozlabs.org/project/openvswitch/patch/20231006090703.701871-1-jmeng@redhat.com/ > > > One request, can you sent a v3 with for the whole series? If you make a change to a patch in a series, you should re-sent the entire series, including any ACKs added (or removed, if you made changes). This way we only need to track the latest version of the series, rather than each patch individually. > Done, v3 series: https://patchwork.ozlabs.org/project/openvswitch/list/?series=376419
On 06/10/2023 09:55, Eelco Chaudron wrote: > > > On 6 Oct 2023, at 9:21, Jakob Meng wrote: > >> On 05.10.23 17:53, Kevin Traynor wrote: >>> On 05/10/2023 13:52, Eelco Chaudron wrote: >>>> On 4 Oct 2023, at 10:31, jmeng@redhat.com wrote: >>>> >>>>> From: Jakob Meng <code@jakobmeng.de> >>>>> >>>>> The status options pci-vendor_id and pci-device_id for dpdk netdevs >>>>> have been replaced by bus_info. This patch updates the documentation >>>>> in vswitchd/vswitch.xml accordingly. >>>>> >>>>> Fixes: a77c7796f23a ("dpdk: Update to use v22.11.1.") >>>> >>>> Thanks for fixing the documentation, however I think the commit message should somehow state this is related to the documentation. >>>> >>> >>> Message it probably ok, but yeah title might mislead so should mention docs. > > I meant the subject of the commit message ;) > >> Maybe "netdev-dpdk: Update docs for interface info in vswitchd/vswitch.xml."? > > This looks good to me! Maybe send a new rev with this subject fixed and the added sign-off, and add my ACKs. > > Then Kevin, if you want, you can try to merge them. > ok, I'll take a look over v3 and apply, thanks. > > Cheers, > > Eelco >
diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index 797fb05bf..006d1e6a4 100644 --- a/vswitchd/vswitch.xml +++ b/vswitchd/vswitch.xml @@ -3797,12 +3797,9 @@ ovs-vsctl add-port br0 p0 -- set Interface p0 type=patch options:peer=p1 \ Interface description string. </column> - <column name="status" key="pci-vendor_id"> - Vendor ID of PCI device. - </column> - - <column name="status" key="pci-device_id"> - Device ID of PCI device. + <column name="status" key="bus_info"> + Bus name and bus info such as Vendor ID and Device ID of PCI + device. </column> <column name="status" key="dpdk-vf-mac">
From: Jakob Meng <code@jakobmeng.de> The status options pci-vendor_id and pci-device_id for dpdk netdevs have been replaced by bus_info. This patch updates the documentation in vswitchd/vswitch.xml accordingly. Fixes: a77c7796f23a ("dpdk: Update to use v22.11.1.") --- vswitchd/vswitch.xml | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)