Message ID | 20230926103938.334055-1-luca.ceresoli@bootlin.com |
---|---|
State | Handled Elsewhere |
Headers | show |
Series | pinctrl: tegra: add OF node when logging OF parsing errors | expand |
On Tue, Sep 26, 2023 at 12:39:38PM +0200, Luca Ceresoli wrote: > These errors are not quite clear without also logging they device tree node > being parsed, especially when the pinmux node has lots of subnodes. Adding > the node name helps a lot in finding the node that triggers the error. > > Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> > --- > drivers/pinctrl/tegra/pinctrl-tegra.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Acked-by: Thierry Reding <treding@nvidia.com>
On Tue, Sep 26, 2023 at 12:39 PM Luca Ceresoli <luca.ceresoli@bootlin.com> wrote: > These errors are not quite clear without also logging they device tree node > being parsed, especially when the pinmux node has lots of subnodes. Adding > the node name helps a lot in finding the node that triggers the error. > > Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Patch applied! Yours, Linus Walleij
diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c index 734c71ef005b..6bf8db424bec 100644 --- a/drivers/pinctrl/tegra/pinctrl-tegra.c +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c @@ -120,7 +120,7 @@ static int tegra_pinctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev, /* EINVAL=missing, which is fine since it's optional */ if (ret != -EINVAL) dev_err(dev, - "could not parse property nvidia,function\n"); + "%pOF: could not parse property nvidia,function\n", np); function = NULL; } @@ -134,8 +134,8 @@ static int tegra_pinctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev, goto exit; /* EINVAL=missing, which is fine since it's optional */ } else if (ret != -EINVAL) { - dev_err(dev, "could not parse property %s\n", - cfg_params[i].property); + dev_err(dev, "%pOF: could not parse property %s\n", + np, cfg_params[i].property); } } @@ -146,7 +146,7 @@ static int tegra_pinctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev, reserve++; ret = of_property_count_strings(np, "nvidia,pins"); if (ret < 0) { - dev_err(dev, "could not parse property nvidia,pins\n"); + dev_err(dev, "%pOF: could not parse property nvidia,pins\n", np); goto exit; } reserve *= ret;
These errors are not quite clear without also logging they device tree node being parsed, especially when the pinmux node has lots of subnodes. Adding the node name helps a lot in finding the node that triggers the error. Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> --- drivers/pinctrl/tegra/pinctrl-tegra.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)