| Message ID | 20230926124254.127465-1-matthias.schiffer@ew.tq-group.com |
|---|---|
| State | Accepted |
| Commit | fb730a2c5ac906730ca9e91f0178a77bdef1bb3a |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | mailbox: k3-sec-proxy: fix error handling for missing scfg in FDT | expand |
On 14:42-20230926, Matthias Schiffer wrote: > The wrong field was checked. > > Fixes: f9aa41023bd9 ("mailbox: Introduce K3 Secure Proxy Driver") > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> > --- > drivers/mailbox/k3-sec-proxy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mailbox/k3-sec-proxy.c b/drivers/mailbox/k3-sec-proxy.c > index 815808498f2..27072610462 100644 > --- a/drivers/mailbox/k3-sec-proxy.c > +++ b/drivers/mailbox/k3-sec-proxy.c > @@ -326,7 +326,7 @@ static int k3_sec_proxy_of_to_priv(struct udevice *dev, > } > > spm->scfg = devfdt_get_addr_name(dev, "scfg"); > - if (spm->rt == FDT_ADDR_T_NONE) { > + if (spm->scfg == FDT_ADDR_T_NONE) { > dev_err(dev, "No reg property for Secure Cfg base\n"); > return -EINVAL; > } Uggh.. Thanks for catching this. Reviewed-by: Nishanth Menon <nm@ti.com>
On Tue, Sep 26, 2023 at 02:42:54PM +0200, Matthias Schiffer wrote: > The wrong field was checked. > > Fixes: f9aa41023bd9 ("mailbox: Introduce K3 Secure Proxy Driver") > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> > Reviewed-by: Nishanth Menon <nm@ti.com> Applied to u-boot/master, thanks!
diff --git a/drivers/mailbox/k3-sec-proxy.c b/drivers/mailbox/k3-sec-proxy.c index 815808498f2..27072610462 100644 --- a/drivers/mailbox/k3-sec-proxy.c +++ b/drivers/mailbox/k3-sec-proxy.c @@ -326,7 +326,7 @@ static int k3_sec_proxy_of_to_priv(struct udevice *dev, } spm->scfg = devfdt_get_addr_name(dev, "scfg"); - if (spm->rt == FDT_ADDR_T_NONE) { + if (spm->scfg == FDT_ADDR_T_NONE) { dev_err(dev, "No reg property for Secure Cfg base\n"); return -EINVAL; }
The wrong field was checked. Fixes: f9aa41023bd9 ("mailbox: Introduce K3 Secure Proxy Driver") Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> --- drivers/mailbox/k3-sec-proxy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)