Message ID | 20230920173845.12956-1-asmaa@nvidia.com |
---|---|
Headers | show |
Series | UBUNTU: SAUCE: mlxbf-gige: Enable the OOB port in mlxbf_gige_open | expand |
Acked-by: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz@canonical.com> (reply to the correct mail this time) On Wed, Sep 20, 2023 at 7:39 PM Asmaa Mnebhi <asmaa@nvidia.com> wrote: > > BugLink: https://bugs.launchpad.net/bugs/2035128 > > SRU Justification: > > [Impact] > > At the moment, the OOB port is enabled in the mlxbf_gige_probe function. If the mlxbf_gige_open is not executed, this could cause pause frames to increase in the case where there is high backgroud traffic. This results in clogging the BMC port as well. > > [Fix] > > * Move enabling the OOB port to mlxbf_gige_open. > > [Test Case] > > * Main test for this bug: Check that the BMC is always pingable while pushing a BFB > > Other tests: > * Check if the gige driver is loaded > * Check that the oob_net0 interface is up and operational > * Do the reboot test and powercycle test and check the oob_net0 interface again > * Push BFB multiple times and make sure the OOB is up and running > > [Regression Potential] > > Since are moving code that hasn't moved since BF2, it is important to make sure that there is no regression. > Make sure that the OOB interface is always up and pingable after the reboot test, the powercycle test and after pushing a BFB. >
Acked-by: Agathe Porte <agathe.porte@canonical.com> On 20/09/2023 19:38, Asmaa Mnebhi wrote: > BugLink: https://bugs.launchpad.net/bugs/2035128 > > SRU Justification: > > [Impact] > > At the moment, the OOB port is enabled in the mlxbf_gige_probe function. If the mlxbf_gige_open is not executed, this could cause pause frames to increase in the case where there is high backgroud traffic. This results in clogging the BMC port as well. > > [Fix] > > * Move enabling the OOB port to mlxbf_gige_open. > > [Test Case] > > * Main test for this bug: Check that the BMC is always pingable while pushing a BFB > > Other tests: > * Check if the gige driver is loaded > * Check that the oob_net0 interface is up and operational > * Do the reboot test and powercycle test and check the oob_net0 interface again > * Push BFB multiple times and make sure the OOB is up and running > > [Regression Potential] > > Since are moving code that hasn't moved since BF2, it is important to make sure that there is no regression. > Make sure that the OOB interface is always up and pingable after the reboot test, the powercycle test and after pushing a BFB. >
Applied to focal:linux-bluefield/master-next. Thanks. -- Best regards, Bartlomiej On Wed, Sep 20, 2023 at 7:39 PM Asmaa Mnebhi <asmaa@nvidia.com> wrote: > > BugLink: https://bugs.launchpad.net/bugs/2035128 > > SRU Justification: > > [Impact] > > At the moment, the OOB port is enabled in the mlxbf_gige_probe function. If the mlxbf_gige_open is not executed, this could cause pause frames to increase in the case where there is high backgroud traffic. This results in clogging the BMC port as well. > > [Fix] > > * Move enabling the OOB port to mlxbf_gige_open. > > [Test Case] > > * Main test for this bug: Check that the BMC is always pingable while pushing a BFB > > Other tests: > * Check if the gige driver is loaded > * Check that the oob_net0 interface is up and operational > * Do the reboot test and powercycle test and check the oob_net0 interface again > * Push BFB multiple times and make sure the OOB is up and running > > [Regression Potential] > > Since are moving code that hasn't moved since BF2, it is important to make sure that there is no regression. > Make sure that the OOB interface is always up and pingable after the reboot test, the powercycle test and after pushing a BFB. >