| Message ID | 20230918083231.20092-1-mps@arvanta.net |
|---|---|
| State | Accepted |
| Delegated to: | Andes |
| Headers | show |
| Series | [1/1] starfive: visionfive2: add mmc0 and nvme boot targets | expand |
On Mon, Sep 18, 2023 at 10:32:29AM +0200, Milan P. Stanić wrote: > boot from SDIO3.0 (mmc sdcard) first if it is plugged. > If mmc is not plugged try to boot from emmc if it is plugged. > If emmc is not plugged then try to boot from nvme. > > Signed-off-by: Milan P. Stanić <mps@arvanta.net> > --- > include/configs/starfive-visionfive2.h | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
Hi Leo, On Wed, 20 Sept 2023 at 06:46, Leo Liang <ycliang@andestech.com> wrote: > > On Mon, Sep 18, 2023 at 10:32:29AM +0200, Milan P. Stanić wrote: > > boot from SDIO3.0 (mmc sdcard) first if it is plugged. > > If mmc is not plugged try to boot from emmc if it is plugged. > > If emmc is not plugged then try to boot from nvme. > > > > Signed-off-by: Milan P. Stanić <mps@arvanta.net> > > --- > > include/configs/starfive-visionfive2.h | 2 ++ > > 1 file changed, 2 insertions(+) > > Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com> How about converting to standard boot and then this will be automatic? Regards, Simon
On Sat, Sep 23, 2023 at 01:53:30PM -0600, Simon Glass wrote: > Hi Leo, > > On Wed, 20 Sept 2023 at 06:46, Leo Liang <ycliang@andestech.com> wrote: > > > > On Mon, Sep 18, 2023 at 10:32:29AM +0200, Milan P. Stanić wrote: > > > boot from SDIO3.0 (mmc sdcard) first if it is plugged. > > > If mmc is not plugged try to boot from emmc if it is plugged. > > > If emmc is not plugged then try to boot from nvme. > > > > > > Signed-off-by: Milan P. Stanić <mps@arvanta.net> > > > --- > > > include/configs/starfive-visionfive2.h | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com> > > How about converting to standard boot and then this will be automatic? Hi Simon, Do you mean that we should implement this feature in a more general manner, instead of implementing this in only on vf2 board ? Best regards, Leo > > Regards, > Simon
diff --git a/include/configs/starfive-visionfive2.h b/include/configs/starfive-visionfive2.h index 4ee02b8420..13cf2aeef9 100644 --- a/include/configs/starfive-visionfive2.h +++ b/include/configs/starfive-visionfive2.h @@ -19,6 +19,8 @@ #define BOOT_TARGET_DEVICES(func) \ func(MMC, mmc, 1) \ + func(MMC, mmc, 0) \ + func(NVME, nvme, 0) \ func(DHCP, dhcp, na) #include <config_distro_bootcmd.h>
boot from SDIO3.0 (mmc sdcard) first if it is plugged. If mmc is not plugged try to boot from emmc if it is plugged. If emmc is not plugged then try to boot from nvme. Signed-off-by: Milan P. Stanić <mps@arvanta.net> --- include/configs/starfive-visionfive2.h | 2 ++ 1 file changed, 2 insertions(+)