diff mbox series

[v2,1/2] dt-bindings: mfd: syscon: Add ti,am654-dss-oldi-io-ctrl compatible

Message ID 20230911142556.64108-1-afd@ti.com
State Not Applicable, archived
Headers show
Series [v2,1/2] dt-bindings: mfd: syscon: Add ti,am654-dss-oldi-io-ctrl compatible | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Andrew Davis Sept. 11, 2023, 2:25 p.m. UTC
Add TI DSS OLDI-IO control registers compatible. This is a region of 5
32bit registers found in the TI AM65 CTRL_MMR0 register space[0]. They
are used to control the characteristics of the OLDI DATA/CLK IO as needed
by the DSS display controller node.

[0] https://www.ti.com/lit/pdf/spruid7

Signed-off-by: Andrew Davis <afd@ti.com>
---

Changes for v2:
 - Use device specific compatible string

 Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Aradhya Bhatia Sept. 13, 2023, 2:49 p.m. UTC | #1
On 11/09/23 09:25, Andrew Davis wrote:
> This matches the binding for this register region which fixes a couple
> DTS check warnings.
> 
> While here trim the leading 0s from the "reg" definition.
> 
> Signed-off-by: Andrew Davis <afd@ti.com>

For both the patches, 1/2 and 2/2,

Reviewed-by: Aradhya Bhatia <a-bhatia1@ti.com>

> ---
>  arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index bc460033a37a8..d5f217427893d 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -498,8 +498,8 @@ serdes_mux: mux-controller {
>  		};
>  
>  		dss_oldi_io_ctrl: dss-oldi-io-ctrl@41e0 {
> -			compatible = "syscon";
> -			reg = <0x000041e0 0x14>;
> +			compatible = "ti,am654-dss-oldi-io-ctrl", "syscon";
> +			reg = <0x41e0 0x14>;
>  		};
>  
>  		ehrpwm_tbclk: clock-controller@4140 {
Lee Jones Sept. 14, 2023, 9:43 a.m. UTC | #2
On Wed, 13 Sep 2023, Aradhya Bhatia wrote:

> 
> 
> On 11/09/23 09:25, Andrew Davis wrote:
> > This matches the binding for this register region which fixes a couple
> > DTS check warnings.
> > 
> > While here trim the leading 0s from the "reg" definition.
> > 
> > Signed-off-by: Andrew Davis <afd@ti.com>
> 
> For both the patches, 1/2 and 2/2,

If you want to Ack both patches, you have to Ack both patches.

> Reviewed-by: Aradhya Bhatia <a-bhatia1@ti.com>
> 
> > ---
> >  arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> > index bc460033a37a8..d5f217427893d 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> > @@ -498,8 +498,8 @@ serdes_mux: mux-controller {
> >  		};
> >  
> >  		dss_oldi_io_ctrl: dss-oldi-io-ctrl@41e0 {
> > -			compatible = "syscon";
> > -			reg = <0x000041e0 0x14>;
> > +			compatible = "ti,am654-dss-oldi-io-ctrl", "syscon";
> > +			reg = <0x41e0 0x14>;
> >  		};
> >  
> >  		ehrpwm_tbclk: clock-controller@4140 {
Aradhya Bhatia Sept. 14, 2023, 1:47 p.m. UTC | #3
On 11/09/23 09:25, Andrew Davis wrote:
> Add TI DSS OLDI-IO control registers compatible. This is a region of 5
> 32bit registers found in the TI AM65 CTRL_MMR0 register space[0]. They
> are used to control the characteristics of the OLDI DATA/CLK IO as needed
> by the DSS display controller node.
> 
> [0] https://www.ti.com/lit/pdf/spruid7
> 
> Signed-off-by: Andrew Davis <afd@ti.com>

Reviewed-by: Aradhya Bhatia <a-bhatia1@ti.com>

> ---
> 
> Changes for v2:
>  - Use device specific compatible string
> 
>  Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 8103154bbb529..ab7e26c3469af 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -69,6 +69,7 @@ properties:
>                - rockchip,rk3588-qos
>                - rockchip,rv1126-qos
>                - starfive,jh7100-sysmain
> +              - ti,am654-dss-oldi-io-ctrl
>  
>            - const: syscon
>
Lee Jones Sept. 20, 2023, 1:06 p.m. UTC | #4
On Mon, 11 Sep 2023 09:25:55 -0500, Andrew Davis wrote:
> Add TI DSS OLDI-IO control registers compatible. This is a region of 5
> 32bit registers found in the TI AM65 CTRL_MMR0 register space[0]. They
> are used to control the characteristics of the OLDI DATA/CLK IO as needed
> by the DSS display controller node.
> 
> [0] https://www.ti.com/lit/pdf/spruid7
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: mfd: syscon: Add ti,am654-dss-oldi-io-ctrl compatible
      commit: 9cfffe6a730feea95e7bc827537f5b0a2931171c

--
Lee Jones [李琼斯]
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index 8103154bbb529..ab7e26c3469af 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -69,6 +69,7 @@  properties:
               - rockchip,rk3588-qos
               - rockchip,rv1126-qos
               - starfive,jh7100-sysmain
+              - ti,am654-dss-oldi-io-ctrl
 
           - const: syscon