diff mbox series

[v4] mtd: rawnand: qcom: Unmap the right resource upon probe failure

Message ID 20230912115903.1007-1-quic_bibekkum@quicinc.com
State New
Headers show
Series [v4] mtd: rawnand: qcom: Unmap the right resource upon probe failure | expand

Commit Message

Bibek Kumar Patro Sept. 12, 2023, 11:59 a.m. UTC 
We currently provide the physical address of the DMA region
rather than the output of dma_map_resource() which is obviously wrong.

Fixes: 7330fc505af4 ("mtd: rawnand: qcom: stop using phys_to_dma()")
Signed-off-by: Bibek Kumar Patro <quic_bibekkum@quicinc.com>
---
v4: Incorporated suggestion from Miquel
    - Modified title and commit description.

v3: Incorporated comments from Miquel
    - Modified the commit message and title as per suggestions.
    https://lore.kernel.org/all/20230912101814.7748-1-quic_bibekkum@quicinc.com/

v2: Incorporated comments from Pavan/Mani.
    https://lore.kernel.org/all/20230911133026.29868-1-quic_bibekkum@quicinc.com/

v1: https://lore.kernel.org/all/20230907092854.11408-1-quic_bibekkum@quicinc.com/

 drivers/mtd/nand/raw/qcom_nandc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.17.1

Comments

Miquel Raynal Sept. 12, 2023, 12:28 p.m. UTC | #1 
Hi Bibek,

quic_bibekkum@quicinc.com wrote on Tue, 12 Sep 2023 17:29:03 +0530:

> We currently provide the physical address of the DMA region
> rather than the output of dma_map_resource() which is obviously wrong.
> 
> Fixes: 7330fc505af4 ("mtd: rawnand: qcom: stop using phys_to_dma()")

Cc: stable?

> Signed-off-by: Bibek Kumar Patro <quic_bibekkum@quicinc.com>
> ---
> v4: Incorporated suggestion from Miquel
>     - Modified title and commit description.
> 
> v3: Incorporated comments from Miquel
>     - Modified the commit message and title as per suggestions.
>     https://lore.kernel.org/all/20230912101814.7748-1-quic_bibekkum@quicinc.com/
> 
> v2: Incorporated comments from Pavan/Mani.
>     https://lore.kernel.org/all/20230911133026.29868-1-quic_bibekkum@quicinc.com/
> 
> v1: https://lore.kernel.org/all/20230907092854.11408-1-quic_bibekkum@quicinc.com/
> 
>  drivers/mtd/nand/raw/qcom_nandc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c
> index 64499c1b3603..b079605c84d3 100644
> --- a/drivers/mtd/nand/raw/qcom_nandc.c
> +++ b/drivers/mtd/nand/raw/qcom_nandc.c
> @@ -3444,7 +3444,7 @@ static int qcom_nandc_probe(struct platform_device *pdev)
>  err_aon_clk:
>  	clk_disable_unprepare(nandc->core_clk);
>  err_core_clk:
> -	dma_unmap_resource(dev, res->start, resource_size(res),
> +	dma_unmap_resource(dev, nandc->base_dma, resource_size(res),
>  			   DMA_BIDIRECTIONAL, 0);
>  	return ret;
>  }
> --
> 2.17.1
> 


Thanks,
Miquèl
Bibek Kumar Patro Sept. 12, 2023, 2:32 p.m. UTC | #2 
On 9/12/2023 5:58 PM, Miquel Raynal wrote:
>> We currently provide the physical address of the DMA region
>> rather than the output of dma_map_resource() which is obviously wrong.
>>
>> Fixes: 7330fc505af4 ("mtd: rawnand: qcom: stop using phys_to_dma()")
> Cc: stable?
Cc: stable@vger.kernel.org
Manivannan Sadhasivam Sept. 12, 2023, 2:37 p.m. UTC | #3 
On Tue, Sep 12, 2023 at 08:02:07PM +0530, Bibek Kumar Patro wrote:
> 
> 
> On 9/12/2023 5:58 PM, Miquel Raynal wrote:
> > > We currently provide the physical address of the DMA region
> > > rather than the output of dma_map_resource() which is obviously wrong.
> > > 
> > > Fixes: 7330fc505af4 ("mtd: rawnand: qcom: stop using phys_to_dma()")
> > Cc: stable?
> Cc: stable@vger.kernel.org

You need to send another version adding the CC tag.

With the tag added,

Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>

- Mani
Bibek Kumar Patro Sept. 13, 2023, 7:08 a.m. UTC | #4 
On 9/12/2023 8:07 PM, Manivannan Sadhasivam wrote:
> On Tue, Sep 12, 2023 at 08:02:07PM +0530, Bibek Kumar Patro wrote:
>>
>>
>> On 9/12/2023 5:58 PM, Miquel Raynal wrote:
>>>> We currently provide the physical address of the DMA region
>>>> rather than the output of dma_map_resource() which is obviously wrong.
>>>>
>>>> Fixes: 7330fc505af4 ("mtd: rawnand: qcom: stop using phys_to_dma()")
>>> Cc: stable?
>> Cc: stable@vger.kernel.org
> 
> You need to send another version adding the CC tag.

Sure Mani, sent a new patch with cc tag. Addressed in v5 patchset.

> 
> With the tag added,
> 
> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
> 

Added in v5 patch.

> - Mani
> 

Thanks & regards,
Bibek
diff mbox series

Patch

diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c
index 64499c1b3603..b079605c84d3 100644
--- a/drivers/mtd/nand/raw/qcom_nandc.c
+++ b/drivers/mtd/nand/raw/qcom_nandc.c
@@ -3444,7 +3444,7 @@  static int qcom_nandc_probe(struct platform_device *pdev)
 err_aon_clk:
 	clk_disable_unprepare(nandc->core_clk);
 err_core_clk:
-	dma_unmap_resource(dev, res->start, resource_size(res),
+	dma_unmap_resource(dev, nandc->base_dma, resource_size(res),
 			   DMA_BIDIRECTIONAL, 0);
 	return ret;
 }